From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Ard Biesheuvel <ardb@kernel.org>, devel@edk2.groups.io
Cc: Leif Lindholm <quic_llindhol@quicinc.com>,
Thomas Abraham <thomas.abraham@arm.com>,
"nd@arm.com" <nd@arm.com>
Subject: Re: [PATCH edk2-platforms 1/4] Platform/ARM/BootMonFs: drop spurious dependency on ArmPlatformPkg
Date: Wed, 19 Oct 2022 13:46:56 +0100 [thread overview]
Message-ID: <7b597192-3229-e616-31e3-48284fd9da91@arm.com> (raw)
In-Reply-To: <20221019103555.493477-2-ardb@kernel.org>
Hi Ard,
Thank you for this patch.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
On 19/10/2022 11:35 am, Ard Biesheuvel wrote:
> Don't include NorFlashPlatformLib.h unnecessarily from BootMonFs, and
> drop the reference to ArmPlatformPkg.dec, which isn't needed after that
> either.
>
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> ---
> Platform/ARM/Drivers/BootMonFs/BootMonFs.inf | 1 -
> Platform/ARM/Drivers/BootMonFs/BootMonFsImages.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/Platform/ARM/Drivers/BootMonFs/BootMonFs.inf b/Platform/ARM/Drivers/BootMonFs/BootMonFs.inf
> index 7c2e2161869e..d9824c8b4fcd 100644
> --- a/Platform/ARM/Drivers/BootMonFs/BootMonFs.inf
> +++ b/Platform/ARM/Drivers/BootMonFs/BootMonFs.inf
> @@ -25,7 +25,6 @@ [Sources]
> BootMonFsUnsupported.c
>
>
>
> [Packages]
>
> - ArmPlatformPkg/ArmPlatformPkg.dec
>
> MdePkg/MdePkg.dec
>
> MdeModulePkg/MdeModulePkg.dec
>
> Platform/ARM/ARM.dec
>
> diff --git a/Platform/ARM/Drivers/BootMonFs/BootMonFsImages.c b/Platform/ARM/Drivers/BootMonFs/BootMonFsImages.c
> index 16bef8e3b1cd..114e937b7a46 100644
> --- a/Platform/ARM/Drivers/BootMonFs/BootMonFsImages.c
> +++ b/Platform/ARM/Drivers/BootMonFs/BootMonFsImages.c
> @@ -7,7 +7,6 @@
> **/
>
>
>
> #include <Library/IoLib.h>
>
> -#include <Library/NorFlashPlatformLib.h>
>
> #include <Library/BaseMemoryLib.h>
>
> #include <Library/MemoryAllocationLib.h>
>
>
>
next prev parent reply other threads:[~2022-10-19 12:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 10:35 [PATCH edk2-platforms 0/4] Platform/ARM: clone ArmPlatformPkg's NorFlashDxe Ard Biesheuvel
2022-10-19 10:35 ` [PATCH edk2-platforms 1/4] Platform/ARM/BootMonFs: drop spurious dependency on ArmPlatformPkg Ard Biesheuvel
2022-10-19 12:46 ` Sami Mujawar [this message]
2022-10-19 10:35 ` [PATCH edk2-platforms 2/4] Platform/ARM: create local definition of NorFlashPlatformLib Ard Biesheuvel
2022-10-19 12:51 ` [edk2-devel] " Sunil V L
2022-10-19 12:52 ` Sami Mujawar
2022-10-19 12:56 ` [edk2-devel] " Ard Biesheuvel
2022-10-19 13:26 ` Sunil V L
2022-10-19 10:35 ` [PATCH edk2-platforms 3/4] Platform/ARM: clone NorFlashDxe from ArmPlatformPkg Ard Biesheuvel
2022-10-19 12:52 ` Sami Mujawar
2022-10-19 10:35 ` [PATCH edk2-platforms 4/4] Platform/ARM: switch to local version of NorFlashDxe drivers Ard Biesheuvel
2022-10-19 12:53 ` Sami Mujawar
2022-10-19 15:12 ` [PATCH edk2-platforms 0/4] Platform/ARM: clone ArmPlatformPkg's NorFlashDxe Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b597192-3229-e616-31e3-48284fd9da91@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox