From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.57]) by mx.groups.io with SMTP id smtpd.web09.7389.1666183642630231949 for ; Wed, 19 Oct 2022 05:47:23 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=gPdntIX6; spf=pass (domain: arm.com, ip: 40.107.21.57, mailfrom: sami.mujawar@arm.com) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=XSwuTwmSOXHUg424YbYW+JNGjWsNUzD0FifFEBaMfC80AlvTHXQCjZAuVGK/dEFZCnSeU4sOYvFVYfPWGO8rqZFrl16B3xfpXvzNYm2sKc0jTwhz6GGaveFWW16ncNJ86vT6OETtKkWTrKi5FsdjCk+b+20kHa8Wh/D++MoD34iq3BoMfl0U7uIvD0jNNqZ+RV3+3EsaL7cRKHKkcPhTu62wFMU9ebDkaYiEZQrt5yf6EuAp/5X1CjK4/kpMzQTjuz1t9RnB/ulbLeRrNe9qsJQgpuQH1xWHM/PRCWzsCk3NSQzZPvyt0KCK0hZqjT2Uvx0fHhFFxxr9FLGrHCflng== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ils2hM6dX2AkkfBOXkcKWsRGim7jQr7uRhTRR0bbawU=; b=B21LQYLPfIJagOZcMC8AGlqK6fUu+P/lFcV8G+xavFbHOS8adfpqG9nLnM9p/4aaCo3ZjiN8ZigYwJ55FrCf7/CCe6DXbI+i9FZd5DcGn15k9jSpp2DhMdC9UiF/K6XKjPABJKsvLxbrm0D7GDWG0OGZpTrZ6cLIHXMZD/UirK5LdwiHu1TkMLjFF7gzvSR/xDENGZkZ96KiuOkcTkfLqfbacCPvUDy09fd+ohPHS36t1F7zCPC4D/83QyWdJFmehpD2xbrR9xkdQBlZnq90CJli4Z2jKDByhQt6BYaA3STEjAXOyQoeQHrebc1uluBMr1IjFRHeXqO35C/ONwBEwA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ils2hM6dX2AkkfBOXkcKWsRGim7jQr7uRhTRR0bbawU=; b=gPdntIX6m2a59Y+KkeXByFicIsJX55vgbz4JHVujj4cYPZQUd4tdxv1wx1C6e0TZdLzlFyO3Ra4B92rqD8RtNLQOFQNPvXgeDoN/hd3Zo2S6kS6KT2ecuC872UMwgkS1Wg5fkI7HBHKQ+OlOMQ0RrfuldpADDzCSOujTcTcOglw= Received: from FR3P281CA0152.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::6) by DB3PR08MB9058.eurprd08.prod.outlook.com (2603:10a6:10:430::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32; Wed, 19 Oct 2022 12:47:10 +0000 Received: from VI1EUR03FT065.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:a2:cafe::9) by FR3P281CA0152.outlook.office365.com (2603:10a6:d10:a2::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.17 via Frontend Transport; Wed, 19 Oct 2022 12:47:10 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT065.mail.protection.outlook.com (100.127.144.171) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32 via Frontend Transport; Wed, 19 Oct 2022 12:47:10 +0000 Received: ("Tessian outbound 58faf9791229:v130"); Wed, 19 Oct 2022 12:47:09 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 7ac8985fd03923d2 X-CR-MTA-TID: 64aa7808 Received: from 85d8a168e58a.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2780E984-A26E-49E1-81CE-9FE21C1A52DE.1; Wed, 19 Oct 2022 12:46:59 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 85d8a168e58a.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 19 Oct 2022 12:46:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S2bsvosePm4wsa6yoqI21oNXSRh4d+dsC+IdU7PD8+VHJXY36GM/ObAPwtr1GvpLgyUQrwf5fWXW1jwBHHqC3h6sPPY4QmInuw6gY0Br4ZrwHfc9pB19DdEhep9zyWOEEpleK9sdwEanScRPJdZy3FI+7vWgVRuS2AwPKOxx6C2UOnXgqHE+1ICx9HNlNhOhy9WI5drgW1dVE9qOnZ0caCoUSXvrdrXb9+kPuwSa5Dh+7QPcVvEze/+Uz+rK6Gg4or2yBi0QQPQe5b1vtsr83jUnEiK10y1woIMrjpDZCDngymVFkPmpx2S36ns4a18H+sjV2lZgm3iZCGexPz9UOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ils2hM6dX2AkkfBOXkcKWsRGim7jQr7uRhTRR0bbawU=; b=CGKSoVnmRSA9LMumz9gKvAEPkC4RzhJlo59QMZsqCaJ8jFO/BS2bKxm7hqTqf42Gt4Mo0MQrnEGIrFBU1nBB7psCriuC1HbRnkUFnTkC8UZuFV+khgRGExW4loWeVuknCqX4K9KrVJOhG8ayI0Jw9IVpYvsGfqQGhnGn+c8oWBrgzP9XkAHUHTh8pHtc7V8WCquUh+34PFDn07VtEK2Ia8PN20Po6nsTVUd9XXL9cmuK3wvkCNmqMOyPbfbQ+pdKE83SSUiEh9zyRyslu7KdL3JsN9ouaZNxp3rrw3IaEefiyBGk/gQH88pO0a1NdfDoZvDNy/+snBmMFz4kq8y1oA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ils2hM6dX2AkkfBOXkcKWsRGim7jQr7uRhTRR0bbawU=; b=gPdntIX6m2a59Y+KkeXByFicIsJX55vgbz4JHVujj4cYPZQUd4tdxv1wx1C6e0TZdLzlFyO3Ra4B92rqD8RtNLQOFQNPvXgeDoN/hd3Zo2S6kS6KT2ecuC872UMwgkS1Wg5fkI7HBHKQ+OlOMQ0RrfuldpADDzCSOujTcTcOglw= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AS8PR08MB6534.eurprd08.prod.outlook.com (2603:10a6:20b:31c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Wed, 19 Oct 2022 12:46:57 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::283c:fe2e:699d:2bf]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::283c:fe2e:699d:2bf%5]) with mapi id 15.20.5723.033; Wed, 19 Oct 2022 12:46:57 +0000 Message-ID: <7b597192-3229-e616-31e3-48284fd9da91@arm.com> Date: Wed, 19 Oct 2022 13:46:56 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH edk2-platforms 1/4] Platform/ARM/BootMonFs: drop spurious dependency on ArmPlatformPkg To: Ard Biesheuvel , devel@edk2.groups.io Cc: Leif Lindholm , Thomas Abraham , "nd@arm.com" References: <20221019103555.493477-1-ardb@kernel.org> <20221019103555.493477-2-ardb@kernel.org> From: "Sami Mujawar" In-Reply-To: <20221019103555.493477-2-ardb@kernel.org> X-ClientProxiedBy: LO2P123CA0012.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:a6::24) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|AS8PR08MB6534:EE_|VI1EUR03FT065:EE_|DB3PR08MB9058:EE_ X-MS-Office365-Filtering-Correlation-Id: 38b4a8fc-5fc8-4e8f-a6ed-08dab1d009cb x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: CNqyDTMTb2i+4lKTWOOdtXRwcvez/Zwr3+w6/CxuPZSWbojuB1QH+TkXVprXX6d7robWKi0vpkXA1b+EVj49jkOML7wunb6SMHpeSKPzH6RZewetjC+N2stXX6AYHoX4RnkeEkZ75UhP7jgngOnUGUY74l2IXbalo52Y8dMRCqj+uvwY5RFAHv7QIsspyFZJFv/mKU+alUBmgMHcaP+JAib9YLJ3O6+gQNENUYM0qG4SYqFCHzlrWC/4g+VOIhoOIf+YTwx0GGgZdxeXq88R3tTGGnCByb4wmh91Omw6QjiMgLG4xmQ0byBreCD47MVQiMP28IIhktfF8SnSM4q6ZpghU5THJD/DjzQWrjujEyLLnvvi4e+d27YxjS3BudTCYf6AOBOfG/3E0SonRAhRTnGLbyKh6LE0C+HzRj22PTr33bMdIy3XNmVXsisP8FBK1qjrjlCuch+Epr8fbiu2DRNcqdXrJp/Ay4JUktBhRgAzSZWSj/X/lEqF/DoH6QWdgcMVE2Py9CTWSs9Vp7hQbmWVDU0eWatv5yOeiISWa41I97XxO08Z2+hBdjhPFZiRdeR67TLUiq8hxYpINOOvnuL/YGxAUYGGhxdiiZ07FYgvh/t/dNMfNiEgNUXC192uIRWVKWSL4YXGT2r6+1rJU4wv/ScQAmVfqm9rCXO2UogLfvQkGA2fJbcCFrKPAwEVZ477TcUryxseLIyJ4iGCHqqYkA1IyTFct4VNjTSVLRVDFFtSYkVP9p2H+zXNPuF/++9EsRiSBMWWR0FEWoz5t+kN+x9dju+XI9+P7+T1eag= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(39860400002)(136003)(346002)(366004)(451199015)(44832011)(31686004)(2906002)(66946007)(41300700001)(66556008)(36756003)(66476007)(4326008)(8676002)(8936002)(5660300002)(26005)(83380400001)(6512007)(6506007)(186003)(2616005)(31696002)(54906003)(6486002)(316002)(86362001)(38100700002)(478600001)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6534 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT065.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f781928d-838d-437c-5b6e-08dab1d0020f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: T9BnarBhu4X0G2e2yb23abtFpbI/NkCu2c4auqINlMnQda4HYEFTFzN6rMHVlaJl2Ttr94Z45TeYHFTyXWKJoO2Iy9We7ScCMJvm9tmN7UDDuj7WtF4/TnJfCwddcW/eFWJNdGVDYFCFGJYV2KM1m4B845HMbtc+oVPuqbeuujfDDGIFUu1uD54Joh0Cegh4T6sOTuIYG8Km3BNq99WZS9elBiso8hK1MYsk4/i938dkrXFknlHVF2l9w4s1irrrLNbD4PdGk/3Yre3XS+TQW+kJt1YMDu395J9BzP0SHqhBlol8/+/xCKZn0cKutz2uZa2+ymXTiqt33/m4dVQvOsJi7ENaauO9AqCu3ja7qEolq7ldmKJ2xZxw1wacuozinCzNIpkV7qoGHsDAs/TzKKK3h/2UmHfCGIIZWsF7ZeUlviF/ah+HEUUUqGXh6ErtinhjP1Z5tkaboKadSO6n26Jd3z50xJ4+P8YFnX9TfRpLTCoMBUwd/wEB+uqrKOMebt4mb1CnDr+GWUPQJq90MYx0dKlBqYON0qH7FwogLKRMtgIDZPsN8Qn4wOootLfNKijDRAXTj/sgd39lNz93XbJf/yq+ueKSYdqos4ljVeiqkGaxs2Q/EPvUd9x1XBJLbVT1ZCR/XSNyLQsNYOLbr/F9K7r+4ln8VsKyoKBTQPp8EGP+uPMH6UCn0aht/sTyIdcE+pzmTPZGjbfJ8Pt1KahFyDUthFu4fDCGGVb2OZMwpz9gG7Wcy5jV6DpjqiPWUSf1z7O8QOj4UZZHSYZXSFc0lgzh2VVfuOxHa0a2SwwmT1TpY5PC4gAZxDQz+4uo X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(136003)(396003)(39860400002)(451199015)(36840700001)(40470700004)(46966006)(186003)(40480700001)(82740400003)(6512007)(53546011)(6506007)(44832011)(26005)(336012)(36756003)(47076005)(2906002)(2616005)(54906003)(8936002)(8676002)(41300700001)(5660300002)(4326008)(70206006)(70586007)(356005)(81166007)(82310400005)(316002)(31696002)(86362001)(478600001)(40460700003)(6486002)(31686004)(36860700001)(83380400001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 12:47:10.1064 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 38b4a8fc-5fc8-4e8f-a6ed-08dab1d009cb X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT065.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR08MB9058 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Ard, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 19/10/2022 11:35 am, Ard Biesheuvel wrote: > Don't include NorFlashPlatformLib.h unnecessarily from BootMonFs, and > drop the reference to ArmPlatformPkg.dec, which isn't needed after that > either. > > Signed-off-by: Ard Biesheuvel > --- > Platform/ARM/Drivers/BootMonFs/BootMonFs.inf | 1 - > Platform/ARM/Drivers/BootMonFs/BootMonFsImages.c | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/Platform/ARM/Drivers/BootMonFs/BootMonFs.inf b/Platform/ARM/Drivers/BootMonFs/BootMonFs.inf > index 7c2e2161869e..d9824c8b4fcd 100644 > --- a/Platform/ARM/Drivers/BootMonFs/BootMonFs.inf > +++ b/Platform/ARM/Drivers/BootMonFs/BootMonFs.inf > @@ -25,7 +25,6 @@ [Sources] > BootMonFsUnsupported.c > > > > [Packages] > > - ArmPlatformPkg/ArmPlatformPkg.dec > > MdePkg/MdePkg.dec > > MdeModulePkg/MdeModulePkg.dec > > Platform/ARM/ARM.dec > > diff --git a/Platform/ARM/Drivers/BootMonFs/BootMonFsImages.c b/Platform/ARM/Drivers/BootMonFs/BootMonFsImages.c > index 16bef8e3b1cd..114e937b7a46 100644 > --- a/Platform/ARM/Drivers/BootMonFs/BootMonFsImages.c > +++ b/Platform/ARM/Drivers/BootMonFs/BootMonFsImages.c > @@ -7,7 +7,6 @@ > **/ > > > > #include > > -#include > > #include > > #include > > >