* Re: [PATCH] Changed Maintainers.txt
[not found] <20181112050504.12720-1-zailiang.sun@intel.com>
@ 2018-11-13 1:41 ` Wei, David
2018-11-13 14:27 ` Laszlo Ersek
0 siblings, 1 reply; 3+ messages in thread
From: Wei, David @ 2018-11-13 1:41 UTC (permalink / raw)
To: Sun, Zailiang, edk2-devel@lists.01.org
Reviewed-by: David Wei <david.wei@intel.com>
Thanks,
David Wei
Intel SSG/STO/UEFI BIOS
-----Original Message-----
From: Sun, Zailiang
Sent: Monday, November 12, 2018 1:05 PM
To: edk2-devel@lists.01.org
Cc: Sun, Zailiang <zailiang.sun@intel.com>; Wei, David <david.wei@intel.com>
Subject: [PATCH] Changed Maintainers.txt
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zailiang Sun <zailiang.sun@intel.com>
CC: David Wei <david.wei@intel.com>
---
Maintainers.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Maintainers.txt b/Maintainers.txt
index b3048384c3..6ff80e76c2 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -3,8 +3,8 @@ MINNOWBOARD MAX/TURBOT PLATFORM Maintainers
Vlv2DeviceRefCodePkg
David Wei <david.wei@intel.com>
- Mang Guo <mang.guo@intel.com>
+ Zailiang Sun <zailiang.sun@intel.com>
Vlv2TbltDevicePkg
David Wei <david.wei@intel.com>
- Mang Guo <mang.guo@intel.com>
+ Zailiang Sun <zailiang.sun@intel.com>
--
2.19.1.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Changed Maintainers.txt
2018-11-13 1:41 ` [PATCH] Changed Maintainers.txt Wei, David
@ 2018-11-13 14:27 ` Laszlo Ersek
2018-11-14 7:33 ` Sun, Zailiang
0 siblings, 1 reply; 3+ messages in thread
From: Laszlo Ersek @ 2018-11-13 14:27 UTC (permalink / raw)
To: Wei, David, Sun, Zailiang, edk2-devel@lists.01.org
On 11/13/18 02:41, Wei, David wrote:
> Reviewed-by: David Wei <david.wei@intel.com>
(1) The original patch never reached the list. Is Zailiang Sun perhaps
not subscribed? I think maintainership requires that the maintainer be
subscribed.
(2) The subject line is a wreck. Zailiang, please resubmit the patch
with the following subject (or similar):
Maintainers.txt: update Vlv2*Pkg maintainers
(44 characters)
One more comment below:
> -----Original Message-----
> From: Sun, Zailiang
> Sent: Monday, November 12, 2018 1:05 PM
> To: edk2-devel@lists.01.org
> Cc: Sun, Zailiang <zailiang.sun@intel.com>; Wei, David <david.wei@intel.com>
> Subject: [PATCH] Changed Maintainers.txt
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Zailiang Sun <zailiang.sun@intel.com>
> CC: David Wei <david.wei@intel.com>
> ---
> Maintainers.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Maintainers.txt b/Maintainers.txt
> index b3048384c3..6ff80e76c2 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -3,8 +3,8 @@ MINNOWBOARD MAX/TURBOT PLATFORM Maintainers
>
> Vlv2DeviceRefCodePkg
> David Wei <david.wei@intel.com>
> - Mang Guo <mang.guo@intel.com>
> + Zailiang Sun <zailiang.sun@intel.com>
>
> Vlv2TbltDevicePkg
> David Wei <david.wei@intel.com>
> - Mang Guo <mang.guo@intel.com>
> + Zailiang Sun <zailiang.sun@intel.com>
>
(3) I don't understand how this patch was formatted. The context doesn't
match at all: the lines don't start with "M:". Here's how
"Maintainers.txt" looks on my end, at commit da2c81ee96eb:
-------------
Vlv2DeviceRefCodePkg
M: David Wei <david.wei@intel.com>
M: Mang Guo <mang.guo@intel.com>
Vlv2TbltDevicePkg
M: David Wei <david.wei@intel.com>
M: Mang Guo <mang.guo@intel.com>
-------------
Ahh! Wait a second. In the hunk header above, I see:
MINNOWBOARD MAX/TURBOT PLATFORM
That's totally not in the edk2 project. Is this patch perhaps for the
"edk2-platforms" tree? In that case:
- the subject prefix should not be [PATCH], but [PATCH edk2-platforms]
- I don't understand why edk2 and edk2-platforms *both* have
Vlv2DeviceRefCodePkg and Vlv2TbltDevicePkg directories!
Thanks
Laszlo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Changed Maintainers.txt
2018-11-13 14:27 ` Laszlo Ersek
@ 2018-11-14 7:33 ` Sun, Zailiang
0 siblings, 0 replies; 3+ messages in thread
From: Sun, Zailiang @ 2018-11-14 7:33 UTC (permalink / raw)
To: Laszlo Ersek, Wei, David, edk2-devel@lists.01.org
Thanks to Laszlo.
I've subscribed the edk2-devel mail list and send the formatted patch again.
Best Regards,
Zailiang
> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Tuesday, November 13, 2018 10:27 PM
> To: Wei, David <david.wei@intel.com>; Sun, Zailiang
> <zailiang.sun@intel.com>; edk2-devel@lists.01.org
> Subject: Re: [edk2] [PATCH] Changed Maintainers.txt
>
> On 11/13/18 02:41, Wei, David wrote:
> > Reviewed-by: David Wei <david.wei@intel.com>
>
> (1) The original patch never reached the list. Is Zailiang Sun perhaps
> not subscribed? I think maintainership requires that the maintainer be
> subscribed.
>
> (2) The subject line is a wreck. Zailiang, please resubmit the patch
> with the following subject (or similar):
>
> Maintainers.txt: update Vlv2*Pkg maintainers
>
> (44 characters)
>
> One more comment below:
>
> > -----Original Message-----
> > From: Sun, Zailiang
> > Sent: Monday, November 12, 2018 1:05 PM
> > To: edk2-devel@lists.01.org
> > Cc: Sun, Zailiang <zailiang.sun@intel.com>; Wei, David
> <david.wei@intel.com>
> > Subject: [PATCH] Changed Maintainers.txt
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Zailiang Sun <zailiang.sun@intel.com>
> > CC: David Wei <david.wei@intel.com>
> > ---
> > Maintainers.txt | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Maintainers.txt b/Maintainers.txt
> > index b3048384c3..6ff80e76c2 100644
> > --- a/Maintainers.txt
> > +++ b/Maintainers.txt
> > @@ -3,8 +3,8 @@ MINNOWBOARD MAX/TURBOT PLATFORM Maintainers
> >
> > Vlv2DeviceRefCodePkg
> > David Wei <david.wei@intel.com>
> > - Mang Guo <mang.guo@intel.com>
> > + Zailiang Sun <zailiang.sun@intel.com>
> >
> > Vlv2TbltDevicePkg
> > David Wei <david.wei@intel.com>
> > - Mang Guo <mang.guo@intel.com>
> > + Zailiang Sun <zailiang.sun@intel.com>
> >
>
> (3) I don't understand how this patch was formatted. The context doesn't
> match at all: the lines don't start with "M:". Here's how
> "Maintainers.txt" looks on my end, at commit da2c81ee96eb:
>
> -------------
> Vlv2DeviceRefCodePkg
> M: David Wei <david.wei@intel.com>
> M: Mang Guo <mang.guo@intel.com>
>
> Vlv2TbltDevicePkg
> M: David Wei <david.wei@intel.com>
> M: Mang Guo <mang.guo@intel.com>
> -------------
>
> Ahh! Wait a second. In the hunk header above, I see:
>
> MINNOWBOARD MAX/TURBOT PLATFORM
>
> That's totally not in the edk2 project. Is this patch perhaps for the
> "edk2-platforms" tree? In that case:
>
> - the subject prefix should not be [PATCH], but [PATCH edk2-platforms]
>
> - I don't understand why edk2 and edk2-platforms *both* have
> Vlv2DeviceRefCodePkg and Vlv2TbltDevicePkg directories!
>
>
> Thanks
> Laszlo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-14 7:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20181112050504.12720-1-zailiang.sun@intel.com>
2018-11-13 1:41 ` [PATCH] Changed Maintainers.txt Wei, David
2018-11-13 14:27 ` Laszlo Ersek
2018-11-14 7:33 ` Sun, Zailiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox