From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C40D02118D932 for ; Tue, 13 Nov 2018 06:27:14 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1215458E5D; Tue, 13 Nov 2018 14:27:14 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-87.rdu2.redhat.com [10.10.120.87]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3C9EC5D9C8; Tue, 13 Nov 2018 14:27:13 +0000 (UTC) To: "Wei, David" , "Sun, Zailiang" , "edk2-devel@lists.01.org" References: <20181112050504.12720-1-zailiang.sun@intel.com> <89954A0B46707A448411A627AD4EEE3473BD1FFD@SHSMSX101.ccr.corp.intel.com> From: Laszlo Ersek Message-ID: <7b5c45a5-b9fe-e476-fb0e-861f713ab76c@redhat.com> Date: Tue, 13 Nov 2018 15:27:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <89954A0B46707A448411A627AD4EEE3473BD1FFD@SHSMSX101.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Tue, 13 Nov 2018 14:27:14 +0000 (UTC) Subject: Re: [PATCH] Changed Maintainers.txt X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Nov 2018 14:27:15 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 11/13/18 02:41, Wei, David wrote: > Reviewed-by: David Wei (1) The original patch never reached the list. Is Zailiang Sun perhaps not subscribed? I think maintainership requires that the maintainer be subscribed. (2) The subject line is a wreck. Zailiang, please resubmit the patch with the following subject (or similar): Maintainers.txt: update Vlv2*Pkg maintainers (44 characters) One more comment below: > -----Original Message----- > From: Sun, Zailiang > Sent: Monday, November 12, 2018 1:05 PM > To: edk2-devel@lists.01.org > Cc: Sun, Zailiang ; Wei, David > Subject: [PATCH] Changed Maintainers.txt > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Zailiang Sun > CC: David Wei > --- > Maintainers.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Maintainers.txt b/Maintainers.txt > index b3048384c3..6ff80e76c2 100644 > --- a/Maintainers.txt > +++ b/Maintainers.txt > @@ -3,8 +3,8 @@ MINNOWBOARD MAX/TURBOT PLATFORM Maintainers > > Vlv2DeviceRefCodePkg > David Wei > - Mang Guo > + Zailiang Sun > > Vlv2TbltDevicePkg > David Wei > - Mang Guo > + Zailiang Sun > (3) I don't understand how this patch was formatted. The context doesn't match at all: the lines don't start with "M:". Here's how "Maintainers.txt" looks on my end, at commit da2c81ee96eb: ------------- Vlv2DeviceRefCodePkg M: David Wei M: Mang Guo Vlv2TbltDevicePkg M: David Wei M: Mang Guo ------------- Ahh! Wait a second. In the hunk header above, I see: MINNOWBOARD MAX/TURBOT PLATFORM That's totally not in the edk2 project. Is this patch perhaps for the "edk2-platforms" tree? In that case: - the subject prefix should not be [PATCH], but [PATCH edk2-platforms] - I don't understand why edk2 and edk2-platforms *both* have Vlv2DeviceRefCodePkg and Vlv2TbltDevicePkg directories! Thanks Laszlo