public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, heng.luo@intel.com
Cc: Ray Ni <ray.ni@intel.com>, Hao A Wu <hao.a.wu@intel.com>
Subject: Re: [edk2-devel] [Patch V3 2/2] MdeModulePkg/Bus/Pci/PciBusDxe: Support PCIe Resizable BAR Capability
Date: Mon, 11 Jan 2021 20:44:30 +0100	[thread overview]
Message-ID: <7b6ecc0d-0933-68a4-0eaa-917d38297e36@redhat.com> (raw)
In-Reply-To: <9a081622-94c8-d921-1631-b595f189c807@redhat.com>

Hi Heng,

On 01/11/21 20:38, Laszlo Ersek wrote:

> General request for the future: if you implement some kind of policy in
> core edk2, please at least *document* the policy somewhere. It's
> unacceptable to have to decipher the source code for such a possibly
> impactful change in the core. There is no need for a wiki page or an
> RFC, but a sane bugzilla ticket and a sane commit message are required.
> 
> (The documentation of the PCD in the "MdeModulePkg.dec" file is
> unsatisfactory too, and the UNI file has not been updated at all.)

Wow, I've even found the following regression in the bug tracker:

  https://bugzilla.tianocore.org/show_bug.cgi?id=3158

Your approach in

  https://bugzilla.tianocore.org/show_bug.cgi?id=3158#c1

is entirely wrong. It is not the burden of platform owners to fix up the
regression you have introduced. It is your responsibility to *not break*
existent use cases. You can offer the feature, and platforms that want
the feature may enable it (or you can enable it by default if you can
prove or test that no platform breaks in response).

Please revert this patch immediately, or flip the PCD default to FALSE
immediately.

Laszlo


  reply	other threads:[~2021-01-11 19:44 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-04  6:59 [Patch V3 1/2] MdePkg: Define structures for Resizable BAR Capability Heng Luo
2021-01-04  6:59 ` [Patch V3 2/2] MdeModulePkg/Bus/Pci/PciBusDxe: Support PCIe " Heng Luo
2021-01-04  7:52   ` Ni, Ray
2021-01-11 19:38   ` [edk2-devel] " Laszlo Ersek
2021-01-11 19:44     ` Laszlo Ersek [this message]
2021-01-12  2:28     ` Ni, Ray
2021-01-12  5:25       ` Heng Luo
2021-01-13  5:59       ` Wu, Hao A
2021-01-13  6:06         ` Ni, Ray
2021-01-13  6:15           ` Heng Luo
2021-01-13  6:16             ` Wu, Hao A
2021-01-13  9:08             ` Laszlo Ersek
2021-01-14  0:44               ` Heng Luo
2021-01-14  1:01                 ` Wu, Hao A
2021-01-04  7:52 ` [Patch V3 1/2] MdePkg: Define structures for " Ni, Ray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7b6ecc0d-0933-68a4-0eaa-917d38297e36@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox