From: "Jeremy Soller" <jeremy@system76.com>
To: "Michael A Kubacki" <michael.a.kubacki@intel.com>, devel@edk2.groups.io
Cc: "Chasel Chiu" <chasel.chiu@intel.com>,
"Nathaniel L Desimone" <nathaniel.l.desimone@intel.com>,
"Ankit Sinha" <ankit.sinha@intel.com>
Subject: Re: [edk2-platforms][PATCH V1 12/12] Add GalagoPro3 board details to global build and documentation
Date: Mon, 23 Sep 2019 16:38:24 -0600 [thread overview]
Message-ID: <7b7bf182-e66d-4d5f-8b74-f0ee325f89f1@www.fastmail.com> (raw)
In-Reply-To: <20190920184030.6148-13-michael.a.kubacki@intel.com>
Reviewed-by: Jeremy Soller <jeremy@system76.com>
On Fri, Sep 20, 2019, at 12:40 PM, Michael Kubacki wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2207
>
> * Updates maintainers for the System 76 GalagoPro3 board
> * Updated Readme.md with System 76 GalagoPro3 board details
> * Adds the ability to build the GalagoPro3 board to build.cfg
>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Ankit Sinha <ankit.sinha@intel.com>
> Cc: Jeremy Soller <jeremy@system76.com>
> Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com>
> ---
> Maintainers.txt | 3 ++
> Platform/Intel/Readme.md | 44 +++++++++++++-------
> Platform/Intel/build.cfg | 1 +
> 3 files changed, 34 insertions(+), 14 deletions(-)
>
> diff --git a/Maintainers.txt b/Maintainers.txt
> index a30ee2f602..1260c8d246 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -87,6 +87,9 @@ M: Chasel Chiu <chasel.chiu@intel.com>
> M: Michael Kubacki <michael.a.kubacki@intel.com>
> M: Nate DeSimone <nathaniel.l.desimone@intel.com>
>
> +Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3
> +R: Jeremy Soller <jeremy@system76.com>
> +
> Platform/Intel/MinPlatformPkg
> M: Michael Kubacki <michael.a.kubacki@intel.com>
> M: Chasel Chiu <chasel.chiu@intel.com>
> diff --git a/Platform/Intel/Readme.md b/Platform/Intel/Readme.md
> index 6a9b1d2e00..03fa4c2315 100644
> --- a/Platform/Intel/Readme.md
> +++ b/Platform/Intel/Readme.md
> @@ -83,6 +83,15 @@ A UEFI firmware implementation using MinPlatformPkg
> is constructed using the fol
>
> ----------------------------------------|--------------------------------------------|------------------------------|--------------------|
> | Simics Quick Start Package | Nehalem
> | SimicsOpenBoardPkg | BoardX58Ich10 |
>
> +#### System 76
> +
> +***Galago Pro Laptop***
> +
> +| Machine Name | Supported Chipsets
> | BoardPkg | Board Name |
> +----------------------------------------|--------------------------------------------|------------------------------|--------------------|
> +| galp2 | Kaby Lake
> | KabylakeOpenBoardPkg | GalagoPro3 |
> +| galp3 & galp3-b | Kaby Lake Refresh
> | KabylakeOpenBoardPkg | GalagoPro3 |
> +
> ## Board Package Organization
> The board package follows the standard EDK II package structure with
> the following additional elements and guidelines:
> * Only code usable across more than one board at the root level.
> @@ -217,28 +226,31 @@ return back to the minimum platform caller.
> | | | post-build, and clean
> functions.
> | | |
> | | |------KabylakeOpenBoardPkg
> - | | | |------KabylakeRvp3
> - | | | |---build_config.cfg:
> KabylakeRvp3 specific
> - | | | |
> build settings, environment variables.
> - | | | |---build_board.py:
> Optional board-specific pre-build, build
> - | | | and
> clean post-build functions.
> + | | | |------GalagoPro3
> + | | | | |---build_config.cfg:
> System 76 Galago Pro 3 specific build
> + | | | |
> settings environment variables.
> + | | | |------KabylakeRvp3
> + | | | |---build_config.cfg:
> KabylakeRvp3 specific
> + | | | | build
> settings, environment variables.
> + | | | |---build_board.py:
> Optional board-specific pre-build, build
> + | | | and
> clean post-build functions.
> | | |
> | | |------PurleyOpenBoardPkg
> | | | |------BoardMtOlympus
> - | | | |---build_config.cfg:
> BoardMtOlympus specific
> - | | | |
> build settings, environment variables.
> - | | | |---build_board.py:
> Optional board-specific pre-build,
> - | | | build,
> post-build and clean functions.
> + | | | |---build_config.cfg:
> BoardMtOlympus specific
> + | | | | build
> settings, environment variables.
> + | | | |---build_board.py:
> Optional board-specific pre-build,
> + | | | build,
> post-build and clean functions.
> | | |
> | | |------SimicsOpenBoardPkg
> | | | |------BoardX58Ich10
> - | | | |---build_config.cfg:
> BoardX58Ich10 specific
> - | | | |
> build settings, environment variables.
> + | | | |---build_config.cfg:
> BoardX58Ich10 specific
> + | | | build
> settings, environment variables.
> | | |
> | | |------WhiskeylakeOpenBoardPkg
> - | | | |------WhiskeylakeURvp
> - | | | |---build_config.cfg:
> WhiskeylakeURvp specific build
> - | | |
> settings environment variables.
> + | | | |------WhiskeylakeURvp
> + | | | |---build_config.cfg:
> WhiskeylakeURvp specific build
> + | | |
> settings environment variables.
> | | |
> |------FSP
> </pre>
> @@ -263,6 +275,10 @@ errors.
> ### **Known limitations**
>
> **KabylakeOpenBoardPkg**
> +*GalagoPro3*
> +1. The firmware project has not been tested on the Galago Pro 3B.
> +
> +*KabylakeRvp3*
> 1. This firmware project has only been tested for Microsoft Windows 10
> x64 boot with AHCI mode and Integrated Graphic
> Device.
>
> diff --git a/Platform/Intel/build.cfg b/Platform/Intel/build.cfg
> index 04e8f4fa64..2040774d1b 100644
> --- a/Platform/Intel/build.cfg
> +++ b/Platform/Intel/build.cfg
> @@ -54,5 +54,6 @@ NUMBER_OF_PROCESSORS = 0
> # board_name = path_to_board_build_config.cfg
> BoardMtOlympus = PurleyOpenBoardPkg/BoardMtOlympus/build_config.cfg
> BoardX58Ich10 = SimicsOpenBoardPkg/BoardX58Ich10/build_config.cfg
> +GalagoPro3 = KabylakeOpenBoardPkg/GalagoPro3/build_config.cfg
> KabylakeRvp3 = KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg
> WhiskeylakeURvp = WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/build_config.cfg
> --
> 2.16.2.windows.1
>
>
prev parent reply other threads:[~2019-09-23 22:38 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 18:40 [edk2-platforms][PATCH V1 00/12] Move ClevoOpenBoardPkg/N1xxWU Contents to KabylakeOpenBoardPkg Kubacki, Michael A
2019-09-20 18:40 ` [edk2-platforms][PATCH V1 01/12] Platform/Intel: Remove N1xxWU board build option Kubacki, Michael A
2019-09-23 7:45 ` [edk2-devel] " Nate DeSimone
2019-09-23 8:51 ` Chiu, Chasel
2019-09-23 20:28 ` Sinha, Ankit
2019-09-23 22:28 ` jeremy
2019-09-20 18:40 ` [edk2-platforms][PATCH V1 02/12] ClevoOpenBoardPkg: Remove package contents Kubacki, Michael A
2019-09-23 8:04 ` Nate DeSimone
2019-09-23 8:23 ` [edk2-devel] " Chiu, Chasel
2019-09-23 22:37 ` Jeremy Soller
2019-09-20 18:40 ` [edk2-platforms][PATCH V1 03/12] ClevoOpenBoardPkg: Remove global files and references Kubacki, Michael A
2019-09-23 0:49 ` [edk2-devel] " Chiu, Chasel
2019-09-23 8:05 ` Nate DeSimone
2019-09-23 22:39 ` Jeremy Soller
2019-09-20 18:40 ` [edk2-platforms][PATCH V1 04/12] KabylakeOpenBoardPkg: Move policy update libs to KabylakeRvp3 board Kubacki, Michael A
2019-09-23 8:07 ` [edk2-devel] " Nate DeSimone
2019-09-23 8:19 ` Chiu, Chasel
2019-09-23 22:38 ` Jeremy Soller
2019-09-20 18:40 ` [edk2-platforms][PATCH V1 05/12] KabylakeOpenBoardPkg: Move EcCommands.h " Kubacki, Michael A
2019-09-23 8:08 ` [edk2-devel] " Nate DeSimone
2019-09-23 8:25 ` Chiu, Chasel
2019-09-23 22:37 ` Jeremy Soller
2019-09-20 18:40 ` [edk2-platforms][PATCH V1 06/12] KabylakeOpenBoardPkg: Move flash map to board Kubacki, Michael A
2019-09-23 8:09 ` Nate DeSimone
2019-09-23 8:41 ` Chiu, Chasel
2019-09-23 22:36 ` Jeremy Soller
2019-09-20 18:40 ` [edk2-platforms][PATCH V1 07/12] KabylakeOpenBoardPkg: Add PeiSerialPortLibSpiFlash Kubacki, Michael A
2019-09-23 8:10 ` Nate DeSimone
2019-09-23 8:27 ` Chiu, Chasel
2019-09-23 22:37 ` Jeremy Soller
2019-09-20 18:40 ` [edk2-platforms][PATCH V1 08/12] KabylakeOpenBoardPkg/GalagoPro3: Add headers Kubacki, Michael A
2019-09-23 8:11 ` Nate DeSimone
2019-09-23 8:42 ` Chiu, Chasel
2019-09-23 22:35 ` [edk2-devel] " Jeremy Soller
2019-09-20 18:40 ` [edk2-platforms][PATCH V1 09/12] KabylakeOpenBoardPkg/GalagoPro3: Add library instances Kubacki, Michael A
2019-09-23 8:14 ` Nate DeSimone
2019-09-23 8:28 ` Chiu, Chasel
2019-09-23 22:36 ` Jeremy Soller
2019-09-23 22:36 ` Jeremy Soller
2019-09-20 18:40 ` [edk2-platforms][PATCH V1 10/12] KabylakeOpenBoardPkg/GalagoPro3: Add modules Kubacki, Michael A
2019-09-23 8:15 ` Nate DeSimone
2019-09-23 17:41 ` [edk2-devel] " Kubacki, Michael A
2019-09-23 8:45 ` Chiu, Chasel
2019-09-23 22:35 ` Jeremy Soller
2019-09-20 18:40 ` [edk2-platforms][PATCH V1 11/12] KabylakeOpenBoardPkg/GalagoPro3: Add build files Kubacki, Michael A
2019-09-23 8:16 ` Nate DeSimone
2019-09-23 8:36 ` [edk2-devel] " Chiu, Chasel
2019-09-23 22:36 ` Jeremy Soller
2019-09-20 18:40 ` [edk2-platforms][PATCH V1 12/12] Add GalagoPro3 board details to global build and documentation Kubacki, Michael A
2019-09-23 0:51 ` [edk2-devel] " Chiu, Chasel
2019-09-23 8:18 ` Nate DeSimone
2019-09-23 22:38 ` Jeremy Soller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b7bf182-e66d-4d5f-8b74-f0ee325f89f1@www.fastmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox