From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=tataCAf1; spf=permerror, err=too many SPF records (domain: system76.com, ip: 66.111.4.26, mailfrom: jeremy@system76.com) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by groups.io with SMTP; Mon, 23 Sep 2019 15:38:45 -0700 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 77C7521583; Mon, 23 Sep 2019 18:38:44 -0400 (EDT) Received: from imap2 ([10.202.2.52]) by compute1.internal (MEProxy); Mon, 23 Sep 2019 18:38:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=10gQ+F 9SrTFCOIn4KGEUf+cj4/q8AJW0v592xGzsayM=; b=tataCAf1PNNOiO7IWJHWiI khqHc942O9MXBEVdAiu8poFseyNHgnhlsRclV1H5QxVZ6XUmuA3OPxQLDlXOxGJz nOa/ATg7f5r34vKRps9WGuFcFT9scURRuqFoOeXppckRM6+8XsDtIrlbVrKKEor1 3P6Jw4FO+bKnDu1HbomsuCBLFnNWs3KYY5/wwTd6cnbNFIdAbvUp7E/dyMIbd9ZP rQJa1z6sQDLj0Cd2frj4v9fUhV3Ac3qJcFRiBEsoSrMH1VGnxu5iTicQdBLoihWv 182fgkWan4KVpIRWwJ2YJpqg12ZhlJt4kmMifE+KfWGc9aKAaCF2M4ixIiEXmoDg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrvdelgdduvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvufgtsehttdertderreejnecuhfhrohhmpedflfgvrhgv mhihucfuohhllhgvrhdfuceojhgvrhgvmhihsehshihsthgvmhejiedrtghomheqnecuff homhgrihhnpehtihgrnhhotghorhgvrdhorhhgnecurfgrrhgrmhepmhgrihhlfhhrohhm pehjvghrvghmhiesshihshhtvghmjeeirdgtohhmnecuvehluhhsthgvrhfuihiivgepie X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 3CF0AE00A5; Mon, 23 Sep 2019 18:38:44 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.1.7-238-g170a812-fmstable-20190913v1 Mime-Version: 1.0 Message-Id: <7b7bf182-e66d-4d5f-8b74-f0ee325f89f1@www.fastmail.com> In-Reply-To: <20190920184030.6148-13-michael.a.kubacki@intel.com> References: <20190920184030.6148-1-michael.a.kubacki@intel.com> <20190920184030.6148-13-michael.a.kubacki@intel.com> Date: Mon, 23 Sep 2019 16:38:24 -0600 From: "Jeremy Soller" To: "Michael A Kubacki" , devel@edk2.groups.io Cc: "Chasel Chiu" , "Nathaniel L Desimone" , "Ankit Sinha" Subject: Re: [edk2-platforms][PATCH V1 12/12] Add GalagoPro3 board details to global build and documentation Content-Type: text/plain Reviewed-by: Jeremy Soller On Fri, Sep 20, 2019, at 12:40 PM, Michael Kubacki wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2207 > > * Updates maintainers for the System 76 GalagoPro3 board > * Updated Readme.md with System 76 GalagoPro3 board details > * Adds the ability to build the GalagoPro3 board to build.cfg > > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Ankit Sinha > Cc: Jeremy Soller > Signed-off-by: Michael Kubacki > --- > Maintainers.txt | 3 ++ > Platform/Intel/Readme.md | 44 +++++++++++++------- > Platform/Intel/build.cfg | 1 + > 3 files changed, 34 insertions(+), 14 deletions(-) > > diff --git a/Maintainers.txt b/Maintainers.txt > index a30ee2f602..1260c8d246 100644 > --- a/Maintainers.txt > +++ b/Maintainers.txt > @@ -87,6 +87,9 @@ M: Chasel Chiu > M: Michael Kubacki > M: Nate DeSimone > > +Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3 > +R: Jeremy Soller > + > Platform/Intel/MinPlatformPkg > M: Michael Kubacki > M: Chasel Chiu > diff --git a/Platform/Intel/Readme.md b/Platform/Intel/Readme.md > index 6a9b1d2e00..03fa4c2315 100644 > --- a/Platform/Intel/Readme.md > +++ b/Platform/Intel/Readme.md > @@ -83,6 +83,15 @@ A UEFI firmware implementation using MinPlatformPkg > is constructed using the fol > > ----------------------------------------|--------------------------------------------|------------------------------|--------------------| > | Simics Quick Start Package | Nehalem > | SimicsOpenBoardPkg | BoardX58Ich10 | > > +#### System 76 > + > +***Galago Pro Laptop*** > + > +| Machine Name | Supported Chipsets > | BoardPkg | Board Name | > +----------------------------------------|--------------------------------------------|------------------------------|--------------------| > +| galp2 | Kaby Lake > | KabylakeOpenBoardPkg | GalagoPro3 | > +| galp3 & galp3-b | Kaby Lake Refresh > | KabylakeOpenBoardPkg | GalagoPro3 | > + > ## Board Package Organization > The board package follows the standard EDK II package structure with > the following additional elements and guidelines: > * Only code usable across more than one board at the root level. > @@ -217,28 +226,31 @@ return back to the minimum platform caller. > | | | post-build, and clean > functions. > | | | > | | |------KabylakeOpenBoardPkg > - | | | |------KabylakeRvp3 > - | | | |---build_config.cfg: > KabylakeRvp3 specific > - | | | | > build settings, environment variables. > - | | | |---build_board.py: > Optional board-specific pre-build, build > - | | | and > clean post-build functions. > + | | | |------GalagoPro3 > + | | | | |---build_config.cfg: > System 76 Galago Pro 3 specific build > + | | | | > settings environment variables. > + | | | |------KabylakeRvp3 > + | | | |---build_config.cfg: > KabylakeRvp3 specific > + | | | | build > settings, environment variables. > + | | | |---build_board.py: > Optional board-specific pre-build, build > + | | | and > clean post-build functions. > | | | > | | |------PurleyOpenBoardPkg > | | | |------BoardMtOlympus > - | | | |---build_config.cfg: > BoardMtOlympus specific > - | | | | > build settings, environment variables. > - | | | |---build_board.py: > Optional board-specific pre-build, > - | | | build, > post-build and clean functions. > + | | | |---build_config.cfg: > BoardMtOlympus specific > + | | | | build > settings, environment variables. > + | | | |---build_board.py: > Optional board-specific pre-build, > + | | | build, > post-build and clean functions. > | | | > | | |------SimicsOpenBoardPkg > | | | |------BoardX58Ich10 > - | | | |---build_config.cfg: > BoardX58Ich10 specific > - | | | | > build settings, environment variables. > + | | | |---build_config.cfg: > BoardX58Ich10 specific > + | | | build > settings, environment variables. > | | | > | | |------WhiskeylakeOpenBoardPkg > - | | | |------WhiskeylakeURvp > - | | | |---build_config.cfg: > WhiskeylakeURvp specific build > - | | | > settings environment variables. > + | | | |------WhiskeylakeURvp > + | | | |---build_config.cfg: > WhiskeylakeURvp specific build > + | | | > settings environment variables. > | | | > |------FSP > > @@ -263,6 +275,10 @@ errors. > ### **Known limitations** > > **KabylakeOpenBoardPkg** > +*GalagoPro3* > +1. The firmware project has not been tested on the Galago Pro 3B. > + > +*KabylakeRvp3* > 1. This firmware project has only been tested for Microsoft Windows 10 > x64 boot with AHCI mode and Integrated Graphic > Device. > > diff --git a/Platform/Intel/build.cfg b/Platform/Intel/build.cfg > index 04e8f4fa64..2040774d1b 100644 > --- a/Platform/Intel/build.cfg > +++ b/Platform/Intel/build.cfg > @@ -54,5 +54,6 @@ NUMBER_OF_PROCESSORS = 0 > # board_name = path_to_board_build_config.cfg > BoardMtOlympus = PurleyOpenBoardPkg/BoardMtOlympus/build_config.cfg > BoardX58Ich10 = SimicsOpenBoardPkg/BoardX58Ich10/build_config.cfg > +GalagoPro3 = KabylakeOpenBoardPkg/GalagoPro3/build_config.cfg > KabylakeRvp3 = KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg > WhiskeylakeURvp = WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/build_config.cfg > -- > 2.16.2.windows.1 > >