From: Ming Huang <ming.huang@linaro.org>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org,
graeme.gregory@linaro.org, ard.biesheuvel@linaro.org,
michael.d.kinney@intel.com, lersek@redhat.com,
wanghuiqiang@huawei.com, huangming23@huawei.com,
zhangjinsong2@huawei.com, huangdaode@hisilicon.com,
john.garry@huawei.com, xinliang.liu@linaro.org,
zhangfeng56@huawei.com
Subject: Re: [PATCH edk2-non-osi v1 2/7] Hisilicon/D0x: Rename StartupAp() function
Date: Tue, 12 Feb 2019 20:20:50 +0800 [thread overview]
Message-ID: <7b925e10-531d-1475-5ceb-62bf6bda6488@linaro.org> (raw)
In-Reply-To: <20190212121732.mdnutpj4x4v645zo@bivouac.eciton.net>
On 2/12/2019 8:17 PM, Leif Lindholm wrote:
> On Tue, Feb 12, 2019 at 08:07:52PM +0800, Ming Huang wrote:
>>>> For D06 library, we use the same source code to support all Hi1620 projects,
>>>> include product projects,so there are some modify for this, like support
>>>> 3 sockets, 4 sockets and remove some useless functions.
>>>
>>> So please reword the subject line of this commit to explain it is an
>>> overall update of PlatformSysCtrlLib - including which bits are dropped.
>>>
>>> And I think this makes a good argument for moving the header files for
>>> binary-only libraries from edk2-platforms to edk2-non-osi.
>>> If you do that in a separate patch before this one, you won't need to
>>> include as much detail in the commit message as you will otherwise.
>>
>> Do youe mean move PlatformSysCtrlLib.h, OemAddressMapLib.h and LpcLib.h to edk2-non-osi?
>
> Yes.
>
> Any interfaces exposed _only_ by implementations in edk2-non-osi.
> If there are any interfaces _also_ exposed by implementations in
> edk2-platforms, then I would prefer for them to remain in
> edk2-platforms.
>
> Ideally, this would also include (the multiple) SerdesLib.h,
> IpmiCmdLib.h, and possibly others.
Ok, I will do that in v2.
Thanks
>
> Regards,
>
> Leif
>
next prev parent reply other threads:[~2019-02-12 12:21 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-01 14:25 [PATCH edk2-non-osi v1 0/7] Upload D0x binary modules Ming Huang
2019-02-01 14:25 ` [PATCH edk2-non-osi v1 1/7] Hisilicon/D06: Optimize SAS driver for reducing boot time Ming Huang
2019-02-12 15:20 ` Leif Lindholm
2019-02-12 15:34 ` Ming Huang
2019-02-01 14:25 ` [PATCH edk2-non-osi v1 2/7] Hisilicon/D0x: Rename StartupAp() function Ming Huang
2019-02-11 21:36 ` Leif Lindholm
2019-02-12 8:05 ` Ming Huang
2019-02-12 10:44 ` Leif Lindholm
2019-02-12 12:07 ` Ming Huang
2019-02-12 12:17 ` Leif Lindholm
2019-02-12 12:20 ` Ming Huang [this message]
2019-02-01 14:25 ` [PATCH edk2-non-osi v1 3/7] Hisilicon/D06: Update Mbigen and gic RAS register Ming Huang
2019-02-11 21:38 ` Leif Lindholm
2019-02-12 11:42 ` Ming Huang
2019-02-12 12:06 ` Leif Lindholm
2019-02-01 14:25 ` [PATCH edk2-non-osi v1 4/7] Hisilicon/D06: Support PCIe local RAS Ming Huang
2019-02-12 15:20 ` Leif Lindholm
2019-02-01 14:25 ` [PATCH edk2-non-osi v1 5/7] Hisilicon/D06: Use new flash layout Ming Huang
2019-02-12 15:26 ` Leif Lindholm
2019-02-13 12:09 ` Ming Huang
2019-02-01 14:25 ` [PATCH edk2-non-osi v1 6/7] Hisilicon/D06: Fix numa node wrong issue Ming Huang
2019-02-11 14:48 ` Leif Lindholm
2019-02-12 12:17 ` Ming Huang
2019-02-01 14:25 ` [PATCH edk2-non-osi v1 7/7] Hisilicon/D06: Add Setup Item "Support DPC" Ming Huang
2019-02-12 15:27 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b925e10-531d-1475-5ceb-62bf6bda6488@linaro.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox