From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::444; helo=mail-pf1-x444.google.com; envelope-from=ming.huang@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C28F9201B0416 for ; Tue, 12 Feb 2019 04:21:01 -0800 (PST) Received: by mail-pf1-x444.google.com with SMTP id q17so1210683pfh.10 for ; Tue, 12 Feb 2019 04:21:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=QT8kmQXxdlJ1kKbqrRApZgD9e5nauRz59LhpuGGn03E=; b=tMXIKwGAXdEzMUE4kLKXvX5jYvlvtMU6RVpPs8/HI4ID0kWMszf/BDbs7E/pAdqNoe UPU+4jpbeFld/pNVvinytP6yB+oBIv59y7jM7c1vYtB55V60w+2OljyzdXni6PXPzSpa 72GXXql6fzExupule2bw+gbNvH9YmRgvAmCvEc5TvS14oCfle2yXbpZUUcDDSTH1G6PY 4kij6cbsWYPzuUmiM7UImjmedmvR7ZoQvsj/V+r63f5luxl1IJjZx03byNoZXllDRuRg xqrMAiMikHB0cGh+GBXRlvfRp2Vc1K4SlJ01vSzJNPaTvVE3JKQ2LMEDqA2LaJKYKf5x ucaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=QT8kmQXxdlJ1kKbqrRApZgD9e5nauRz59LhpuGGn03E=; b=QVInnj3UBe06NFHNvnVDuNLPFXveHIgpYD9SRP4Hx24AjXe6sQm1auGpx82KOJtR1Y hQ084tPnahPj5fpzCZMCZlLt25cexLJfITSPZ45Ap6t+uKheDOvyyZkODjTtGpQp+ZBR LHUib2PSrS0MOl11XO7399VsXPhG/V54iGbxW2puVkmOeafA6LYXRo7qYNJ3zo93UfDu EY13zOpHwYynTNQdZvSAjyest3gVJN59b2bfWHW86i5kmeWxwOV/AAaphAm+IpUanm7a 8cQXa9HEB3xtjlDAcnthL0TvBCHXEErDysZniG4DMtflTsmbbkpDTzOPsG6HN7HWCUUQ ty3w== X-Gm-Message-State: AHQUAuaOsjH9SrKLVgnvNAQdavFTqREUeIYkfTRsrS+gHlyhxRxGJWD7 23mATK3pyMrK8rIfI5dWWT1VSQ== X-Google-Smtp-Source: AHgI3IadPi+hseylYkaDmQkqIFj3aUTGdO0veJ8vBLJvuLTceU8MFhJzty00L4/WJZHQIUlr61y/5g== X-Received: by 2002:a62:3a01:: with SMTP id h1mr3608225pfa.169.1549974061360; Tue, 12 Feb 2019 04:21:01 -0800 (PST) Received: from [10.15.0.66] ([64.64.108.250]) by smtp.gmail.com with ESMTPSA id y19sm14383317pfm.181.2019.02.12.04.20.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Feb 2019 04:21:00 -0800 (PST) To: Leif Lindholm Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, lersek@redhat.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org, zhangfeng56@huawei.com References: <20190201142507.30454-1-ming.huang@linaro.org> <20190201142507.30454-3-ming.huang@linaro.org> <20190211213608.w7zqyap6vws4lam5@bivouac.eciton.net> <9c8d26cd-b0bb-e573-8a12-20259271c40e@linaro.org> <20190212104459.lifteascit2anj6h@bivouac.eciton.net> <51a23852-cfb8-a6c0-9a0d-21c39143d506@linaro.org> <20190212121732.mdnutpj4x4v645zo@bivouac.eciton.net> From: Ming Huang Message-ID: <7b925e10-531d-1475-5ceb-62bf6bda6488@linaro.org> Date: Tue, 12 Feb 2019 20:20:50 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20190212121732.mdnutpj4x4v645zo@bivouac.eciton.net> Subject: Re: [PATCH edk2-non-osi v1 2/7] Hisilicon/D0x: Rename StartupAp() function X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Feb 2019 12:21:01 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 2/12/2019 8:17 PM, Leif Lindholm wrote: > On Tue, Feb 12, 2019 at 08:07:52PM +0800, Ming Huang wrote: >>>> For D06 library, we use the same source code to support all Hi1620 projects, >>>> include product projects,so there are some modify for this, like support >>>> 3 sockets, 4 sockets and remove some useless functions. >>> >>> So please reword the subject line of this commit to explain it is an >>> overall update of PlatformSysCtrlLib - including which bits are dropped. >>> >>> And I think this makes a good argument for moving the header files for >>> binary-only libraries from edk2-platforms to edk2-non-osi. >>> If you do that in a separate patch before this one, you won't need to >>> include as much detail in the commit message as you will otherwise. >> >> Do youe mean move PlatformSysCtrlLib.h, OemAddressMapLib.h and LpcLib.h to edk2-non-osi? > > Yes. > > Any interfaces exposed _only_ by implementations in edk2-non-osi. > If there are any interfaces _also_ exposed by implementations in > edk2-platforms, then I would prefer for them to remain in > edk2-platforms. > > Ideally, this would also include (the multiple) SerdesLib.h, > IpmiCmdLib.h, and possibly others. Ok, I will do that in v2. Thanks > > Regards, > > Leif >