From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 1E034941005 for ; Fri, 2 Feb 2024 03:38:45 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=iFCDKYq5FBXaZSP+Zb3TGT98TFN4FEjVttj69/H4xXQ=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1706845124; v=1; b=r3IQ4tKYFHmzol3de7yQVo3NjqAECCveujsYsdezhJH1lsqjan9WYC2EhSnCZ50Jkghq9GGM rn086e5v3xtjLbsRKE/6tnw76nRK7l2tc8IqSmvvllS7DIHRDGPvZtfA+shkwn0M1SHlAkUsbyD CDvwg4dnc4ojOnzUj2UjEiKk= X-Received: by 127.0.0.2 with SMTP id aM3cYY7687511x4Zwj9ByAnU; Thu, 01 Feb 2024 19:38:44 -0800 X-Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by mx.groups.io with SMTP id smtpd.web11.15350.1706845122575062488 for ; Thu, 01 Feb 2024 19:38:44 -0800 X-Received: from loongson.cn (unknown [10.40.24.149]) by gateway (Coremail) with SMTP id _____8Axjuu+Y7xlvfwJAA--.28556S3; Fri, 02 Feb 2024 11:38:38 +0800 (CST) X-Received: from [10.40.24.149] (unknown [10.40.24.149]) by localhost.localdomain (Coremail) with SMTP id AQAAf8BxXs29Y7xlMtYsAA--.36968S3; Fri, 02 Feb 2024 11:38:37 +0800 (CST) Message-ID: <7b9b6902-04c3-45a9-8c09-f508708ea904@loongson.cn> Date: Fri, 2 Feb 2024 11:38:37 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v8 11/37] UefiCpuPkg: Add LoongArch64 CPU Timer instance To: devel@edk2.groups.io, ray.ni@intel.com Cc: "Dong, Eric" , "Kumar, Rahul R" , Gerd Hoffmann References: <20240126062715.3099433-1-lichao@loongson.cn> <20240126062900.3101491-1-lichao@loongson.cn> From: "Chao Li" In-Reply-To: X-CM-TRANSID: AQAAf8BxXs29Y7xlMtYsAA--.36968S3 X-CM-SenderInfo: xolfxt3r6o00pqjv00gofq/1tbiAQAPCGW7VmEOHgATss X-Coremail-Antispam: 1Uk129KBj9xXoWrtr4kXr4Utw4UKr4rGry5WrX_yoW3tFg_Gr 17ZF13Jrn5Jr92gw1jqrnIy395KwsxAw15t3s2ganrArW0yan0yF10qw10gr18J3yayr1U CrZakr15Ar1FgosvyTuYvTs0mTUanT9S1TB71UUUUUDqnTZGkaVYY2UrUUUUj1kv1TuYvT s0mT0YCTnIWjDUYxn0WfASr-VFAUDa7-sFnT9fnUUIcSsGvfJTRUUUbx8YFVCjjxCrM7AC 8VAFwI0_Jr0_Gr1l1xkIjI8I6I8E6xAIw20EY4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr v_JF1l8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AK xVW8JVW5JwA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwA2z4x0Y4vEx4A2jsIE14 v26r4UJVWxJr1l84ACjcxK6I8E87Iv6xkF7I0E14v26r4UJVWxJr1le2I262IYc4CY6c8I j28IcVAaY2xG8wAqjxCEc2xF0cIa020Ex4CE44I27wAv7VC0I7IYx2IY67AKxVWUAVWUtw Av7VC2z280aVAFwI0_Gr0_Cr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcVAKI48JMx8G jcxK6IxK0xIIj40E5I8CrwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8Jw CFI7km07C267AKxVWUXVWUAwC20s026c02F40E14v26r106r1rMI8I3I0E7480Y4vE14v2 6r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67 AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IY s7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r4j6F4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr 0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x07j80edUUUUU= Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lichao@loongson.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 5YpNzPDJk1c6sTIewrMMnXMXx7686176AA= Content-Type: multipart/alternative; boundary="------------lReWNIpbA3bhCbH05qfLLY4C" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=r3IQ4tKY; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --------------lReWNIpbA3bhCbH05qfLLY4C Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Ray, Thanks, Chao On 2024/2/2 11:24, Ni, Ray wrote: >> [LibraryClasses] >> BaseLib >> - PcdLib >> DebugLib >> + PcdLib > 1. This PcdLib location change is unnecessary. OK, I will keep them with original appearance next time. > > >> + SafeIntLib > 2. x86 Lib instance does not depend on SafeIntLib. > Adding it in common section may break some x86 platforms if SafeIntLib is= not added the platform DSC. > Can you move it under LoongArch section? OK. > > > >=20 > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115012): https://edk2.groups.io/g/devel/message/115012 Mute This Topic: https://groups.io/mt/103971650/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --------------lReWNIpbA3bhCbH05qfLLY4C Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Hi Ray,


=
Thanks,
Chao
On 2024/2/2 11:24, Ni, Ray wrote:

      

        
 [LibraryClasses]
   BaseLib
-  PcdLib
   DebugLib
+  PcdLib


      

      
1. This PcdLib location change is unnecessary.

    

    OK, I will keep them with original appearance next time.

    

      




      

        
+  SafeIntLib


      

      
2. x86 Lib instance does not depend on SafeIntLib.
Adding it in common section may break some x86 platforms if SafeIntLib is n=
ot added the platform DSC.
Can you move it under LoongArch section?

    

    OK.

    

      







    

  




_._,_._,_





Groups.io Links:



 =20
    You receive all messages sent to this group.
 =20
 =20




View/Reply Online (#115012) |


 =20

|

  Mute=
 This Topic


| New Topic







Your Subscriptio=
n |
Contact Group Owner |

Unsubscribe

 [rebecca@openfw.io]


_._,_._,_



--------------lReWNIpbA3bhCbH05qfLLY4C--