public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Alex James <theracermaster@gmail.com>
To: edk2-devel@lists.01.org
Cc: Alex James <theracermaster@gmail.com>
Subject: [PATCH] BaseTools/PcdValueCommon: Fix PcdDataTypeUint64 format string
Date: Thu, 28 Dec 2017 13:59:49 -0600	[thread overview]
Message-ID: <7baf6db5ebfdef045c69aed44d86aada99a7f4ff.1514491125.git.theracermaster@gmail.com> (raw)

Always specify unsigned long long for PcdDataTypeUint64. This is needed
to fix building with XCODE5.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Alex James <theracermaster@gmail.com>
---
 BaseTools/Source/C/Common/PcdValueCommon.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/BaseTools/Source/C/Common/PcdValueCommon.c b/BaseTools/Source/C/Common/PcdValueCommon.c
index 6ca0994744..f5d68e79e0 100644
--- a/BaseTools/Source/C/Common/PcdValueCommon.c
+++ b/BaseTools/Source/C/Common/PcdValueCommon.c
@@ -266,11 +266,7 @@ Returns:
     sprintf(PcdList[Index].Value, "0x%08x", (UINT32)(Value & 0xffffffff));
     break;
   case PcdDataTypeUint64:
-#ifdef __GNUC__
-    sprintf(PcdList[Index].Value, "0x%016lx", Value);
-#else
     sprintf(PcdList[Index].Value, "0x%016llx", Value);
-#endif
     break;
   case PcdDataTypePointer:
     fprintf (stderr, "PCD %s.%s.%s.%s is structure.  Use PcdSetPtr()\n", SkuName, DefaultValueName, TokenSpaceGuidName, TokenName);
-- 
2.15.1



             reply	other threads:[~2017-12-28 19:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-28 19:59 Alex James [this message]
2017-12-29  1:46 ` [PATCH] BaseTools/PcdValueCommon: Fix PcdDataTypeUint64 format string Gao, Liming
2017-12-29  2:58   ` Alex James
2018-01-02  9:25     ` Ard Biesheuvel
2018-01-02  9:26       ` Ard Biesheuvel
2018-01-02 12:18         ` Gao, Liming
2018-01-02 15:09           ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7baf6db5ebfdef045c69aed44d86aada99a7f4ff.1514491125.git.theracermaster@gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox