public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Dandan Bi <dandan.bi@intel.com>, edk2-devel@lists.01.org
Cc: Jian J Wang <jian.j.wang@intel.com>, Hao Wu <hao.a.wu@intel.com>,
	Ruiyu Ni <ruiyu.ni@intel.com>,
	Michael D Kinney <michael.d.kinney@intel.com>,
	Liming Gao <liming.gao@intel.com>,
	Sean Brogan <sean.brogan@microsoft.com>
Subject: Re: [patch 0/2] Report error status when fail to load/start boot option
Date: Fri, 15 Feb 2019 14:40:22 +0100	[thread overview]
Message-ID: <7bb1110b-d0b3-615d-9bab-cdfffb697ef1@redhat.com> (raw)
In-Reply-To: <20190215085141.64244-1-dandan.bi@intel.com>

On 02/15/19 09:51, Dandan Bi wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1398
> 
> According to PI1.7, this patch series is to add the support that
> report extended data describing an EFI_STATUS return value along
> with  EFI_SW_DXE_BS_EC_BOOT_OPTION_LOAD_ERROR and
> EFI_SW_DXE_BS_EC_BOOT_OPTION_FAILED status code when fail to load
> or start boot option image.
> 
> These two commit are also available at:
> https://github.com/dandanbi/edk2/commits/ExtendedStatusCodeV1
> 
> PI1.7 is at
> https://uefi.org/sites/default/files/resources/PI_Spec_1_7_final_Jan_2019.pdf
> 
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao Wu <hao.a.wu@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Dandan Bi (2):
>   MdePkg/StatusCodeDataTypeId.h: Add new definition per PI1.7 Spec
>   MdeModulePkg/BmBoot: Report status when fail to load/start boot option
> 
>  .../Library/UefiBootManagerLib/BmBoot.c       | 22 ++++++++++++++-----
>  MdePkg/Include/Guid/StatusCodeDataTypeId.h    | 22 ++++++++++++++++++-
>  2 files changed, 37 insertions(+), 7 deletions(-)
> 

Looks good to me.

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thank you,
Laszlo


  parent reply	other threads:[~2019-02-15 13:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-15  8:51 [patch 0/2] Report error status when fail to load/start boot option Dandan Bi
2019-02-15  8:51 ` [patch 1/2] MdePkg/StatusCodeDataTypeId.h: Add new definition per PI1.7 Spec Dandan Bi
2019-02-15  8:51 ` [patch 2/2] MdeModulePkg/BmBoot: Report status when fail to load/start boot option Dandan Bi
2019-02-20  1:19   ` Laszlo Ersek
2019-02-20  1:36     ` Laszlo Ersek
2019-02-20  2:21     ` Ni, Ray
2019-02-20  9:24       ` Laszlo Ersek
2019-02-20 17:19         ` Doran, Mark
2019-02-21  8:55           ` Laszlo Ersek
2019-02-20  2:35     ` Bi, Dandan
2019-02-15 13:40 ` Laszlo Ersek [this message]
2019-02-15 13:58   ` [patch 0/2] Report error " Ni, Ray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7bb1110b-d0b3-615d-9bab-cdfffb697ef1@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox