From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com;
 receiver=edk2-devel@lists.01.org 
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id A628D208AE370
 for <edk2-devel@lists.01.org>; Fri, 15 Feb 2019 05:40:26 -0800 (PST)
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com
 [10.5.11.15])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id CCE7FC1F9B;
 Fri, 15 Feb 2019 13:40:25 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-122-135.rdu2.redhat.com
 [10.10.122.135])
 by smtp.corp.redhat.com (Postfix) with ESMTP id D2C6A5D6A9;
 Fri, 15 Feb 2019 13:40:23 +0000 (UTC)
To: Dandan Bi <dandan.bi@intel.com>, edk2-devel@lists.01.org
Cc: Jian J Wang <jian.j.wang@intel.com>, Hao Wu <hao.a.wu@intel.com>,
 Ruiyu Ni <ruiyu.ni@intel.com>, Michael D Kinney
 <michael.d.kinney@intel.com>, Liming Gao <liming.gao@intel.com>,
 Sean Brogan <sean.brogan@microsoft.com>
References: <20190215085141.64244-1-dandan.bi@intel.com>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <7bb1110b-d0b3-615d-9bab-cdfffb697ef1@redhat.com>
Date: Fri, 15 Feb 2019 14:40:22 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20190215085141.64244-1-dandan.bi@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.26]); Fri, 15 Feb 2019 13:40:25 +0000 (UTC)
Subject: Re: [patch 0/2] Report error status when fail to load/start boot option
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Feb 2019 13:40:26 -0000
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 02/15/19 09:51, Dandan Bi wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1398
> 
> According to PI1.7, this patch series is to add the support that
> report extended data describing an EFI_STATUS return value along
> with  EFI_SW_DXE_BS_EC_BOOT_OPTION_LOAD_ERROR and
> EFI_SW_DXE_BS_EC_BOOT_OPTION_FAILED status code when fail to load
> or start boot option image.
> 
> These two commit are also available at:
> https://github.com/dandanbi/edk2/commits/ExtendedStatusCodeV1
> 
> PI1.7 is at
> https://uefi.org/sites/default/files/resources/PI_Spec_1_7_final_Jan_2019.pdf
> 
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao Wu <hao.a.wu@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Dandan Bi (2):
>   MdePkg/StatusCodeDataTypeId.h: Add new definition per PI1.7 Spec
>   MdeModulePkg/BmBoot: Report status when fail to load/start boot option
> 
>  .../Library/UefiBootManagerLib/BmBoot.c       | 22 ++++++++++++++-----
>  MdePkg/Include/Guid/StatusCodeDataTypeId.h    | 22 ++++++++++++++++++-
>  2 files changed, 37 insertions(+), 7 deletions(-)
> 

Looks good to me.

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thank you,
Laszlo