From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=217.140.101.70; helo=foss.arm.com; envelope-from=supreeth.venkatesh@arm.com; receiver=edk2-devel@lists.01.org Received: from foss.arm.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by ml01.01.org (Postfix) with ESMTP id 61ACC203B99A2 for ; Wed, 7 Nov 2018 12:55:14 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 09BD580D; Wed, 7 Nov 2018 12:55:14 -0800 (PST) Received: from supven01-VirtualBox (u203142.arm.com [10.118.30.88]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id AFE9B3F5C0; Wed, 7 Nov 2018 12:55:13 -0800 (PST) Message-ID: <7bc775fcb68470766c91ad5645faeb42f525a56c.camel@arm.com> From: Supreeth Venkatesh To: Leif Lindholm , Sakar Arora Cc: edk2-devel@lists.01.org, prasanth.pulla@arm.com, Eric Jin Date: Wed, 07 Nov 2018 14:55:13 -0600 In-Reply-To: <20181106174606.kp7q5hmms7mnutut@bivouac.eciton.net> References: <1541494066-16288-1-git-send-email-sakar.arora@arm.com> <1541494066-16288-7-git-send-email-sakar.arora@arm.com> <20181106174606.kp7q5hmms7mnutut@bivouac.eciton.net> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Subject: Re: [edk2-test][RFC PATCH 07/12] uefi-sct/SctPkg: sbbr: Add test cases for SBBR v1.0 boot services X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Nov 2018 20:55:14 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Tue, 2018-11-06 at 17:46 +0000, Leif Lindholm wrote: > On Tue, Nov 06, 2018 at 02:17:41PM +0530, Sakar Arora wrote: > > From: John Powell > > > > Tests SBBR requirements 3.4.1 and 3.4.4. It would be better if we add comments on how SBBR requirements 3.4.1 and 3.4.4 relate to the UEFI specification. Since this is being requested to be added as part of UEFI-SCT, it would need to be related to UEFI specification. For all the SBBR patches, please correlate SBBR specification text to UEFI specification, so that it can be justified as UEFI-SCT test case. > > > > Change-Id: I0dd625851db65d04d2a7572a2d6838951c8f7c67 > > Signed-off-by: John Powell > > --- > > uefi-sct/SctPkg/CommonGenFramework.sh | 3 + > > uefi-sct/SctPkg/Config/Data/Category.ini | 11 +- > > .../SbbrBootServices/BlackBoxTest/Guid.c | 65 +++ > > .../SbbrBootServices/BlackBoxTest/Guid.h | 76 +++ > > .../BlackBoxTest/SbbrBootServicesBBTest.inf | 85 ++++ > > .../BlackBoxTest/SbbrBootServicesBBTestFunction.c | 549 > > +++++++++++++++++++++ > > .../BlackBoxTest/SbbrBootServicesBBTestFunction.h | 85 ++++ > > .../BlackBoxTest/SbbrBootServicesBBTestMain.c | 149 ++++++ > > .../BlackBoxTest/SbbrBootServicesBBTestMain.h | 99 ++++ > > uefi-sct/SctPkg/UEFI/SBBR_SCT.dsc | 7 + > > 10 files changed, 1127 insertions(+), 2 deletions(-) > > create mode 100644 uefi- > > sct/SctPkg/TestCase/UEFI/EFI/BootServices/SbbrBootServices/BlackBox > > Test/Guid.c > > create mode 100644 uefi- > > sct/SctPkg/TestCase/UEFI/EFI/BootServices/SbbrBootServices/BlackBox > > Test/Guid.h > > create mode 100644 uefi- > > sct/SctPkg/TestCase/UEFI/EFI/BootServices/SbbrBootServices/BlackBox > > Test/SbbrBootServicesBBTest.inf > > create mode 100644 uefi- > > sct/SctPkg/TestCase/UEFI/EFI/BootServices/SbbrBootServices/BlackBox > > Test/SbbrBootServicesBBTestFunction.c > > create mode 100644 uefi- > > sct/SctPkg/TestCase/UEFI/EFI/BootServices/SbbrBootServices/BlackBox > > Test/SbbrBootServicesBBTestFunction.h > > create mode 100644 uefi- > > sct/SctPkg/TestCase/UEFI/EFI/BootServices/SbbrBootServices/BlackBox > > Test/SbbrBootServicesBBTestMain.c > > create mode 100644 uefi- > > sct/SctPkg/TestCase/UEFI/EFI/BootServices/SbbrBootServices/BlackBox > > Test/SbbrBootServicesBBTestMain.h > > > > diff --git a/uefi-sct/SctPkg/CommonGenFramework.sh b/uefi- > > sct/SctPkg/CommonGenFramework.sh > > index aecd21b..ab35c5a 100755 > > --- a/uefi-sct/SctPkg/CommonGenFramework.sh > > +++ b/uefi-sct/SctPkg/CommonGenFramework.sh > > @@ -364,6 +364,9 @@ then > > # Tests SBBR sections 3.3.1, 3.3.2, 3.3.3, and 3.3.4 > > cp > > $ProcessorType/SysEnvConfigBBTest.efi $Framework/ > > Test/ > NUL > > > > + # UEFI Boot Services - SBBR v1.0 3.4 > > + cp > > $ProcessorType/SbbrBootServicesBBTest.efi $Framework/ > > Test/ > NUL > > + > > # Runtime Services Tests - SBBR v1.0 Appendix B > > cp > > $ProcessorType/VariableServicesBBTest.efi $Framework/ > > Test/ > NUL > > cp > > $ProcessorType/TimeServicesBBTest.efi $Framework/ > > Test/ > NUL > > diff --git a/uefi-sct/SctPkg/Config/Data/Category.ini b/uefi- > > sct/SctPkg/Config/Data/Category.ini > > index 9576971..17ca639 100644 > > --- a/uefi-sct/SctPkg/Config/Data/Category.ini > > +++ b/uefi-sct/SctPkg/Config/Data/Category.ini > > @@ -145,8 +145,15 @@ Description = > > > > [Category Data] > > Revision = 0x00010000 > > -CategoryGuid = AFF115FB-387B-4C18-8C41-6AFC7F03BB90 > > -InterfaceGuid = AFF115FB-387B-4C18-8C41-6AFC7F03BB90 > > +CategoryGuid = 8dafd7a7-44d0-4cf4-9d28-9f87080fc091 > > +InterfaceGuid = E9EF7553-F833-4E56-96E8-38AE679523CC > > +Name = BootServicesTest\SbbrBootServices > > +Description = Tests SBBR boot services requirements. > > + > > +[Category Data] > > +Revision = 0x00010000 > > +CategoryGuid = AFF115FB-387B-4c18-8C41-6AFC7F03BB90 > > +InterfaceGuid = AFF115FB-387B-4c18-8C41-6AFC7F03BB90 > > Name = RuntimeServicesTest > > Description = > > Diff would be more clear if added test was added after existing test. > > / > Leif