From: "Laszlo Ersek" <lersek@redhat.com>
To: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"samer@elhajmahmoud.com" <samer@elhajmahmoud.com>
Cc: Dandan Bi <dandan.bi@intel.com>,
Liming Gao <liming.gao@intel.com>, Hao A Wu <hao.a.wu@intel.com>,
Leif Lindholm <leif@nuviainc.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms
Date: Wed, 25 Mar 2020 00:03:27 +0100 [thread overview]
Message-ID: <7bf17e72-c470-04f5-8c9f-a0d5f367bddc@redhat.com> (raw)
In-Reply-To: <VE1PR08MB483019D9048CB7D7E7BB3C5F90F00@VE1PR08MB4830.eurprd08.prod.outlook.com>
On 03/23/20 13:53, Samer El-Haj-Mahmoud wrote:
> Thanks Laszlo
>
> I agree. But shouldn't we remove the PCD settings from all Arm64 platforms that have this override value of 0x20?
>
> Namely:
>
> edk2/ArmVirtPkg/ArmVirtQemu.dsc
> edk2-platforms/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> edk2-platforms/Platform/ARM/JunoPkg/ArmJuno.dsc
> edk2-platforms/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc
> edk2-platforms/Platform/Comcast/RDKQemu/RDKQemu.dsc
> edk2-platforms/Platform/Hisilicon/D06/D06.dsc
> edk2-platforms/Platform/LeMaker/CelloBoard/CelloBoard.dsc
> edk2-platforms/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
> edk2-platforms/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> edk2-platforms/Silicon/Socionext/SynQuacer/Acpi.dsc.inc
If you can order the edk2-platforms changes safely after the edk2 DEC
file change, then yes.
Otherwise, I can't say.
AFAICT, edk2-platforms does not consume edk2 via a git submodule, so the
ordering looks risky. But I generally don't follow edk2-platforms (which
is also why I didn't grep its DSC files for the PCD in question), so I
really don't know how such ordering questions have been dealt with in
the past.
Thanks
Laszlo
next prev parent reply other threads:[~2020-03-24 23:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-22 16:08 [PATCH v1 1/1] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms samer
2020-03-23 12:31 ` [edk2-devel] " Laszlo Ersek
2020-03-23 12:53 ` Samer El-Haj-Mahmoud
2020-03-24 23:03 ` Laszlo Ersek [this message]
2020-03-25 2:03 ` Samer El-Haj-Mahmoud
2020-03-25 9:15 ` Ard Biesheuvel
2020-03-26 21:12 ` Samer El-Haj-Mahmoud
2020-03-27 1:17 ` Dandan Bi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7bf17e72-c470-04f5-8c9f-a0d5f367bddc@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox