From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [216.205.24.74]) by mx.groups.io with SMTP id smtpd.web11.542.1585091014840186792 for ; Tue, 24 Mar 2020 16:03:35 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=FXvf2bsY; spf=pass (domain: redhat.com, ip: 216.205.24.74, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585091014; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7JTicnHF274pKkLILIWVPsfypoKQZgJMtTa2U5M5568=; b=FXvf2bsYKZgprrWs8jfzTeznT3efqVUoeIf6PLYS1VolhxOBODwPnBHd/bAp4OgqiWbhxY 3f58lqdwk+LL2bsGQxK+I434yMpomuOReXJFpdLbUvjzIrSFbDtKT7uIj1eXjxrqfyr1r2 47K96i/6kOIE7p4E9wc2MZSrIP5SvpA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-493-rUNP0RZIOM6SvePfgyugKw-1; Tue, 24 Mar 2020 19:03:32 -0400 X-MC-Unique: rUNP0RZIOM6SvePfgyugKw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6FD3513F6; Tue, 24 Mar 2020 23:03:30 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-115-139.ams2.redhat.com [10.36.115.139]) by smtp.corp.redhat.com (Postfix) with ESMTP id 308FABBBCE; Tue, 24 Mar 2020 23:03:27 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms To: Samer El-Haj-Mahmoud , "devel@edk2.groups.io" , "samer@elhajmahmoud.com" Cc: Dandan Bi , Liming Gao , Hao A Wu , Leif Lindholm , Ard Biesheuvel References: <20200322160816.18426-1-samer@elhajmahmoud.com> <7f587b1f-c02d-eafc-581f-d3de10a6ee7f@redhat.com> From: "Laszlo Ersek" Message-ID: <7bf17e72-c470-04f5-8c9f-a0d5f367bddc@redhat.com> Date: Wed, 25 Mar 2020 00:03:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 03/23/20 13:53, Samer El-Haj-Mahmoud wrote: > Thanks Laszlo > > I agree. But shouldn't we remove the PCD settings from all Arm64 platforms that have this override value of 0x20? > > Namely: > > edk2/ArmVirtPkg/ArmVirtQemu.dsc > edk2-platforms/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > edk2-platforms/Platform/ARM/JunoPkg/ArmJuno.dsc > edk2-platforms/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc > edk2-platforms/Platform/Comcast/RDKQemu/RDKQemu.dsc > edk2-platforms/Platform/Hisilicon/D06/D06.dsc > edk2-platforms/Platform/LeMaker/CelloBoard/CelloBoard.dsc > edk2-platforms/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc > edk2-platforms/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc > edk2-platforms/Silicon/Socionext/SynQuacer/Acpi.dsc.inc If you can order the edk2-platforms changes safely after the edk2 DEC file change, then yes. Otherwise, I can't say. AFAICT, edk2-platforms does not consume edk2 via a git submodule, so the ordering looks risky. But I generally don't follow edk2-platforms (which is also why I didn't grep its DSC files for the PCD in question), so I really don't know how such ordering questions have been dealt with in the past. Thanks Laszlo