Re: [PATCH v1 0/7] Code refinements in UdfDxe

["Zeng, Star" <star.zeng@intel.com>]

On 2018/10/15 12:55, Hao Wu wrote:
> This series will refine the codes in MdeModulePkg/Universal/Disk/UdfDxe
> for:
> 
> A. Refine asserts used for memory allocation failure and error cases that
>     are possible to happen. Will use error handling logic for them;
> 
> B. Address some dead codes within this module.
> 
> Cc: Paulo Alcantara <paulo@paulo.ac>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> 
> Hao Wu (7):
>    MdeModulePkg/UdfDxe: Use error handling for memory allocation failure
>    MdeModulePkg/UdfDxe: ASSERT for false positives of NULL ptr deref
>    MdeModulePkg/UdfDxe: Use error handling when fail to return LSN
>    MdeModulePkg/UdfDxe: Use debug msg instead of ASSERT in UdfOpen()
>    MdeModulePkg/UdfDxe: Handle dead codes in File.c
>    MdeModulePkg/UdfDxe: Remove dead codes in FileName.c
>    MdeModulePkg/UdfDxe: Handle dead codes in FileSystemOperations.c
> 
>   MdeModulePkg/Universal/Disk/UdfDxe/File.c                 |  19 ++-
>   MdeModulePkg/Universal/Disk/UdfDxe/FileName.c             |  15 --
>   MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c | 162 +++++++++++++++-----
>   3 files changed, 142 insertions(+), 54 deletions(-)

Hao,

Thanks for the patches.

Reviewed-by: Star Zeng <star.zeng@intel.com> to patch 1 ~ 6.
Some feedback will be sent for patch 7.

Star

>