From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7ECF821179248 for ; Mon, 15 Oct 2018 23:21:18 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Oct 2018 23:21:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,387,1534834800"; d="scan'208";a="100588273" Received: from shzintpr03.sh.intel.com (HELO [10.7.209.21]) ([10.239.4.100]) by orsmga002.jf.intel.com with ESMTP; 15 Oct 2018 23:21:16 -0700 To: Hao Wu , edk2-devel@lists.01.org Cc: Ruiyu Ni , star.zeng@intel.com References: <20181015045522.18732-1-hao.a.wu@intel.com> From: "Zeng, Star" Message-ID: <7c02bf0b-918b-027f-4c67-88a48c4d86fc@intel.com> Date: Tue, 16 Oct 2018 14:20:46 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181015045522.18732-1-hao.a.wu@intel.com> Subject: Re: [PATCH v1 0/7] Code refinements in UdfDxe X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2018 06:21:18 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 2018/10/15 12:55, Hao Wu wrote: > This series will refine the codes in MdeModulePkg/Universal/Disk/UdfDxe > for: > > A. Refine asserts used for memory allocation failure and error cases that > are possible to happen. Will use error handling logic for them; > > B. Address some dead codes within this module. > > Cc: Paulo Alcantara > Cc: Ruiyu Ni > Cc: Star Zeng > > Hao Wu (7): > MdeModulePkg/UdfDxe: Use error handling for memory allocation failure > MdeModulePkg/UdfDxe: ASSERT for false positives of NULL ptr deref > MdeModulePkg/UdfDxe: Use error handling when fail to return LSN > MdeModulePkg/UdfDxe: Use debug msg instead of ASSERT in UdfOpen() > MdeModulePkg/UdfDxe: Handle dead codes in File.c > MdeModulePkg/UdfDxe: Remove dead codes in FileName.c > MdeModulePkg/UdfDxe: Handle dead codes in FileSystemOperations.c > > MdeModulePkg/Universal/Disk/UdfDxe/File.c | 19 ++- > MdeModulePkg/Universal/Disk/UdfDxe/FileName.c | 15 -- > MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c | 162 +++++++++++++++----- > 3 files changed, 142 insertions(+), 54 deletions(-) Hao, Thanks for the patches. Reviewed-by: Star Zeng to patch 1 ~ 6. Some feedback will be sent for patch 7. Star >