From: "Daniel Schaefer" <daniel.schaefer@hpe.com>
To: Michael D Kinney <michael.d.kinney@intel.com>, <devel@edk2.groups.io>
Cc: Jian J Wang <jian.j.wang@intel.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Abner Chang <abner.chang@hpe.com>
Subject: Re: [Patch 4/6] SignedCapsulePkg/SignedCapsulePkg.dsc: Add RngLib mapping
Date: Wed, 3 Nov 2021 13:37:06 +0800 [thread overview]
Message-ID: <7c04ff16-e43d-e0b9-08a7-c5224b7ec8e4@hpe.com> (raw)
In-Reply-To: <20211103030542.1529-5-michael.d.kinney@intel.com>
Reviewed-by: Daniel Schaefer <daniel.schaefer@hpe.com>
On 11/3/21 11:05, Michael D Kinney wrote:
> Fix build breaks for all architectures by adding RngLib mapping.
>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Abner Chang <abner.chang@hpe.com>
> Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
> SignedCapsulePkg/SignedCapsulePkg.dsc | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/SignedCapsulePkg/SignedCapsulePkg.dsc b/SignedCapsulePkg/SignedCapsulePkg.dsc
> index 2152d3d15668..8a27207a6f20 100644
> --- a/SignedCapsulePkg/SignedCapsulePkg.dsc
> +++ b/SignedCapsulePkg/SignedCapsulePkg.dsc
> @@ -93,6 +93,7 @@ [LibraryClasses]
> EdkiiSystemCapsuleLib|SignedCapsulePkg/Library/EdkiiSystemCapsuleLib/EdkiiSystemCapsuleLib.inf
> IniParsingLib|SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.inf
> PlatformFlashAccessLib|SignedCapsulePkg/Library/PlatformFlashAccessLibNull/PlatformFlashAccessLibNull.inf
> + RngLib|MdePkg/Library/BaseRngLib/BaseRngLib.inf
>
> [LibraryClasses.ARM]
> ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf
> @@ -108,6 +109,12 @@ [LibraryClasses.AARCH64, LibraryClasses.ARM]
> # Add support for GCC stack protector
> NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
>
> +[LibraryClasses.ARM]
> + RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf
> +
> +[LibraryClasses.RISCV64]
> + RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf
> +
> [LibraryClasses.common.PEI_CORE]
> HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf
> MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf
>
next prev parent reply other threads:[~2021-11-03 5:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 3:05 [Patch 0/6] Fix package build issues Michael D Kinney
2021-11-03 3:05 ` [Patch 1/6] DynamicTablesPkg: Add missing BaseStackCheckLib instance Michael D Kinney
2021-11-03 12:12 ` Sami Mujawar
2021-11-03 3:05 ` [Patch 2/6] NetworkPkg/NetworkPkg.dsc: Add RngLib mapping for ARM and RISCV64 Michael D Kinney
2021-11-03 5:36 ` Daniel Schaefer
2021-11-03 21:25 ` Maciej Rabeda
2021-11-03 21:36 ` Michael D Kinney
2021-11-03 3:05 ` [Patch 3/6] SecurityPkg/SecurityPkg.dsc: Add missing RngLib " Michael D Kinney
2021-11-03 5:28 ` Yao, Jiewen
2021-11-03 5:37 ` Daniel Schaefer
2021-11-03 3:05 ` [Patch 4/6] SignedCapsulePkg/SignedCapsulePkg.dsc: Add RngLib mapping Michael D Kinney
2021-11-03 5:37 ` Daniel Schaefer [this message]
2021-11-03 3:05 ` [Patch 5/6] UefiCpuPkg/MtrrLib/UnitTest: Fix 32-bit GCC build issues Michael D Kinney
2021-11-03 14:00 ` [edk2-devel] " Philippe Mathieu-Daudé
2021-11-03 3:05 ` [Patch 6/6] MdeModulePkg/Variable/RuntimeDxeUnitTest: Fix 32-bit GCC builds Michael D Kinney
2021-11-03 14:01 ` [edk2-devel] " Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c04ff16-e43d-e0b9-08a7-c5224b7ec8e4@hpe.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox