From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Jeff Brasen <jbrasen@nvidia.com>, devel@edk2.groups.io
Cc: ardb+tianocore@kernel.org, quic_llindhol@quicinc.com,
"nd@arm.com" <nd@arm.com>
Subject: Re: [edk2-devel] [PATCH] ArmPkg/ProcessorSubClassDxe: Limit CoreCount to 0xFF
Date: Tue, 6 Feb 2024 11:39:29 +0000 [thread overview]
Message-ID: <7c1fd7a6-8e1f-47f2-b786-7e918c96ad64@arm.com> (raw)
In-Reply-To: <944835ff46a1f5c0403cc08a399da1b84d640323.1706646039.git.jbrasen@nvidia.com>
Hi Jeff,
Thank you for this patch.
The changes in this patch look good to me. However, a similar change
also applies to the ThreadCount & ThreadCount2 fields.
Although, this patch only talks about CoreCount, would it be possible to
update this or submit a new patch to fix the ThreadCount also, please?
In either case,
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
On 30/01/2024 08:22 pm, Jeff Brasen wrote:
> The CoreCount and EnabledCore counts should be set to 0xFF if value is
> greater than 255 per the SMBIOS specification.
>
> Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
> ---
> .../ProcessorSubClassDxe/ProcessorSubClass.c | 37 +++++++++++++------
> 1 file changed, 25 insertions(+), 12 deletions(-)
>
> diff --git a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c
> index 9050588500..921a1d0aaa 100644
> --- a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c
> +++ b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c
> @@ -702,19 +702,32 @@ AddSmbiosProcessorTypeTable (
>
> LegacyVoltage = (UINT8 *)&Type4Record->Voltage;
>
> - *LegacyVoltage = MiscProcessorData.Voltage;
> - Type4Record->CurrentSpeed = MiscProcessorData.CurrentSpeed;
> - Type4Record->MaxSpeed = MiscProcessorData.MaxSpeed;
> - Type4Record->Status = ProcessorStatus.Data;
> - Type4Record->L1CacheHandle = L1CacheHandle;
> - Type4Record->L2CacheHandle = L2CacheHandle;
> - Type4Record->L3CacheHandle = L3CacheHandle;
> - Type4Record->CoreCount = MiscProcessorData.CoreCount;
> - Type4Record->CoreCount2 = MiscProcessorData.CoreCount;
> - Type4Record->EnabledCoreCount = MiscProcessorData.CoresEnabled;
> + *LegacyVoltage = MiscProcessorData.Voltage;
> + Type4Record->CurrentSpeed = MiscProcessorData.CurrentSpeed;
> + Type4Record->MaxSpeed = MiscProcessorData.MaxSpeed;
> + Type4Record->Status = ProcessorStatus.Data;
> + Type4Record->L1CacheHandle = L1CacheHandle;
> + Type4Record->L2CacheHandle = L2CacheHandle;
> + Type4Record->L3CacheHandle = L3CacheHandle;
> +
> + if (MiscProcessorData.CoreCount > 255) {
> + Type4Record->CoreCount = 0xFF;
> + } else {
> + Type4Record->CoreCount = MiscProcessorData.CoreCount;
> + }
> +
> + Type4Record->CoreCount2 = MiscProcessorData.CoreCount;
> +
> + if (MiscProcessorData.CoresEnabled > 255) {
> + Type4Record->EnabledCoreCount = 0xFF;
> + } else {
> + Type4Record->EnabledCoreCount = MiscProcessorData.CoresEnabled;
> + }
> +
> Type4Record->EnabledCoreCount2 = MiscProcessorData.CoresEnabled;
> - Type4Record->ThreadCount = MiscProcessorData.ThreadCount;
> - Type4Record->ThreadCount2 = MiscProcessorData.ThreadCount;
> +
> + Type4Record->ThreadCount = MiscProcessorData.ThreadCount;
> + Type4Record->ThreadCount2 = MiscProcessorData.ThreadCount;
[SAMI] According to SMBIOS specification 3.7, section 7.8.5 states that
the ThreadCount also follows a similar approact to Core Count and Core
Count 2 fields, see Table 28.
[/SAMI]
>
> Type4Record->CurrentSpeed = GetCpuFrequency (ProcessorIndex);
> Type4Record->ExternalClock =
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115156): https://edk2.groups.io/g/devel/message/115156
Mute This Topic: https://groups.io/mt/104078446/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2024-02-06 11:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 20:22 [edk2-devel] [PATCH] ArmPkg/ProcessorSubClassDxe: Limit CoreCount to 0xFF Jeff Brasen via groups.io
2024-02-06 11:39 ` Sami Mujawar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c1fd7a6-8e1f-47f2-b786-7e918c96ad64@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox