From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id E59169414A4 for ; Tue, 6 Feb 2024 11:39:48 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=3nL58q9p7luCxGJqNASO4FxIviHTnEHTz1yMeUIkySU=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Authentication-Results-Original:Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:NoDisclaimer:Original-Authentication-Results:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1707219587; v=1; b=mDv7K37gLC2h3JEX8zhoeSLBRf3DdepLLZ5fvo1TeUc3+f+TsXFHyai7pDsDinzYgrfsOpwK 2r06PcepXoBN6ia0y2bjN5uKDvLRKWXI9euNVD9Y0wJIBTYKTGSPz0Ch8+w7CqneffBJ96YCzkO kaLWurvb0Tqf2abU8sFGrV2k= X-Received: by 127.0.0.2 with SMTP id uCavYY7687511xtMv29v1PHD; Tue, 06 Feb 2024 03:39:47 -0800 X-Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.55]) by mx.groups.io with SMTP id smtpd.web10.19472.1707219585889322078 for ; Tue, 06 Feb 2024 03:39:46 -0800 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=L0WyeNxqbLW1i3IBWUv6og+pqvlrtNgltGNHVJc4i6nT7lwHDbEiRJvjJiwssoKrQGZzD1sxzmApvOOYWs2Hut9tmQcaUXOMXE6ikHjRzDokeXHHnGeixWtqO3cEBlVRdgQRMynOtrDi9jm0IOhHs2rErlr2qrAZ68EgfC3aIdTS2Zqoym2BUQ4YRpWb7o1JDmRuuj3ya7UrP4dQVfb5KmAW5ZHXYtD9dhp0+dsID8yb5JdrBaZ4V23tXeRWtNlam02GfUdS073r4tf3eK0nlGfi2t3GR1rSBYSjrr8wNW7KCfufvkGvutbtfFbsKskqPkxig75j7eEKywrih2HwOA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WK+yEvdbhYUf/6MB3l56sVeQfbeMhkXXg6XwdwZpTMY=; b=V1iJcj1ZrhahemIbx4cC2Xpg8JIIdBMM5jLvv6We+yw5kIymOde/GpXa0UprVCMhfDR9B/+F9znLOkCBdrK0HkpgrLrndMub5fo/NsRsUAYUj3P+3WO5WVV3E1LQyToyInsQ+hlzpD7xbyhy2gfVUDLUg7SGAckO1sRpdzYmTGuJM2Y4hP30lYCXTz9pa79F2XlJD3fWjctEXGwEsSB565RUIY+2M749vMSN+Mo2g2ddLqP8PSi9DaxthImhBuihJrH1UtDtXh+boxsTLjpXTbD6EPxfSOoICDSpjMcOsK6exbRNIHdnZAFqJVFcR1/lTCdG8O15y2EdwEz+bOhVQQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) X-Received: from AM7PR03CA0021.eurprd03.prod.outlook.com (2603:10a6:20b:130::31) by PA4PR08MB7387.eurprd08.prod.outlook.com (2603:10a6:102:2a2::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.36; Tue, 6 Feb 2024 11:39:40 +0000 X-Received: from AM3PEPF00009B9C.eurprd04.prod.outlook.com (2603:10a6:20b:130:cafe::51) by AM7PR03CA0021.outlook.office365.com (2603:10a6:20b:130::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.36 via Frontend Transport; Tue, 6 Feb 2024 11:39:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM3PEPF00009B9C.mail.protection.outlook.com (10.167.16.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.19 via Frontend Transport; Tue, 6 Feb 2024 11:39:40 +0000 X-Received: ("Tessian outbound a064b9944658:v228"); Tue, 06 Feb 2024 11:39:40 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: ddf4ca23439a8dd3 X-CR-MTA-TID: 64aa7808 X-Received: from ee7df3a82e3f.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 79554CD0-E319-4CCF-BF2A-E3839023F894.1; Tue, 06 Feb 2024 11:39:33 +0000 X-Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ee7df3a82e3f.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 06 Feb 2024 11:39:33 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NvGzURvgli09jQlLYvhcXKYrOHhDpZ1zJ6IWyxpo//Tl9i4lns0eksWL9INOT17n4DWBYvrjK6Gs9BgkqCHKWMdjduZsYnwKAE9SJgVzK9zIccK2lXPjfDiVs+QR5icCM1f+PFgb4AUDjMutKgWitS3mvJYoLbqLnAOK7ShmKNrnJNVCwfSSr3AkDvRgmruqMNFVetyOuyBrE0hDza6q7SWxHp2mhXQU21f8p1cecxsviQqQ11q88s2/VSRnaljsvuiq9MW/aoMXbwVhjBEWhE4v2hfHY5CaxXo9IX344biry0x2bSP+YuQKWAv3oOVISbFmAITKAhTB1jw30utEVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WK+yEvdbhYUf/6MB3l56sVeQfbeMhkXXg6XwdwZpTMY=; b=A5D/cz0qwdBnKKN4MyG2nBvfD3Q99IFOj1QfcG5nSK04QT3c1qQMrUMwyUQvVsFAJT07VWEnQnXZxAD7TDcpSqaLzhJIDKmYxl3oFaJOmTT6sOLi429TbrjXXGd2H7OI2Tpii1Mg1POV1EkYmV3I8fWqqj8XFCq5nCbJ9euIkTnmEMsvfgQMlGxWUHSXE8UemzHAHTzNEQmwlvfga8FBR3JExN8CpH6hM+vzJ+fMvj/kWiXD/aQJKrkjDtPjc9RIoclRBBUFN/dpCDhG5NQe/5Kf8aQO3D4D9fEByDizRoKRIpjc6QO+7h9NPLlNgrhqOl3lKBenkyZtAFZk+XYx/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by GV2PR08MB9158.eurprd08.prod.outlook.com (2603:10a6:150:d2::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.36; Tue, 6 Feb 2024 11:39:30 +0000 X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::8912:5ce2:11a4:9d6e]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::8912:5ce2:11a4:9d6e%7]) with mapi id 15.20.7249.035; Tue, 6 Feb 2024 11:39:30 +0000 Message-ID: <7c1fd7a6-8e1f-47f2-b786-7e918c96ad64@arm.com> Date: Tue, 6 Feb 2024 11:39:29 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH] ArmPkg/ProcessorSubClassDxe: Limit CoreCount to 0xFF To: Jeff Brasen , devel@edk2.groups.io Cc: ardb+tianocore@kernel.org, quic_llindhol@quicinc.com, "nd@arm.com" References: <944835ff46a1f5c0403cc08a399da1b84d640323.1706646039.git.jbrasen@nvidia.com> From: "Sami Mujawar" In-Reply-To: <944835ff46a1f5c0403cc08a399da1b84d640323.1706646039.git.jbrasen@nvidia.com> X-ClientProxiedBy: LO4P265CA0171.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:312::17) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|GV2PR08MB9158:EE_|AM3PEPF00009B9C:EE_|PA4PR08MB7387:EE_ X-MS-Office365-Filtering-Correlation-Id: f62f7854-f0cc-43c3-ff68-08dc27084e17 X-LD-Processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: u3l9fnWOMsMaIlnnaYtZDTRbHN0Y0zLdXx5WOJdvyDAfiRHy7HoKAxWmdVdRe9YXTUI8N0WCxC8u7r61Krjxd8XpB++6uNjb6F66Y2opauBUYCsO9XGrpI6v9rUy9jRhceUYQp35QtBbrNlrsmHkJ3114LmMp/FQPSN30N6JdYP2iAIQVnPwPoWgG3krgIlugNXMskzAjT4K4/wcacDEAi4l7BMfo7S8g8WlmcqOZGnLr/Vg6CrEkQq+2WFAH3aRfTK2eoov6slQGqWIGDKX33Q+NZQzWXFvGNavuvdsTUoJiU+XhGq1wl3U2XxaiMNnkkpJ32MKOn4ED/UQRX+ehk5G4vCjhMT6l2PG1a0AuXvFhlmDJpGOxp/zpi8sYT7gBM7F6m6UvwPdwS9AWz+aPallmKATujF9hd4mcSe5bXTOAWyyTf6ZVwcJ2R46ysKcT8ymxj7terPZDL59705iAAQPuGe/fIwddB4lA8ip1aI+VZLuZKlYsdnV09rpAQKTy8JZcVlgW301VSqR2avYKefVr1wtIW2+TUMOH4SAX3KhQWhdUFG5H2oKVg2TFePxcWZWrcK5aKMlxtn4eBSqm4i/OYlZbIkyrEIS3fNfeawBOXO0fsfFBuPT0fl67HtaJ21oO2/5aVnqKkqXaQzLKw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(39860400002)(376002)(136003)(396003)(366004)(230273577357003)(230922051799003)(1800799012)(64100799003)(186009)(451199024)(2616005)(41300700001)(26005)(86362001)(8676002)(6486002)(5660300002)(478600001)(2906002)(66556008)(44832011)(66476007)(66946007)(8936002)(4326008)(36756003)(6512007)(53546011)(6506007)(38100700002)(31686004)(83380400001)(31696002)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB9158 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM3PEPF00009B9C.eurprd04.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 2e44988f-75d7-4e8c-aa41-08dc27084807 X-Microsoft-Antispam-Message-Info: DKal7IVzNNvVh2SOZnMWluvfhdnQJW/zu61PlYIGfeINvGvd1obnf2O98qq5C+OyI7Urt693s+5T1Iyx6QeZecCGWxFbVEsG1CwWkRs/d7FZwym74uW+7oRa7Wv2qLtCEbxCVfuaPeaMh+oiYNOGBL9x8Xves8YWk0c4FHFI8ruNxLS4/Yfivqpo+0oClrCtTeA7MscpvxEQx3OJeoAaJJ8mEQ9f4p82MTWPRM8Pi9WJFoKlyJ0bzQ1BRoUkRfW2TG3IZinjadi6tyLwny1hR8MusGC4P1cqetCSYZHDXfDR6kaRAuSt5VUT6ovX9EWqXynEyVg6frQW5GF9clqNUeNjgeDp55Qa9QlwYYn3VvI7XvLvrhEO1cn8qhXNK1ik7njcKhcVmWQRsnzFIEyjQHE+FiWa9lmwdBe9MsuJJYSk9QV+zlUkvE8Igi384G0qGph+T7mRU99ecviATUdlGsWSfPVerwjdjZ6ukaOKzLRw8iJyEKUTGsVP85gtDH9f+c8doDwbW7qhEgS0f6p5z2Dyd/Xu2Ne+ezWPLrH16lt2pE9pK96+rxoEbj2S4y45tN9diW3fcClZ7uNjWLc1VUYMFm2+MaeZIWpMymgE3JC8oTKe6PwzQLSkqSMQAbgOEipA7uYfJnO6Ar7lxjQ7ci3lg+YAyVYhM+dHuI5hLiUFrqwyLnD9Evomcnh2nqpiHjPFchOlb07NnHe3xxdWfnF9QWAleq+eP4ylvXQ6ueJELy1Hkr1iHlfbJHtF7otqsfa+rekhVTq775fbREVtCQ== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2024 11:39:40.2716 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f62f7854-f0cc-43c3-ff68-08dc27084e17 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM3PEPF00009B9C.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB7387 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: eUmgLaYwuKdoktApMkz9jJhqx7686176AA= Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=mDv7K37g; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Jeff, Thank you for this patch. The changes in this patch look good to me. However, a similar change=20 also applies to the ThreadCount & ThreadCount2 fields. Although, this patch only talks about CoreCount, would it be possible to=20 update this or submit a new patch to fix the ThreadCount also, please? In either case, Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 30/01/2024 08:22 pm, Jeff Brasen wrote: > The CoreCount and EnabledCore counts should be set to 0xFF if value is > greater than 255 per the SMBIOS specification. > > Signed-off-by: Jeff Brasen > --- > .../ProcessorSubClassDxe/ProcessorSubClass.c | 37 +++++++++++++------ > 1 file changed, 25 insertions(+), 12 deletions(-) > > diff --git a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubCla= ss.c b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c > index 9050588500..921a1d0aaa 100644 > --- a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c > +++ b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c > @@ -702,19 +702,32 @@ AddSmbiosProcessorTypeTable ( > =20 > LegacyVoltage =3D (UINT8 *)&Type4Record->Voltage; > =20 > - *LegacyVoltage =3D MiscProcessorData.Voltage; > - Type4Record->CurrentSpeed =3D MiscProcessorData.CurrentSpeed; > - Type4Record->MaxSpeed =3D MiscProcessorData.MaxSpeed; > - Type4Record->Status =3D ProcessorStatus.Data; > - Type4Record->L1CacheHandle =3D L1CacheHandle; > - Type4Record->L2CacheHandle =3D L2CacheHandle; > - Type4Record->L3CacheHandle =3D L3CacheHandle; > - Type4Record->CoreCount =3D MiscProcessorData.CoreCount; > - Type4Record->CoreCount2 =3D MiscProcessorData.CoreCount; > - Type4Record->EnabledCoreCount =3D MiscProcessorData.CoresEnabled; > + *LegacyVoltage =3D MiscProcessorData.Voltage; > + Type4Record->CurrentSpeed =3D MiscProcessorData.CurrentSpeed; > + Type4Record->MaxSpeed =3D MiscProcessorData.MaxSpeed; > + Type4Record->Status =3D ProcessorStatus.Data; > + Type4Record->L1CacheHandle =3D L1CacheHandle; > + Type4Record->L2CacheHandle =3D L2CacheHandle; > + Type4Record->L3CacheHandle =3D L3CacheHandle; > + > + if (MiscProcessorData.CoreCount > 255) { > + Type4Record->CoreCount =3D 0xFF; > + } else { > + Type4Record->CoreCount =3D MiscProcessorData.CoreCount; > + } > + > + Type4Record->CoreCount2 =3D MiscProcessorData.CoreCount; > + > + if (MiscProcessorData.CoresEnabled > 255) { > + Type4Record->EnabledCoreCount =3D 0xFF; > + } else { > + Type4Record->EnabledCoreCount =3D MiscProcessorData.CoresEnabled; > + } > + > Type4Record->EnabledCoreCount2 =3D MiscProcessorData.CoresEnabled; > - Type4Record->ThreadCount =3D MiscProcessorData.ThreadCount; > - Type4Record->ThreadCount2 =3D MiscProcessorData.ThreadCount; > + > + Type4Record->ThreadCount =3D MiscProcessorData.ThreadCount; > + Type4Record->ThreadCount2 =3D MiscProcessorData.ThreadCount; [SAMI] According to SMBIOS specification 3.7, section 7.8.5 states that=20 the ThreadCount also follows a similar approact to Core Count and Core=20 Count 2 fields, see Table 28. [/SAMI] > =20 > Type4Record->CurrentSpeed =3D GetCpuFrequency (ProcessorIndex); > Type4Record->ExternalClock =3D -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115156): https://edk2.groups.io/g/devel/message/115156 Mute This Topic: https://groups.io/mt/104078446/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-