From: rebecca@bsdio.com
To: devel@edk2.groups.io, lersek@redhat.com,
Bob Feng <bob.c.feng@intel.com>,
Liming Gao <liming.gao@intel.com>,
Leif Lindholm <leif.lindholm@linaro.org>,
Michael Kinney <michael.d.kinney@intel.com>,
Andrew Fish <afish@apple.com>
Subject: Re: [edk2-devel] [PATCH] Simplify edksetup.sh
Date: Mon, 15 Jul 2019 08:40:21 -0600 [thread overview]
Message-ID: <7c2a34b2-c582-496e-b5c8-12035432a9fe@bsdio.com> (raw)
In-Reply-To: <8f3a022b-de01-27b7-d9d3-064eb1bf7232@redhat.com>
On 2019-07-12 16:21, Laszlo Ersek wrote:
>
> As long as my opinion counts... (and I totally don't insist that it do):
> the above task list will make for a nice 6-part patch series. :)
>
> (When someone is tempted to capture a *list* of changes in a single
> commit message, that frequently indicates that the patch should be split
> up, so that each change get its own dedicated patch.)
While I can see your point, in this case I think splitting the patch up
into 6 parts would be excessive. All the changes are to a single file,
and a couple of the changes in the list are to single lines.
--
Rebecca Cran
next prev parent reply other threads:[~2019-07-15 14:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-10 21:17 [PATCH] Simplify edksetup.sh Rebecca Cran
2019-07-12 16:05 ` [edk2-devel] " rebecca
2019-07-12 22:21 ` Laszlo Ersek
2019-07-15 14:40 ` rebecca [this message]
2019-07-15 14:55 ` Leif Lindholm
2019-07-15 15:01 ` rebecca
2019-07-15 17:48 ` Laszlo Ersek
2019-07-15 17:45 ` Laszlo Ersek
2019-07-15 22:37 ` rebecca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c2a34b2-c582-496e-b5c8-12035432a9fe@bsdio.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox