From: "Liming Gao" <liming.gao@intel.com>
To: Daniel Schaefer <daniel.schaefer@hpe.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Abner Chang <abner.chang@hpe.com>,
Gilbert Chen <gilbert.chen@hpe.com>,
Leif Lindholm <leif@nuviainc.com>,
"Bi, Dandan" <dandan.bi@intel.com>
Subject: Re: [PATCH v2 2/3] MdeModulePkg: Set PcdDxeIplSwitchToLongMode false on non-x86
Date: Mon, 2 Mar 2020 13:19:47 +0000 [thread overview]
Message-ID: <7c392d26e5a0498e9bfb2b694b4f7d9c@intel.com> (raw)
In-Reply-To: <20200302103238.25726-3-daniel.schaefer@hpe.com>
Daniel:
PcdDxeIplSwitchToLongMode is only used in IA32 arch. It is also specified in [FeaturePcd.IA32] section of DxeIpl.inf. So, I don't understand why defines this PCD in other ARCH in MdeModulePkg.dec.
Thanks
Liming
> -----Original Message-----
> From: Daniel Schaefer <daniel.schaefer@hpe.com>
> Sent: Monday, March 2, 2020 6:33 PM
> To: devel@edk2.groups.io
> Cc: Abner Chang <abner.chang@hpe.com>; Gilbert Chen <gilbert.chen@hpe.com>; Leif Lindholm <leif@nuviainc.com>; Bi, Dandan
> <dandan.bi@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [PATCH v2 2/3] MdeModulePkg: Set PcdDxeIplSwitchToLongMode false on non-x86
>
> Otherwise the PCD isn't defined on other architectures.
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2548
>
> Signed-off-by: Daniel Schaefer <daniel.schaefer@hpe.com>
> Cc: Abner Chang <abner.chang@hpe.com>
> Cc: Gilbert Chen <gilbert.chen@hpe.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> ---
> MdeModulePkg/MdeModulePkg.dec | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec
> index 91a3c608231c..59645c860148 100644
> --- a/MdeModulePkg/MdeModulePkg.dec
> +++ b/MdeModulePkg/MdeModulePkg.dec
> @@ -879,6 +879,9 @@ [PcdsFeatureFlag]
> [PcdsFeatureFlag.IA32, PcdsFeatureFlag.ARM, PcdsFeatureFlag.AARCH64]
>
> gEfiMdeModulePkgTokenSpaceGuid.PcdPciDegradeResourceForOptionRom|FALSE|BOOLEAN|0x0001003a
>
>
>
> +[PcdsFeatureFlag.EBC, PcdsFeatureFlag.ARM, PcdsFeatureFlag.AARCH64]
>
> + gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|FALSE|BOOLEAN|0x0001003b
>
> +
>
> [PcdsFeatureFlag.IA32, PcdsFeatureFlag.X64]
>
> ## Indicates if DxeIpl should switch to long mode to enter DXE phase.
>
> # It is assumed that 64-bit DxeCore is built in firmware if it is true; otherwise 32-bit DxeCore
>
> --
> 2.25.0
next prev parent reply other threads:[~2020-03-02 13:19 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-02 10:32 [PATCH v2 0/3] Allow building MdeModulePkg on non-x86 Daniel Schaefer
2020-03-02 10:32 ` [PATCH v2 1/3] MdeModulePkg: Restrict libraries using SMM to x86 Daniel Schaefer
2020-03-02 13:18 ` [edk2-devel] " Liming Gao
2020-03-02 17:38 ` Daniel Schaefer
2020-03-02 10:32 ` [PATCH v2 2/3] MdeModulePkg: Set PcdDxeIplSwitchToLongMode false on non-x86 Daniel Schaefer
2020-03-02 13:19 ` Liming Gao [this message]
2020-03-02 17:36 ` Daniel Schaefer
2020-03-02 10:32 ` [PATCH v2 3/3] MdeModulePkg: Use CopyMem instead of GUID assignment Daniel Schaefer
2020-03-02 13:38 ` [edk2-devel] " Liming Gao
2020-03-05 0:39 ` Dandan Bi
2020-03-12 5:58 ` [edk2-devel] " Wang, Jian J
2020-03-12 6:00 ` Abner Chang
2020-03-12 10:55 ` Leif Lindholm
2020-03-12 12:21 ` Ni, Ray
2020-03-12 13:53 ` [EXTERNAL] " Leif Lindholm
2020-03-20 7:24 ` Ni, Ray
2020-03-12 13:24 ` Daniel Schaefer
2020-03-12 14:03 ` Leif Lindholm
2020-03-12 14:33 ` Abner Chang
2020-03-12 14:44 ` Leif Lindholm
2020-03-12 14:57 ` Leif Lindholm
2020-03-13 3:57 ` Abner Chang
2020-03-12 19:42 ` Laszlo Ersek
2020-03-12 21:19 ` Leif Lindholm
2020-03-13 4:08 ` Abner Chang
2020-03-13 10:10 ` Leif Lindholm
2020-03-15 14:59 ` Abner Chang
2020-03-13 16:36 ` Laszlo Ersek
2020-03-12 19:36 ` Laszlo Ersek
2020-03-12 19:51 ` Andrew Fish
2020-03-12 21:04 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c392d26e5a0498e9bfb2b694b4f7d9c@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox