From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web12.13701.1583155190807843251 for ; Mon, 02 Mar 2020 05:19:50 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: liming.gao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Mar 2020 05:19:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,507,1574150400"; d="scan'208";a="233368103" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga008.fm.intel.com with ESMTP; 02 Mar 2020 05:19:49 -0800 Received: from shsmsx606.ccr.corp.intel.com (10.109.6.216) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 2 Mar 2020 05:19:50 -0800 Received: from shsmsx606.ccr.corp.intel.com (10.109.6.216) by SHSMSX606.ccr.corp.intel.com (10.109.6.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 2 Mar 2020 21:19:47 +0800 Received: from shsmsx606.ccr.corp.intel.com ([10.109.6.216]) by SHSMSX606.ccr.corp.intel.com ([10.109.6.216]) with mapi id 15.01.1713.004; Mon, 2 Mar 2020 21:19:47 +0800 From: "Liming Gao" To: Daniel Schaefer , "devel@edk2.groups.io" CC: Abner Chang , Gilbert Chen , Leif Lindholm , "Bi, Dandan" Subject: Re: [PATCH v2 2/3] MdeModulePkg: Set PcdDxeIplSwitchToLongMode false on non-x86 Thread-Topic: [PATCH v2 2/3] MdeModulePkg: Set PcdDxeIplSwitchToLongMode false on non-x86 Thread-Index: AQHV8H4FVX0C7EfWVUqIvpAvE/eywKg1SQtA Date: Mon, 2 Mar 2020 13:19:47 +0000 Message-ID: <7c392d26e5a0498e9bfb2b694b4f7d9c@intel.com> References: <20200302103238.25726-1-daniel.schaefer@hpe.com> <20200302103238.25726-3-daniel.schaefer@hpe.com> In-Reply-To: <20200302103238.25726-3-daniel.schaefer@hpe.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action x-originating-ip: [10.239.127.36] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Daniel: PcdDxeIplSwitchToLongMode is only used in IA32 arch. It is also specified= in [FeaturePcd.IA32] section of DxeIpl.inf. So, I don't understand why def= ines this PCD in other ARCH in MdeModulePkg.dec.=20 Thanks Liming > -----Original Message----- > From: Daniel Schaefer > Sent: Monday, March 2, 2020 6:33 PM > To: devel@edk2.groups.io > Cc: Abner Chang ; Gilbert Chen ; Leif Lindholm ; Bi, Dandan > ; Gao, Liming > Subject: [PATCH v2 2/3] MdeModulePkg: Set PcdDxeIplSwitchToLongMode false= on non-x86 >=20 > Otherwise the PCD isn't defined on other architectures. >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2548 >=20 > Signed-off-by: Daniel Schaefer > Cc: Abner Chang > Cc: Gilbert Chen > Cc: Leif Lindholm > Cc: Dandan Bi > Cc: Liming Gao > --- > MdeModulePkg/MdeModulePkg.dec | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.de= c > index 91a3c608231c..59645c860148 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -879,6 +879,9 @@ [PcdsFeatureFlag] > [PcdsFeatureFlag.IA32, PcdsFeatureFlag.ARM, PcdsFeatureFlag.AARCH64] >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdPciDegradeResourceForOptionRom|FALSE= |BOOLEAN|0x0001003a >=20 >=20 >=20 > +[PcdsFeatureFlag.EBC, PcdsFeatureFlag.ARM, PcdsFeatureFlag.AARCH64] >=20 > + gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|FALSE|BOOLEAN= |0x0001003b >=20 > + >=20 > [PcdsFeatureFlag.IA32, PcdsFeatureFlag.X64] >=20 > ## Indicates if DxeIpl should switch to long mode to enter DXE phase. >=20 > # It is assumed that 64-bit DxeCore is built in firmware if it is tru= e; otherwise 32-bit DxeCore >=20 > -- > 2.25.0