From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 41A24AC1A69 for ; Fri, 17 Nov 2023 21:43:50 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=5wCRO9x20eEJfCXC/Ce5fCzDjg4sgOy/7YPVf4xDBY4=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1700257428; v=1; b=eIhnUI3bMKkXgpftiN00K2PIt0Yf0jY9j9Lvc6uyKNBQ0VGKDWS05gXWOcI+w15XCcsk5smH uPdcpOjAGEClaN2P8msmA1I61Gfv1VyFXmZ4r5l8uNhxUBSNfrwORde+JkIpaAfiT5UiKzGPfHw 1665xU26CSOesM8ktuNK9P6Q= X-Received: by 127.0.0.2 with SMTP id Zl5zYY7687511xChXIjiyvZ3; Fri, 17 Nov 2023 13:43:48 -0800 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.80]) by mx.groups.io with SMTP id smtpd.web10.8562.1700257428277647554 for ; Fri, 17 Nov 2023 13:43:48 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wj2I4PHMiogQ3wj114btvQ3wRKlSrvJVOGTbZHK4+naQWRpaTyYYiGX6nFBAIuno7EXUY2zQV7L9ECzh/2l0FhMX5nhFQvIwA065WPi0YcyqNP/A43rMw7PbwcbBySPJwS8ILMqgfBFfZq0kabmydJwfija2kbN2eU/AF+gEjBLrLlQm8pMSerxZOqL7GGWfTjrsagoEvTk/5ZOi5I9dyKmDTlfAYKo9LML+n8ciSgIKbH3pMTHS+72NkRSrmPWzRg+D6QJk/azoKt7MbJtS9HqU+zbeAwjvYcxyZTCAEFk0ONfgOmOFrS4v0uSheUxug1aQM5d1mD4kAw9OxVIhpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EokNw/Hf0ht3MonXaIOX6742NmGDBmmcxGAQEglmsts=; b=CqMFa3jpz8PCdIKPKzeC4JX9FtkPMsPUZfkzRPyWfpJdRfmjBFEw1kTjTxv9WCfDGQt7OmjUjCnHBJZCZISs+nMTbw9u+s4cKSY5Aighk6mlAhrfVn75xThy5I46Vz7BCEEvBKW9xObPEewerUa2EbT/LwBw/WDuadJyNlzdIK2lYLH0g2B4YMbGkRZ2kj8vVZXQZYxL/Y08c2ZrDN+0lzdqPLszILA+CjCh1Omw3+HzGU2R5MyqCpOOw0JaGIzbsTYhvgp9ecEbxA8UqvZrCDnR/cbLsrMDs9e4luN/kqsb/VUmpimyggr7b9q3wmaIR21+OGQXDevMWyRIve1brQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from BL1PR12MB5732.namprd12.prod.outlook.com (2603:10b6:208:387::17) by SJ2PR12MB8650.namprd12.prod.outlook.com (2603:10b6:a03:544::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.23; Fri, 17 Nov 2023 21:43:45 +0000 X-Received: from BL1PR12MB5732.namprd12.prod.outlook.com ([fe80::1d68:1eb8:d7dc:4b43]) by BL1PR12MB5732.namprd12.prod.outlook.com ([fe80::1d68:1eb8:d7dc:4b43%6]) with mapi id 15.20.7002.022; Fri, 17 Nov 2023 21:43:45 +0000 Message-ID: <7c3e2baa-37c0-da85-bd74-55d08599fdc8@amd.com> Date: Fri, 17 Nov 2023 15:43:43 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [edk2-devel] [PATCH 0/2] SEV-SNP guest support fixes To: Gerd Hoffmann Cc: devel@edk2.groups.io, Eric Dong , Ray Ni , Rahul Kumar , Ard Biesheuvel , Michael Roth References: From: "Lendacky, Thomas via groups.io" In-Reply-To: X-ClientProxiedBy: SA9PR10CA0006.namprd10.prod.outlook.com (2603:10b6:806:a7::11) To BL1PR12MB5732.namprd12.prod.outlook.com (2603:10b6:208:387::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL1PR12MB5732:EE_|SJ2PR12MB8650:EE_ X-MS-Office365-Filtering-Correlation-Id: ca931f20-4aae-420c-714f-08dbe7b64666 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: tVvQdHtphVG58Aj5789VhYNVJbGM5fYZw8h2CrwP0TwWdngz9L4RbpEFOJst1NQtr7GZvuuEH0ou8QL14yMlMfyDbnpJV0KSwCRMTBPKeXgUbgWM3toS3P4jEh1WUll2f09E7siHYFpF5XvB8l8XQTqfS6EumkaefWbnZqigFotxuu6eB52ziJej4Q56ObnRhkvLgCAuHFqA4aqkRUArG+DZ/XRi0BEQl0CtJQYQzA6S7LXS50Y64NDbTXRfkhwR5V2NPl9dhCIOrq8puITobj4SOgmaRXbvUdsN3I1X07FKIPA9wKplD+QqLnVvSzLscc7G735Q9UwtB8ShnxDp1clTS0IRpQx/PEFYyGlQKkFHM9fEd8Ql2MCQiqG6+huYtkM0ybFAuGoWSwUbKi9p+auyExJ7QbZs6viPdnLWq0vq/7Np+ot3wuM0nMdLnt5iMU4xuV5a8Y90XnkJxweV8+sHesNdybO60tcHJo0xP+w1BWa9q+azugbkjz/Wc759tY9Y8wQI69t9UiXz3X47l+D5bbTd2dYJ3b++0LV5JL7BsmBBqBUJ/d1hPbieMNiKyyq8W4Jkt+9l34E8FO+BpOugYzgDT11sRwVdgivjhSuvP/BrKYS1QBV6UXmot/4++bYMWAbiBIFBKl4Um1z8QA== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cTZMZzZScEVKQWgzY2NiMVhYTGNRSTRpRkkzVjlobXpObVZuTTYvZkN2N0RC?= =?utf-8?B?ZURVOElLYmZtMyszSDNoSDc3Y1k4VWl3bWlZc1A1eXF5YTZIcnl0eWxWNG5Q?= =?utf-8?B?ZEpXY0JHejMzZms2Z0cvOWt3ekNvKzFuSlA1UFhzRHp0czZ2WFNJalREZmE5?= =?utf-8?B?aEdiUmd6c00yd0psT04rSTVxd282UTFrY0NDTEhKclQ4dld1TUIrUk5KcUVl?= =?utf-8?B?Q1d5cTUrN094RVpLNjJZcER2WWt4dnhWZVFZZkdXSm0zeXF5QmhJNUVJSWFD?= =?utf-8?B?RktqSnpmWndITGw4WDRsblJXcjBtWTJIZ2ZieSsvSXRBMWFlR1JDaTlDcHhz?= =?utf-8?B?cDhxK3g4OGFCdDcxS1RuMUpCdHNaM2grYkZXNksrMkNNS0NNMElKa3RadHVV?= =?utf-8?B?NXFuM1ZMR3dOdHVkNkxyOVFrVHcwZzVIOVdLSnJKakdzZlJBcDN4cW9zTUlI?= =?utf-8?B?UmhyMEpRTXVxWHRGeTNEQ1Jab08zYUtxRTlkRXVad3dacWhYWEFGdTFCb0tF?= =?utf-8?B?eVJJaGgzWThseVRXa2RvU0ZNMWNJTWU5ZUVSbVlxUEFLalRQdktMTi9MRG9X?= =?utf-8?B?V3lwRlNYNmxtM3NVS01WdjdESU8rVHFLMnZlUnpXWVEyS04yREdBRXpXZlE0?= =?utf-8?B?eVhQK3p3YlpobVhHQUFUSzlrM0VaTkd5WnQrR0VtdWZwN2c1Z3RlR1hkTXJR?= =?utf-8?B?cEhjdWhSNXowT1BmQnNyWFd0WUEzeTUvN25uempzMEJUbGtIVUVKalp2NFdZ?= =?utf-8?B?N1FSWGV5anQwYnV0cWw3NjF6WVhhSTV6MVFlNkNyY0V4YkJ1UG5rMlBKYWZN?= =?utf-8?B?M1pYNE5Mb1VOU1RWbFkvc1hFL1B1YWtuU0lLNUkvZWZBUUU0clBnUlh1Nld5?= =?utf-8?B?d25aVEcvanoxSUlmTG1Gbm5kTmZldkdnMjNjSFozRnM3Z2pHTWRnZnZVRVpE?= =?utf-8?B?L3htYVdVdTNPc04rMDNvSnBMTEZsTHRBekJzdDVQRW51cCs4K1JyM2MrZklQ?= =?utf-8?B?RkZ4VW52a2s0LzN6Zy9NQmx5OW9MM1BYOTRlNG13aGgvVGRNVlI0dXlRR1NV?= =?utf-8?B?SUp0c205Umt5NXhpWUx4NHNROVlpajh0WjhUWVdKMGppMUtCL0ZpaGNGZnlS?= =?utf-8?B?SnZjUCtyd1p5ODVmQUhCY1hRYWlXZWFrSG90ajBubi9HL1RtQWZORWpIRGt4?= =?utf-8?B?OGJWdlNvb3ZpcGFJNHhjb0FlMWcwbmY1VzBDcEZ1NDhRcEs1bWY2c0dzNnhT?= =?utf-8?B?ZlplTFUrUTIwM3FXdFN0K2FKZC9Oakpzd29uQklIZG9LT1hiYjlmWXN5NDA2?= =?utf-8?B?UXEzc200bXh4cFJNTkVTMUJONGJCMXUwa1ZkUlRvbmN2STJGcnMzckpMRjNG?= =?utf-8?B?L0oyZzh0eXpIUThpNjRXeXR4OGZSZjZqZUJaTkplcTFzNGRTSTc0eGRLTk9I?= =?utf-8?B?QlJVdUdGL1VUcFB1ZzZFejU0V2dVeTE5ZXNZem1LcDhLNW5TRkZRNFpBYVUz?= =?utf-8?B?eVpPYXpEOVkxanJWLzFIZ0ZTQ2lFQnJkbmd4VUpOeGRuWVhEY3FvNnlwNDVT?= =?utf-8?B?OHNidTNGWjJaTFVFdFpJTTRxeTJ4eG1Za0wxbVN4ME1NQjRlbG1OZUMwYklJ?= =?utf-8?B?Y0RXUnpzK0x5VWtZMy85YXRmNk0zdExwSDhGOFhqWmxiMzU3dzV3anpyRGh0?= =?utf-8?B?NzdiaGRrQk1yRjBlbHZZeEw0cFpsZEVYMVI1aVlkdWd4cTJhZG83SENGU2pT?= =?utf-8?B?TEdTOGlyT0hVaVc5UmQvMlUzWTFPSnpFZHRGdm0vMDUxN0lMUXlTZUlUUVRD?= =?utf-8?B?Wlp0WFZieWdCeGlpOVBFamVFS3hOalg2bHhOOUkzWGZoUTREeEF2eGV4UmUv?= =?utf-8?B?WjVzVG1XRWZ6RTZMb2x3eU0vWFkvOWJGMjFnQ3hWNGZpYXh3eERWWEJzZjRC?= =?utf-8?B?QkJGQW00Q1htKzZpdURISzNralN6OW4xa1NVN2RIUjJmbVNzR3B2ZEhySm02?= =?utf-8?B?NFppcEhodlNzMVFNUlZ3UFQxR0ZOSDNNNzF4ZUQ0STFPSDl4VTFiNHFYR1Nw?= =?utf-8?B?WjU3TlY5d0FvRUcxalF4dC9WeXpjUGJiN0dXcXNCYmlLNnl2QzJzRFlOZEVJ?= =?utf-8?Q?lToz5AqZ/BQ+RVP9hob3ICNSY?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: ca931f20-4aae-420c-714f-08dbe7b64666 X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5732.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2023 21:43:45.5866 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +92AUZ8FAtKmrBn0HO5EvmNkQIRRVQMrEyhF9KD0A97P/5SuUtDnEmZiGBfFWnjLAxEjz2ke37/DCyV9JLv22Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8650 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,thomas.lendacky@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: jZ1APuxirz47qm4Qxv1uSH5Hx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=eIhnUI3b; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 11/7/23 03:55, Gerd Hoffmann wrote: > On Mon, Nov 06, 2023 at 04:45:29PM -0600, Tom Lendacky wrote: >> This patch series provides fixes around AP startup and sorting: >> >> - The CPUID_EXTENDED_TOPOLOGY CPUID leaf takes a sub-leaf as input. The >> current SEV-SNP support is attempting to retrieve the this leaf with >> sub-leaf 0, but is calling AsmCpuid(), which does not clear ECX befor= e >> invoking the CPUID instruction. Therefore, because of the calling >> convention, the leaf value becomes the sub-leaf value and ends up >> returning incorrect information. Change the call from AsmCpuid() to >> AsmCpuidEx(). >> >> - When sorting the CPUs by APIC ID, the VMSA associated with the vCPU >> should follow the APIC ID. Update the sorting code to swap the VMSA >> pointer during the sort. >=20 > Series: > Acked-by: Gerd Hoffmann >=20 Eric/Ray/Rahul, Have you had a chance to review this series? These bug fixes would be good= =20 to get in for the next/latest release... Thanks, Tom -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111416): https://edk2.groups.io/g/devel/message/111416 Mute This Topic: https://groups.io/mt/102432041/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-