From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 06BE594141F for ; Fri, 15 Mar 2024 09:54:58 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=yvhztAZJnSnfr03YbRj+jre60KomAm4748V8l5cqld0=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240206; t=1710496497; v=1; b=EEsOnTPLQtG2R7thSGBHZ1JJBJfa5Gv86mGI+ppgAO5THJmp0r5fALA8d0LlJniWa8m55XhM wmFZVr2JwwA4dEqK/lkbxJ1qN15goWEwyt6z7jVcgHsl6BIPt8svgmClyAoQLKwwzP5RUa51RQq CJwdCW41rIsV7HvrULiXTn82AdK/td5oW8htYHOaXpIUODXLgaVAmOpjzwH84CVp12NLbk3Ujd3 a6Zwf172rgL81ak9uzx83gZPbQx7/aX52ehmCbZ291OLQuWu/frRUhdXMgsnxDnsTTHjEzY/ZKp fOSw3lj1upvspjnsWcLOC3WjCuRzTchoS7x15w/603yZg== X-Received: by 127.0.0.2 with SMTP id 1zA9YY7687511xImka88sUZE; Fri, 15 Mar 2024 02:54:57 -0700 X-Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by mx.groups.io with SMTP id smtpd.web11.17837.1710496496338332798 for ; Fri, 15 Mar 2024 02:54:56 -0700 X-Received: from loongson.cn (unknown [10.40.24.149]) by gateway (Coremail) with SMTP id _____8AxafDtGvRlx2wZAA--.61818S3; Fri, 15 Mar 2024 17:54:53 +0800 (CST) X-Received: from [10.40.24.149] (unknown [10.40.24.149]) by localhost.localdomain (Coremail) with SMTP id AQAAf8AxTs3sGvRlgNVaAA--.40357S3; Fri, 15 Mar 2024 17:54:52 +0800 (CST) Message-ID: <7c61ce7d-5561-4124-8c3f-03d73ef1842a@loongson.cn> Date: Fri, 15 Mar 2024 17:54:52 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v1 17/26] OvmfPkg/LoongArchVirt: Add serial port hook library To: devel@edk2.groups.io, ardb@kernel.org Cc: kraxel@redhat.com, Ard Biesheuvel , Jiewen Yao , Jordan Justen , Bibo Mao , Dongyan Qian References: <20240311093631.1251466-1-lichao@loongson.cn> <20240311093902.1254321-1-lichao@loongson.cn> <2c9c655d-6c17-4373-8dca-05196a86ca24@loongson.cn> From: "Chao Li" In-Reply-To: X-CM-TRANSID: AQAAf8AxTs3sGvRlgNVaAA--.40357S3 X-CM-SenderInfo: xolfxt3r6o00pqjv00gofq/1tbiAQARCGX0BucBaAAZsY X-Coremail-Antispam: 1Uk129KBj93XoWrKF1rCryrZw47JFyxZr18JFc_yoW8Jry3p3 43ZrW5tryqq34Iy398t34Ygw4FvFsakFyUZ3s5C3yvkFs5ua4Ikry8XryDJ3yUur1rZF1U Jrs5Zw47u3Wjg3gCm3ZEXasCq-sJn29KB7ZKAUJUUUU8529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3UbIjqfuFe4nvWSU5nxnvy29KBjDU0xBIdaVrnRJUUUkEb4IE77IF4wAF F20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r 1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAF wI0_Gr0_Xr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1l84ACjcxK6I8E87Iv67 AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AKxVWxJr0_GcWle2I262IYc4CY6c8I j28IcVAaY2xG8wAqjxCEc2xF0cIa020Ex4CE44I27wAv7VC0I7IYx2IY67AKxVWUAVWUtw Av7VC2z280aVAFwI0_Gr0_Cr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcVAKI48JMx8G jcxK6IxK0xIIj40E5I8CrwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8Jw CFI7km07C267AKxVWUAVWUtwC20s026c02F40E14v26r106r1rMI8I3I0E7480Y4vE14v2 6r106r1rMI8E67AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67 AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IY s7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r4j6F4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr 0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x07UM5l8UUUUU= Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 15 Mar 2024 02:54:56 -0700 Reply-To: devel@edk2.groups.io,lichao@loongson.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 5tgdhacmW9iaekCzIR6rUV4cx7686176AA= Content-Type: multipart/alternative; boundary="------------F8IQ2GLNjpK0GKX7LNHIMZqI" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=EEsOnTPL; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --------------F8IQ2GLNjpK0GKX7LNHIMZqI Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Ard, Thanks, Chao On 2024/3/15 17:51, Ard Biesheuvel wrote: > On Fri, 15 Mar 2024 at 10:49, Chao Li wrote: >> Hi Gerd, >> >> >> Thanks, >> Chao >> On 2024/3/15 17:33, Gerd Hoffmann wrote: >> >> On Mon, Mar 11, 2024 at 05:39:02PM +0800, Chao Li wrote: >> >> Add a serial port hook library in LoongArchVirt named >> Fdt16550SerialProtHookLib, this library is referenced from ArmVirtPkg. >> >> LoongArch QEMU virtual machine uses register of LOONGARCH_CSR_KS1 to >> transfer serial port base addres from the PEI phase to the DXE phase. >> >> Why use LOONGARCH_CSR_KS1? Can't you simply set PcdSerialRegisterBase? >> >> The LoongArch QEMU PEI stage runs on flash and does not allow set PCD op= erations(memory have not enabled), so the address can only be transferred t= hrough a SAVE register. >> > Then maybe use a HOB instead? Ha, I forgot this way, let's me try. > > >=20 > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116799): https://edk2.groups.io/g/devel/message/116799 Mute This Topic: https://groups.io/mt/104859892/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --------------F8IQ2GLNjpK0GKX7LNHIMZqI Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Hi Ard,


=
Thanks,
Chao
On 2024/3/15 17:51, Ard Biesheuvel wrote:
On Fri, 15 Mar 2024 at 10:49, =
Chao Li <lichao@loongson.cn> wrote:

Hi Gerd,


Thanks,
Chao
On 2024/3/15 17:33, Gerd Hoffmann wrote:

On Mon, Mar 11, 2024 at 05:39:02PM +0800, Chao Li wrote:

Add a serial port hook library in LoongArchVirt named
Fdt16550SerialProtHookLib, this library is referenced from ArmVirtPkg.

LoongArch QEMU virtual machine uses register of LOONGARCH_CSR_KS1 to
transfer serial port base addres from the PEI phase to the DXE phase.

Why use LOONGARCH_CSR_KS1?  Can't you simply set PcdSerialRegisterBase?

The LoongArch QEMU PEI stage runs on flash and does not allow set PCD opera=
tions(memory have not enabled), so the address can only be transferred thro=
ugh a SAVE register.


Then maybe use a HOB instead?
Ha, I forgot this way, let's me try.
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#116799) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--------------F8IQ2GLNjpK0GKX7LNHIMZqI--