From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id A0F3BD811BB for ; Mon, 29 Jan 2024 15:00:55 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=w/CrKH66XkXdh8pt5Ti4iCjkdazbGaQpueNGGy0eF/c=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1706540454; v=1; b=oKO65BmELk0pUbZ3/oivZ2UdhmaecMzRDXg012yqkASjig820YleF/v7byKJ0qPnndpPX5jP 8OSyO7InLnC/80igVrw7UANvfUbo2lImdmOvFoesllYO9dg85oYqSRSJpyihiaQ6RhdVVyYggVY +7kIYnpOc+SWNdERfWDGvUK4= X-Received: by 127.0.0.2 with SMTP id Fcz3YY7687511xuWE5n6UEgN; Mon, 29 Jan 2024 07:00:54 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.17187.1706540453571790702 for ; Mon, 29 Jan 2024 07:00:53 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-208-GKObTFgZPkauoOQnDfh8aA-1; Mon, 29 Jan 2024 10:00:49 -0500 X-MC-Unique: GKObTFgZPkauoOQnDfh8aA-1 X-Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6C9231013661; Mon, 29 Jan 2024 15:00:40 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.192.180]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4BBE12026D66; Mon, 29 Jan 2024 15:00:40 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 0D56E180038B; Mon, 29 Jan 2024 16:00:39 +0100 (CET) Date: Mon, 29 Jan 2024 16:00:39 +0100 From: "Gerd Hoffmann" To: Tom Lendacky Cc: devel@edk2.groups.io, Ard Biesheuvel , Erdem Aktas , Jiewen Yao , Laszlo Ersek , Liming Gao , Michael D Kinney , Min Xu , Zhiguang Liu , Rahul Kumar , Ray Ni , Michael Roth Subject: Re: [edk2-devel] [PATCH 12/16] OvmfPkg/PlatformPei: Retrieve APIC IDs from the hypervisor Message-ID: <7c6nnvxz6icisjswsz2z3alymocylnovvxmn2ifg7svg5udqqn@yyxzah5skvff> References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 0Z4dVlsb5tg0IX6Odfp7Rerhx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=oKO65BmE; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none) On Fri, Jan 26, 2024 at 04:13:11PM -0600, Tom Lendacky wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654 > > If the hypervisor supports retrieval of the vCPU APIC IDs, retrieve > them before any APs are actually started. The APIC IDs can be used > to start the APs for any SEV-SNP guest, but is a requirement for an > SEV-SNP guest that is running under an SVSM. > + ApicIds = AllocateReservedPages ((UINTN)PageCount); > + VmgExitStatus = CcExitVmgExit (Ghcb, SVM_EXIT_GET_APIC_IDS, (UINTN)ApicIds, 0); Ah, you pass a pointer to GHCB_APIC_IDS instead of storing the data directly in the GHCB. Scratch the patch #10 comment then. > + // Retrieve the APIC IDs if the hypervisor supports it. These will be used > + // to always start APs using SNP AP Create. > + // > + if ((HvFeatures & GHCB_HV_FEATURES_APIC_ID_LIST) == GHCB_HV_FEATURES_APIC_ID_LIST) { > + AmdSevSnpGetApicIds (); > + } Acked-by: Gerd Hoffmann This looks like it does not depend on the SVSM being present, is this correct? take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114711): https://edk2.groups.io/g/devel/message/114711 Mute This Topic: https://groups.io/mt/103986465/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-