From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mx.groups.io with SMTP id smtpd.web12.10002.1590140585615398140
 for <devel@edk2.groups.io>;
 Fri, 22 May 2020 02:43:05 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BD30230E;
	Fri, 22 May 2020 02:43:04 -0700 (PDT)
Received: from [192.168.1.81] (unknown [10.37.8.250])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 71AFB3F305;
	Fri, 22 May 2020 02:43:01 -0700 (PDT)
Subject: Re: [PATCH edk2-platforms 14/16] Platform/NXP: LS1043aRdbPkg: Enable NetworkPkg
To: Wasim Khan <wasim.khan@oss.nxp.com>, devel@edk2.groups.io,
 meenakshi.aggarwal@nxp.com, vabhav.sharma@nxp.com, V.Sethi@nxp.com,
 leif@nuviainc.com, jon@solid-run.com
Cc: Wasim Khan <wasim.khan@nxp.com>
References: <1590102139-16588-1-git-send-email-wasim.khan@oss.nxp.com>
 <1590102139-16588-15-git-send-email-wasim.khan@oss.nxp.com>
From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
Message-ID: <7c862b96-47a0-2adb-f1be-0377379366e6@arm.com>
Date: Fri, 22 May 2020 11:42:59 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <1590102139-16588-15-git-send-email-wasim.khan@oss.nxp.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 5/22/20 1:02 AM, Wasim Khan wrote:
> From: Wasim Khan <wasim.khan@nxp.com>
> 
> Enable NetworkPkg for LS1043aRdb Platform.
> 
> Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>

Drop the signoff please. If Meenakshi wrote the patch, make them the 
author not the submitter.

> Signed-off-by: Wasim Khan <wasim.khan@nxp.com>
> ---
>   Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc | 11 +++++++++++
>   Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf |  5 +++++
>   2 files changed, 16 insertions(+)
> 
> diff --git a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc b/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc
> index d45fd67c03b5..8f7f9d171587 100644
> --- a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc
> +++ b/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc
> @@ -22,6 +22,13 @@ [Defines]
>     OUTPUT_DIRECTORY               = Build/LS1043aRdbPkg
>     FLASH_DEFINITION               = Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf
>   
> +  #
> +  # Network definition
> +  #
> +  DEFINE NETWORK_TLS_ENABLE             = FALSE
> +  DEFINE NETWORK_HTTP_BOOT_ENABLE       = FALSE
> +  DEFINE NETWORK_ISCSI_ENABLE           = FALSE
> +
>   !include Silicon/NXP/NxpQoriqLs.dsc.inc
>   !include Silicon/NXP/LS1043A/LS1043A.dsc.inc
>   
> @@ -54,4 +61,8 @@ [Components.common]
>     Silicon/NXP/Drivers/I2cDxe/I2cDxe.inf
>     Platform/NXP/LS1043aRdbPkg/Drivers/PlatformDxe/PlatformDxe.inf
>   
> +  #
> +  # Networking stack
> +  #
> +!include NetworkPkg/Network.dsc.inc
>    ##
> diff --git a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf b/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf
> index 931d0bb14f9b..596922221e8c 100644
> --- a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf
> +++ b/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf
> @@ -119,6 +119,11 @@ [FV.FvMain]
>     INF EmbeddedPkg/SimpleTextInOutSerial/SimpleTextInOutSerial.inf
>   
>     #
> +  # Networking stack
> +  #
> +!include NetworkPkg/Network.fdf.inc
> +
> +  #
>     # FAT filesystem + GPT/MBR partitioning
>     #
>     INF MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf
>