From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 351502041B27F for ; Wed, 25 Apr 2018 11:08:38 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 87BCE4023155; Wed, 25 Apr 2018 18:08:37 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-121-20.rdu2.redhat.com [10.10.121.20]) by smtp.corp.redhat.com (Postfix) with ESMTP id CCA89111CB8E; Wed, 25 Apr 2018 18:08:34 +0000 (UTC) From: Laszlo Ersek To: Gerd Hoffmann Cc: edk2-devel@lists.01.org, Phil Dennis-Jordan References: <20180425121055.19688-1-kraxel@redhat.com> <92f69b02-b5ab-ed7c-e726-7bdf646494e6@redhat.com> Message-ID: <7ca4b23c-92c5-a707-a03b-8b58b175899d@redhat.com> Date: Wed, 25 Apr 2018 20:08:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <92f69b02-b5ab-ed7c-e726-7bdf646494e6@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Wed, 25 Apr 2018 18:08:37 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Wed, 25 Apr 2018 18:08:37 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH] QemuVideoDxe: round up FrameBufferSize to full page X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Apr 2018 18:08:38 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 04/25/18 16:08, Laszlo Ersek wrote: > (1) Please use the EFI_SIZE_TO_PAGES() macro for rounding up the size. > > (EFI_SIZE_TO_PAGES() takes one UINTN argument, but there's no need for > an explicit cast, because > "EFI_GRAPHICS_OUTPUT_PROTOCOL_MODE.FrameBufferSize" is already UINTN.) Argh, this request was incomplete. I meant to say: * Please use EFI_SIZE_TO_PAGES() *with* EFI_PAGES_TO_SIZE() to round up the value -- this is a pattern we use in edk2 quite a bit, see: git grep -w -e EFI_PAGES_TO_SIZE --and -e EFI_SIZE_TO_PAGES (ALIGN_VALUE(), EFI_PAGE_SIZE, EFI_PAGE_MASK etc are also OK to use, but they generally require casting even the constants to UINTN first -- because those are genuinely "int", i.e. INT32 --, and the casting is arguably uglier than the above-proposed pattern, where the size that we start out with is already UINTN.) Thanks! Laszlo