From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 37185AC12CE for ; Mon, 13 Nov 2023 11:09:08 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=szu1SZOYliDzXuowZhFrl6i73+hvXS6RzblOmhajKK0=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1699873746; v=1; b=RWIszwJBiDdCAY66NfKPlR/ujBrD+15xxa5Wni8HD+5WXC+L2cN4GkQjlw6by/lAqgPqeF9y 2C8aEtbJQNaUf8FZ0bCUQ3KAyC9KFvsAtyryT/0KnU/oPs8ZvjCL8ETtrP6nwQVBou8bWAtQ2SN bQ3iQSD8SsJjCAp1dQATQoV0= X-Received: by 127.0.0.2 with SMTP id 3SXeYY7687511x3UcGWIlfId; Mon, 13 Nov 2023 03:09:06 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.34499.1699873746187988687 for ; Mon, 13 Nov 2023 03:09:06 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-578-wrI3E83oN5OUUEvieR3ePA-1; Mon, 13 Nov 2023 06:09:01 -0500 X-MC-Unique: wrI3E83oN5OUUEvieR3ePA-1 X-Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8F42C85C1A0; Mon, 13 Nov 2023 11:09:00 +0000 (UTC) X-Received: from [10.39.192.220] (unknown [10.39.192.220]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EB57740C6EB9; Mon, 13 Nov 2023 11:08:58 +0000 (UTC) Message-ID: <7cc254fe-ac77-ea93-2c8d-d9ac2549da69@redhat.com> Date: Mon, 13 Nov 2023 12:08:57 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v2 24/30] OvmfPkg/LoongArchVirt: Add platform boot manager library To: Gerd Hoffmann , Chao Li Cc: devel@edk2.groups.io, Ard Biesheuvel , Jiewen Yao , Jordan Justen , Xianglai Li , Bibo Mao References: <20231106032521.2251143-1-lichao@loongson.cn> <20231106033021.2294243-1-lichao@loongson.cn> <0e2c2f4d-c559-f9f9-881a-143eec02de4d@redhat.com> <3e97f949-1ad3-4685-901f-945d8101a7df@loongson.cn> From: "Laszlo Ersek" In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: e96gdYzLIWWrPSIdSjL3uidIx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=RWIszwJB; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 11/10/23 10:46, Gerd Hoffmann wrote: > On Fri, Nov 10, 2023 at 03:09:47PM +0800, Chao Li wrote: >> Hi Laszlo, >> >> Sorry, I'm not check carefully, it is really **copied**, and we not thin= k >> the ARM version is not good enough. >> >> So, can I move this library to OvmfPkg so other ARCH use it easily? >=20 > Moving code from ArmVirtPkg to OvmfPkg is fine. >=20 > OvmfPkg is the home for both x86 virtual machine bits and shared code. > The later used to be mostly virtio drivers, but with the arrival of > riscv some fdt support code has already moved from ArmVirtPkg to OvmfPkg > so arm and riscv can share it. Doing the same for loongarch is > perfectly fine. Agreed! The naming of course remains tricky. :) It's not easy to come up with good names for distinguishing various instances of the same library class. I suggest renaming "OvmfPkg/PlatformBootManagerLib" to "PlatformBootManagerLibX86", and calling ArmVirtPkg's instance (once moved) PlatformBootManagerLibGeneric or just PlatformBootManagerLib. Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111140): https://edk2.groups.io/g/devel/message/111140 Mute This Topic: https://groups.io/mt/102413902/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-