From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
To: Leif Lindholm <leif@nuviainc.com>
Cc: devel@edk2.groups.io
Subject: Re: [PATCH] EmbeddedPkg: rename gEfiMmcHostProtocolGuid to gEdkiiMmcHostProtocolGuid
Date: Wed, 29 Apr 2020 23:27:52 +0200 [thread overview]
Message-ID: <7cc63e8e-ea01-af04-ba46-ccfb3492d7e8@arm.com> (raw)
In-Reply-To: <20200429200648.GJ21486@vanye>
On 4/29/20 10:06 PM, Leif Lindholm wrote:
> On Wed, Apr 29, 2020 at 20:27:04 +0200, Ard Biesheuvel wrote:
>> In EDK2, identifiers carrying the EFI prefix are reserved for ones
>> that are defined in the UEFI or PI specifications. For protocols that
>> are part of the internal EDK2 implementation, we use EDKII instead.
>>
>> Since the MMC host protocol defined in EmbeddedPkg is not the one that
>> the UEFI spec defines, and given the confusion around this, let's rename
>> it to gEdkiiMmcHostProtocolGuid.
>
> 1) Yes, please, let's change this.
> 2) But not s/Efi/Edkii/ please.
>
> We want to get rid of this thing - and the "replacement" in
> MdeModulePkg has things called gEdkiiPeiSdMmcHostControllerPpiGuid and
> gEdkiiSdMmcOverrideProtocolGuid, so I think this would still be
> confusing.
>
> Could we call it plain gEmbeddedPkgMmcHostProtocolGuid or
> gEmbeddedMmcHostProtocolGuid instead?
>
The latter seems the most suitable to me.
next prev parent reply other threads:[~2020-04-29 21:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 18:27 [PATCH] EmbeddedPkg: rename gEfiMmcHostProtocolGuid to gEdkiiMmcHostProtocolGuid Ard Biesheuvel
2020-04-29 20:06 ` Leif Lindholm
2020-04-29 21:27 ` Ard Biesheuvel [this message]
2020-04-29 21:34 ` Leif Lindholm
2020-04-30 8:12 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7cc63e8e-ea01-af04-ba46-ccfb3492d7e8@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox