From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mx.groups.io with SMTP id smtpd.web11.778.1588195677371362724
 for <devel@edk2.groups.io>;
 Wed, 29 Apr 2020 14:27:57 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6CD191063;
	Wed, 29 Apr 2020 14:27:56 -0700 (PDT)
Received: from [192.168.1.81] (unknown [172.31.20.19])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C5A373F68F;
	Wed, 29 Apr 2020 14:27:55 -0700 (PDT)
Subject: Re: [PATCH] EmbeddedPkg: rename gEfiMmcHostProtocolGuid to gEdkiiMmcHostProtocolGuid
To: Leif Lindholm <leif@nuviainc.com>
Cc: devel@edk2.groups.io
References: <20200429182704.8715-1-ard.biesheuvel@arm.com>
 <20200429200648.GJ21486@vanye>
From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
Message-ID: <7cc63e8e-ea01-af04-ba46-ccfb3492d7e8@arm.com>
Date: Wed, 29 Apr 2020 23:27:52 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <20200429200648.GJ21486@vanye>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 4/29/20 10:06 PM, Leif Lindholm wrote:
> On Wed, Apr 29, 2020 at 20:27:04 +0200, Ard Biesheuvel wrote:
>> In EDK2, identifiers carrying the EFI prefix are reserved for ones
>> that are defined in the UEFI or PI specifications. For protocols that
>> are part of the internal EDK2 implementation, we use EDKII instead.
>>
>> Since the MMC host protocol defined in EmbeddedPkg is not the one that
>> the UEFI spec defines, and given the confusion around this, let's rename
>> it to gEdkiiMmcHostProtocolGuid.
> 
> 1) Yes, please, let's change this.
> 2) But not s/Efi/Edkii/ please.
> 
> We want to get rid of this thing - and the "replacement" in
> MdeModulePkg has things called gEdkiiPeiSdMmcHostControllerPpiGuid and
> gEdkiiSdMmcOverrideProtocolGuid, so I think this would still be
> confusing.
> 
> Could we call it plain gEmbeddedPkgMmcHostProtocolGuid or
> gEmbeddedMmcHostProtocolGuid instead?
> 

The latter seems the most suitable to me.