From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from Internet2.beckhoff.com (Internet2.beckhoff.com [194.25.186.210]) by mx.groups.io with SMTP id smtpd.web09.3154.1649309051078112080 for ; Wed, 06 Apr 2022 22:24:11 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@beckhoff.com header.s=mail2022r header.b=ef1y7Wnu; spf=pass (domain: beckhoff.com, ip: 194.25.186.210, mailfrom: c.koehne@beckhoff.com) DKIM-Signature: v=1; c=relaxed/relaxed; d=beckhoff.com; s=mail2022e; t=1649309048; bh=YhEqVEk7Y4Ccda7NBJEDDY2SWcLxYsVAt9QBINLyR4o=; h= "Subject:Subject:From:From:Date:Date:ReplyTo:ReplyTo:Cc:Cc:Message-Id:Message-Id"; a=ed25519-sha256; b= yZlUujx9/B/8gns0ll+suHcJOXMQZgWOIsSFCV64W8Eklb7LJcVwwqhs+vSXnPtQ+5HLN7jNRymhfnXSx+X0Cg== DKIM-Signature: v=1; c=relaxed/relaxed; d=beckhoff.com; s=mail2022r; t=1649309048; bh=YhEqVEk7Y4Ccda7NBJEDDY2SWcLxYsVAt9QBINLyR4o=; h= "Subject:Subject:From:From:Date:Date:ReplyTo:ReplyTo:Cc:Cc:Message-Id:Message-Id"; a=rsa-sha256; b= ef1y7Wnu0bAsoc6YR0bJIf3HRfCljGdtmghIt4Qp0Z9U7FPEftY1BAzAq+SFoxcG1lwpMuNoN2NHYzTcPxvpN5IINGR2pBol+UclLj7AZPISlYLOh3cT5btm+89xostmWCw8ODZRivx45cSIAZTVJVRq8UuMNMXfbELPbfiBG/8h6eUih6nQnI3LlPLMSFIcuk8C4pgBJeApDUI1ErQ8aE5VkxN1iLU0Et4i0YGPN1N9Cs/KMlKkZ4Yhlti2hfSkpZTt2lva+YTiFesqMh31v2o2CBPX1Iyeb+Q+TM9rzs7t7wqvhTZ+w9a1zdnwl4z5qhjPJFQ/HB5UFPaefINJDA== Received: from 172.17.5.170 by Internet2.beckhoff.com (Tls12, Aes256, Sha384, DiffieHellmanEllipticKey256); Thu, 07 Apr 2022 05:24:07 GMT Received: from ex04.beckhoff.com (172.17.5.170) by ex04.beckhoff.com (172.17.5.170) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.24; Thu, 7 Apr 2022 07:24:06 +0200 Received: from ex04.beckhoff.com ([fe80::c545:54e6:8481:2958]) by ex04.beckhoff.com ([fe80::c545:54e6:8481:2958%6]) with mapi id 15.01.2375.024; Thu, 7 Apr 2022 07:24:06 +0200 From: =?UTF-8?B?Q29ydmluIEvDtmhuZQ==?= To: Peter Grehan , Rebecca Cran , "devel@edk2.groups.io" CC: Ard Biesheuvel , Jiewen Yao , Jordan Justen , "FreeBSD Virtualization" , Gerd Hoffmann Subject: Re: [edk2-devel] [PATCH v2] OvmfPkg/BhyveBhfPkg: add support for QemuFwCfg Thread-Topic: [edk2-devel] [PATCH v2] OvmfPkg/BhyveBhfPkg: add support for QemuFwCfg Thread-Index: AQHYQ1XKFBPmowqPYken/pnSIt7nHazigQ9wgACTBQCAACN/AIAAv1NA Date: Thu, 7 Apr 2022 05:24:06 +0000 Message-ID: <7cdf6ac12fbc499fb846f85782d06e21@beckhoff.com> References: <20220329101417.617-1-c.koehne@beckhoff.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [94.134.181.251] x-olx-disclaimer: EX04.BECKHOFF.COM MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Hi Peter and Rebecca, thanks for your feedback. This patch is backward compatible. It checks if QemuFwCfg is available and if QemuFwCfg is missing it falls back to BhyveFwCtl. So, should I add Reviewed-by (or Acked-by?) Peter and Rebecca to the commit message? Thanks Corvin Beckhoff Automation GmbH & Co. KG | Managing Director: Dipl. Phys. Hans Bec= khoff Registered office: Verl, Germany | Register court: Guetersloh HRA 7075