From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (NAM04-DM6-obe.outbound.protection.outlook.com [40.107.102.71]) by mx.groups.io with SMTP id smtpd.web12.2020.1601052771672322701 for ; Fri, 25 Sep 2020 09:52:51 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@amdcloud.onmicrosoft.com header.s=selector2-amdcloud-onmicrosoft-com header.b=w2LzQsrl; spf=none, err=SPF record not found (domain: amd.com, ip: 40.107.102.71, mailfrom: thomas.lendacky@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cgTxBh/Ezd15HYNjIVptfi0UvuYZm7Iv8boq4IywHyRQnYbx3RYjVEVXseUbjFiM2Ih/5SG9IuEZ+qYTPgJbzl+gPlYml9imKn2kdUDScA/yIa+FYY1ZSjWnt8KtxhLFJa7Wd3W28lszcWB2uRxN2hh+rczUDqiMjReGDa3R2UqoE2GpV844ay4jd6bwn27holL5REOvQ2sxFHIB2lDnihF63nQDPDRDvH3VZ4zcgunPKNBHUyIEteu9n5dZXD0R0EBK4h9if6Wdi9oNdWdJtXpm/hHcmrPapzS0ggRwxXmHEV3OdZn7pC3BmWbATScaKKVBhMucTIxm295iN0vuSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ahs3sNGjKKrctnoEdKV9UePLQqaUaROoNZAbb7kA0tE=; b=J8ETJVKKB1AdBhc2ILyiB0jch5+QoTsNwVVqRqT7dvkAo9U5dQidda91MMFadNssUg2NJpYHahbunMN8+100UupqHQRXxQUK7RItIS4Y5cyNAa1efbqsPnN1f7MJapRJuTkqudXmjbCOzLaRT+IMaRNVnHo5aAJCCokbR/NFUClQnoSF5s3EnjYoSqZUCzuoP3wLIqPNhX/Npuy+raA0xBCL2BQLIoIYrzNrew13YDUKF61pm4QB6eMnHyL/snYMgNr0kYAMkM7yNum3eDw/bSaiM448kAZZnbZqgwI0rlAXX/WmmnPYtQ4OuCY8OnT6jVbfbxMDyNXOE7hBOap0JQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ahs3sNGjKKrctnoEdKV9UePLQqaUaROoNZAbb7kA0tE=; b=w2LzQsrlPRui2c4ruKPZGnlAmYLbNX2mtwsgGAw2MHPUE5cFlP2dfFhY2fVd3APnHrX8DSJMa00AQPa994tBOcnG+hNZ6h9YL/I5FIzcygvdUQwgIxmrqZait0JD+7zZRpBAFJJnOwZAtBGx/oS2kotCeHxRwi6RK+xlLb7embQ= Authentication-Results: amd.com; dkim=none (message not signed) header.d=none;amd.com; dmarc=none action=none header.from=amd.com; Received: from DM5PR12MB1355.namprd12.prod.outlook.com (2603:10b6:3:6e::7) by DM6PR12MB3179.namprd12.prod.outlook.com (2603:10b6:5:183::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.20; Fri, 25 Sep 2020 16:52:50 +0000 Received: from DM5PR12MB1355.namprd12.prod.outlook.com ([fe80::299a:8ed2:23fc:6346]) by DM5PR12MB1355.namprd12.prod.outlook.com ([fe80::299a:8ed2:23fc:6346%3]) with mapi id 15.20.3391.024; Fri, 25 Sep 2020 16:52:49 +0000 Subject: Re: [edk2-devel] [PATCH v2 1/1] UefiCpuPkg/MpInitLib: Reduce reset vector memory pressure To: "Brian J. Johnson" , devel@edk2.groups.io, lersek@redhat.com CC: Eric Dong , Ray Ni , Rahul Kumar , Brijesh Singh , Garrett Kirkendall References: <21345cdbc906519558202b3851257ca07b9239ba.1600884239.git.thomas.lendacky@amd.com> <091b5170-a56c-b1f8-0afe-86444df43e49@hpe.com> From: "Lendacky, Thomas" Message-ID: <7ce0ed61-f2c6-a21e-e143-76c54da3ebfc@amd.com> Date: Fri, 25 Sep 2020 11:52:47 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 In-Reply-To: <091b5170-a56c-b1f8-0afe-86444df43e49@hpe.com> X-ClientProxiedBy: SA9PR10CA0023.namprd10.prod.outlook.com (2603:10b6:806:a7::28) To DM5PR12MB1355.namprd12.prod.outlook.com (2603:10b6:3:6e::7) Return-Path: thomas.lendacky@amd.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from office-linux.texastahm.com (67.79.209.213) by SA9PR10CA0023.namprd10.prod.outlook.com (2603:10b6:806:a7::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.23 via Frontend Transport; Fri, 25 Sep 2020 16:52:48 +0000 X-Originating-IP: [67.79.209.213] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: ffae5fa3-d0ff-429e-81f5-08d861736f73 X-MS-TrafficTypeDiagnostic: DM6PR12MB3179: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CHEBWe7SrC28fWCVEIeRhI9/2lYgID61Ftq6pzOse/hHNaYRkNRCh4xV2sDctyh98NnFdPuz7acR5qSxcmBKTw8tbtJeFWaEofqvQOWvKROc2kQfuKzpegI6MQ/gMISC7OssOQc2sNUlTON/VelXP2NnMlxoewaDV39boXcMyUsSovfc2JRSZ2liqZrmU7PlHSQDCJeqyZFQoCks2nwA1SckqrtwcawDzcYnv1mZbtA9c5wxarc0ARGXDmSJwf260GZ3dQPY+djcA0v4g+EkmWy5m6gv70+pa7pxWyAPTSAtR5NAvvSfWY3Qi9ACtXrATx9KI5hCH89o/2YDh5wlLPcvjClvdgZjmCL+gNkn0bAGlBoOIpTiwdAGacPGqmwo8OqLYDFFnAUJfRZ4hEp8kPYO4mou75DnMf6dFh21On2o7LXh0F9hCkkC6vYgv3bH X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR12MB1355.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(396003)(136003)(376002)(346002)(39860400002)(366004)(6506007)(54906003)(4326008)(5660300002)(8676002)(52116002)(6486002)(16526019)(53546011)(186003)(26005)(478600001)(31686004)(2616005)(36756003)(316002)(956004)(66556008)(6512007)(8936002)(86362001)(31696002)(66946007)(66476007)(2906002)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: kXuAP/osjSl6aHkzLkOw6n1Bo6YxOzBt4zsV+AK2RLg8Ml0/2AWAsFEq2p4RNryPgcA+euzmPhyyC+oJ/K4ZQLAJa93Dnf1ZUXlvtGZEk1qxPTodRlBzEzagoAS/K6zCi3jztkWXQP4iPgQyVRzLdJXW8+Qx0+SsOyjC/n1xQ+4zbeuQnTp4YYlBhuZMXKrkGkjpjdJQhRoaBLwa0IryOscPtiMHIauvowhINEhFioL4V6Yw2/anO5w7eFhyU45nbxotprSu2SMcGcIskvij+1WIMHRUxVv5cgN/CgyEOhRtNXeUdaiVH3ezyUh/KCbmoEkPGo7RDvXstFJG0fbb7WN681ZkoTRIJgEdLaKrjcAuwVquC6Zpfp2vfcg/U9U4MDRNHt39Sgx2+bRREsV2hyg5TxND/OxuYY8gRllFb/AHDrch51H55tU2L5csNW/3C3U9b5Mg6mdfUGSHxO5jveaZyN5QdJ/ezo1Mrv2lS0nEfnrXJ7Me8hJ33veMeYvqQokQxXiUg0ocY6w/acMCdo23mRWvQ0h8tpft4FFT4AnUSzXZ1hdRm5xG81TjapOvSbl+TSVUXag6iwB9gJ8JY2/LvbUIoBQjwFAKwvCuikqfzGUIP5YmpuEQaCcye/lvSKtABovGPFsAhESZUwqkVg== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: ffae5fa3-d0ff-429e-81f5-08d861736f73 X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB1355.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Sep 2020 16:52:49.6817 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LsoQl3HwAZUtOyg1xgAIA5hS/bdim4KflYIAQOvfA72zwB6QtOFI8UEW97NSTU4H+26ip4fVtDDVrR+RpresWQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3179 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 9/25/20 11:09 AM, Brian J. Johnson wrote: > On 9/24/20 1:22 AM, Laszlo Ersek wrote: >> - I don't remember if it's required that the APIC ID space be densely >> populated. For example, if we have a topology with 7 possible (=3D >> maximum) logical CPUs, I'm unsure if a spec forbids any of those CPUs >> from having APIC ID 7. That could cause a problem in >> MpInitLibSevEsAPReset(), I assume. >=20 > FWIW, there are many bare metal processors with non-contiguous APIC IDs.= =20 > =C2=A0Intel puts the socket ID in the upper bits of the APIC ID.=C2=A0 S= o if the=20 > socket doesn't have a power-of-two number of cores, there is always a=20 > gap.=C2=A0 Plus, the BSP doesn't always have APIC ID 0 -- it depends on w= hich=20 > physical cores passed the manufacturing tests for that particular part.=20 > That has broken various kernels, BIOSes, and other software at times. So= =20 > it's best not to make assumptions. >=20 > I don't know if that applies to VMs, though.=C2=A0 The standards may be=20 > different (if there are any standards at all in that area.) Yes, I'm working on a patch to use GetProcessorNumber() instead of using=20 the APIC ID. Thanks, Tom >=20