From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (EUR04-HE1-obe.outbound.protection.outlook.com [40.107.7.79]) by mx.groups.io with SMTP id smtpd.web11.43148.1660836541536244235 for ; Thu, 18 Aug 2022 08:29:02 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=FJEn0afs; spf=pass (domain: arm.com, ip: 40.107.7.79, mailfrom: sami.mujawar@arm.com) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=aIL9NEtgXiGukImHusLvXxMrFrepcVHBrndEAEXTOvwvmAEgfBZ7lHDPQEG7PdcdRt68uSUiqR5H9a6tEgD5xzP0fFeTQRZZH62EsK8mnE4VQ+PBV45UdDumozoYMlR1Cs5dW36ooDSm1118WISwv28eAua/xMjsUgrbbIQjfdJQePOkqhI4C9fceYaVyGVuMt8GWX+tmtEmMN6Y8wh2ed8kEN5OtOM082+XVGCogg1iakvTRFfcbqY8PDP5/eXru2doY2/bB+vbJUMWQk9n+wC36czkitqgoht33WSY4jkmpNNIMEB8m8LW/OJdW4ifr7IQyLd2uKEXYYM352s4Rw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LDKZTiex3YBb9f06Q06VPijSCwq8y5O6Ly0cVJG06G0=; b=Yqr6KfTwDEIxXv7h5F87j4JUE+sOBpR1fgeNbNg3+A3ap7uccYCi+MaH51kxx08/GY6v+Y7TmPIKdQeKYjVuArTWWE3DPAL95ocTFo25fOUuA8JOY744xMREmQd555/m5IJw/dAXsb8evcS+jzr9C17ybuKpINCFx8xi/cFNwNoLphjHLbcdr3X0CZi52FzVZ9JOXnJORTosivlatgkAsbZykmqYIMqcMqwAovY+EIJOOU0i4rC3Zwz72mND0nG0QmIyT/TdEaYffLtneLzG1QssCB45fpBGTbGVLvCfSS9WzNU6QV5xTBPYcxsxh6HFxvsKB67g7JhiZtcPTX0fdw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LDKZTiex3YBb9f06Q06VPijSCwq8y5O6Ly0cVJG06G0=; b=FJEn0afsLJbH9jLW+gLSXfgSVOY7ft67RXuGTEGyjEyX/Elthizun/VXXWvEVEeygWQY4Icd2+3Ig02jCuGT6KocwY4tCQSKkRSZUxMNHeavBZzSLCfBVQv5Wn3e9xaXPYvTGr4czoxz6bA8McHTg7I6gvu/yMWLXJ22J0BMUgA= Received: from DB7PR03CA0087.eurprd03.prod.outlook.com (2603:10a6:10:72::28) by AM0PR08MB2947.eurprd08.prod.outlook.com (2603:10a6:208:5f::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.22; Thu, 18 Aug 2022 15:28:58 +0000 Received: from DBAEUR03FT004.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:72:cafe::70) by DB7PR03CA0087.outlook.office365.com (2603:10a6:10:72::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.19 via Frontend Transport; Thu, 18 Aug 2022 15:28:58 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT004.mail.protection.outlook.com (100.127.142.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.15 via Frontend Transport; Thu, 18 Aug 2022 15:28:57 +0000 Received: ("Tessian outbound 6a3290ff1310:v123"); Thu, 18 Aug 2022 15:28:57 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 84d0bcac0289516a X-CR-MTA-TID: 64aa7808 Received: from ed3209506129.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C82D4E0D-03DD-48EC-BE64-A362C705101B.1; Thu, 18 Aug 2022 15:28:47 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ed3209506129.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 18 Aug 2022 15:28:47 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T+JcLNypBN9lwI/YTlYKJnaef/9auT8LCfNu8ofdQ49CwqSBMaN0mlIXkVnFstX1uQVllnmGLb53YKD4wdUWZHLCvLggHFLDma98H9kziZ4TmaiMCUNs+iGqGMrsI8RdiduXscKj7AhnM0rDEKvCO/MEnxBaFI94gmoJin+DTcrTACsOBOiD2JbcTmUKBjZVw1IlMRjIKySKaftWo9EatChiYevtu7R01x7lHRmc8OcczzCTx8+W1WWr3RzkgucvejfBTzgCVowXxkD4sp2JbVYua26KoTmJ42l+1Tjz9nt0sk1i4Cg+IASluXw2WbXnEs//SarYxyCQeWA6XT6/IA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LDKZTiex3YBb9f06Q06VPijSCwq8y5O6Ly0cVJG06G0=; b=oIEZOh+6l07eEimMd6nV2Kc/C6roIaBtxHev1/cqgWFCVWMoAQuLPSoSAPQ4bnKlUVX6RjpHRoO3h/mVoylBnNUslAFgXEjr5RgaI5KN9aw13MBgjDdpgrUAtfwFa5svUJv8m0hwr0KxNfsPvlAZWguLygyNWvc5f7TOujMpp6l3pxe5hmOJdr6dwuhQbq+iJKjDmu4CjCzoF9K7Qoezp1CcPKSmCmqeVNrkS++q2JsjP4UhXxsci+O0VO+vyZIQMJGc2zG9XckWK1y/Z3PV05QlgED47ls3pW4xkDnmpw42XRgpU5izspwpfYDhG/cnOVG/Y33L7dOfzpUSjizTSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LDKZTiex3YBb9f06Q06VPijSCwq8y5O6Ly0cVJG06G0=; b=FJEn0afsLJbH9jLW+gLSXfgSVOY7ft67RXuGTEGyjEyX/Elthizun/VXXWvEVEeygWQY4Icd2+3Ig02jCuGT6KocwY4tCQSKkRSZUxMNHeavBZzSLCfBVQv5Wn3e9xaXPYvTGr4czoxz6bA8McHTg7I6gvu/yMWLXJ22J0BMUgA= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by VI1PR08MB3741.eurprd08.prod.outlook.com (2603:10a6:803:ba::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.11; Thu, 18 Aug 2022 15:28:44 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::d562:5a52:f638:7fe9]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::d562:5a52:f638:7fe9%6]) with mapi id 15.20.5504.027; Thu, 18 Aug 2022 15:28:44 +0000 Message-ID: <7cec07c0-09ee-e327-2a9f-0f65f7964fc9@arm.com> Date: Thu, 18 Aug 2022 16:28:41 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] DynamicTablesPkg: Correct cluster index To: Ard Biesheuvel , Jeff Brasen Cc: "devel@edk2.groups.io" , "quic_llindhol@quicinc.com" , "Alexei.Fedorov@arm.com" , "nd@arm.com" References: <81913483228a6d636f164831d41424717d46fbb4.1660682661.git.jbrasen@nvidia.com> From: "Sami Mujawar" In-Reply-To: X-ClientProxiedBy: LO4P123CA0524.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:2c5::9) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 62006b92-6fe0-432d-6b28-08da812e5e72 X-MS-TrafficTypeDiagnostic: VI1PR08MB3741:EE_|DBAEUR03FT004:EE_|AM0PR08MB2947:EE_ X-LD-Processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: hJ+CFr4PSr600V02fe3Nye4fAW+tBGyYEGc+BYn6hYSM9SQZRLzpSWAj7IXEDXguMaPGxHU7vZn5fTA0SItZj8oicte4VklQ0kLvTYPWNyimYpj3ooCuohPfkRmq5Plz06/6bHZb6nIQT63pjMmYHkXAIaLV5m4ixt3V6WjxWmLiTo/JUCkkACaPiBNithRuV8VGWCFNwF8CfuysZTY0vDj+tLxhw/9xZeEPiHFp8f9wdLe6PBPlEf4JijMUady2ghvHzWnCuzDqAOzcZep6Qg0tb5IWlinHO1Jf5HMq3onB/odVDf3GKzOto5xydlM02gWDzGe+RWs5AUkJNJv5z8tpgaOkQ2zMgWN25S7ndJ4MZF2FAHPadG1NKhtwV7/zd8pdPbKihGK2davFdmGEjaNrfN3kRhWJQAnoQQY9sRRodwVjsym5vpFU2CCxxq2LW0tfhiM13PrhR1d+W5T+IwMxJu4PDx+BgiXHEaJEKOzji32LcpWxNbLY5rE7RNtxlxSZr6fo5u7IWef2DXO0iXDpjq3suPeoeRgmzg38WfOG7W7A9aGIGMr3SILhf7t9FJAPIJRwvmiiYTJHdFzf3eBpwnFXZ2Ip0hKb0tLKizfYzR8QuH1hfp0mG2PHcnllVNIMBO1XToEFRdasz2en0Jxa2Tx2WIB8q4M7ixRBcSx9vJfxAwCEV1OfhSFH+Ik8yxKkYsKYfOLaCQRx7gj0X+pMMU/759ZXb5NR9vCXXbHS6SLRq2Bj29KlTOi+3hD5fd9OUMv6/M+cDlJ0yNTSYnItJ2IDOt9GMj6VCpYtjHU= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(39860400002)(376002)(136003)(396003)(346002)(6486002)(41300700001)(83380400001)(478600001)(316002)(31696002)(54906003)(110136005)(2616005)(53546011)(6512007)(6506007)(6666004)(26005)(186003)(66946007)(31686004)(8936002)(2906002)(36756003)(5660300002)(44832011)(38100700002)(8676002)(4326008)(86362001)(66476007)(66556008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3741 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT004.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 77df1179-8eb0-42bd-64c2-08da812e564d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jMzzo0XX1nLRvuWcULsCg3rs1LEo+9pi2W02kAgUKkZXoaZZDTGCvkavM2xbLKdbjt3txjG+i98jxwbefN0TvZJhLSxlFB4hcbJy98qJBWfBLsFpEkTzppwYLRKiSOMxNaiXW1LtG5fcte3UM5q2pXkf7Wvdy8TBcVqOyKMVFG/X1Qibb0FZvSvqaKiK+8dKRNEFgpRSAzNkOo/jN9ONp3OY0SBDA0rQNUWcnMijn2cKTgCpZWwFY+Gwed2HeQBMOPDSqMPVrQDs3SNmPVc+nVNBU4kGt+mL1Q1fup7QIUJP6YBx36dQEJN8ijCvYsaDeG2WrL2h6TyTNaAsf+UAkHlmJVpkyWeGSqVyrvVqBggnQwH2qdO9Bmv4elqOUhlPf/vlv0YlvxoIDoXNZ01ozIUautZJZeZ0YYiRVk5jlkvHwFqppsZhctxjH1GADkK/JVTNCu++QXO1d7a5/OP9G+mPBgaC2Ez98gqVk/idzqn76DrCKIMycYx4pypVGCh2bhqnh9DF3BT0S6Z6qavoH7DtiVBoy6dCK72Qd4Ub0kyBpn7iIgplZGh7O/C2VDbSxuv+DewzuczRecQxEEMSSFs3B5oWuO75kLqgLklCoJZAOTvHvohzRlkMyUXNwMNKTja+H9VZXX5yFAtiQDBqZ2o0gnP9pVGYL1a3d2N/bzbgqkedpovsVLMTE2t7zgtWUKGTs0xvbN1010AO6pfI7OQE/tF+IZbZCLBJtTPvKG8rnzGczZ+ezV1vPku1w5nHoXhfQvTpV/x3vcdDibVeWwYdx94FMPHEZyULpKygP/CC3tqW4Z629e0BBHIbB130 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(346002)(396003)(376002)(39860400002)(36840700001)(46966006)(40470700004)(186003)(83380400001)(336012)(316002)(40480700001)(53546011)(356005)(6666004)(6506007)(82310400005)(6486002)(86362001)(478600001)(41300700001)(31696002)(110136005)(54906003)(2616005)(26005)(6512007)(81166007)(31686004)(5660300002)(44832011)(8936002)(47076005)(2906002)(82740400003)(36756003)(4326008)(36860700001)(70586007)(70206006)(8676002)(40460700003)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Aug 2022 15:28:57.9225 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 62006b92-6fe0-432d-6b28-08da812e5e72 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT004.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB2947 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jeff, Thank you for this patch. On 18/08/2022 11:22 am, Ard Biesheuvel wrote: > On Wed, 17 Aug 2022 at 18:14, Jeff Brasen wrote: >> >> >>> -----Original Message----- >>> From: Ard Biesheuvel >>> Sent: Wednesday, August 17, 2022 1:01 AM >>> To: Jeff Brasen >>> Cc: devel@edk2.groups.io; quic_llindhol@quicinc.com; >>> ardb+tianocore@kernel.org; Sami.Mujawar@arm.com; >>> Alexei.Fedorov@arm.com >>> Subject: Re: [PATCH] DynamicTablesPkg: Correct cluster index >>> >>> External email: Use caution opening links or attachments >>> >>> >>> On Tue, 16 Aug 2022 at 22:46, Jeff Brasen wrote: >>>> Current code will generate duplicate UID if there are nested clusters >>>> in the topology. >>>> >>> What is a nested cluster? >>> >> Better terminology would be nested processor containers, in our case we have socket/cluster/cpu. I'll update the commit message. Should I also change CreateAmlCluster to CreateAmlProcessorContainer? >> > Works for me, but Sami has the final call as he maintains this package. [SAMI] CreateAmlProcessorContainer is more appropriate. Please change CreateAmlCluster to CreateAmlProcessorContainer. Regards, Sami Mujawar