public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* Re: [edk2-devel] [PATCH v2] MdeModulePkg/RegularExpressionDxe: Make oniguruma a submodule in edk2.
       [not found] ` <15FB6FDEE28768B7.25226@groups.io>
@ 2020-03-17  0:27   ` Liming Gao
  0 siblings, 0 replies; 3+ messages in thread
From: Liming Gao @ 2020-03-17  0:27 UTC (permalink / raw)
  To: devel@edk2.groups.io, Gao, Liming, Zhang, Shenglei
  Cc: Wang, Jian J, Wu, Hao A

If no other comments, I will merge this change tomorrow. 

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Liming Gao
Sent: 2020年3月12日 11:12
To: Zhang, Shenglei <shenglei.zhang@intel.com>; devel@edk2.groups.io
Cc: Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>
Subject: Re: [edk2-devel] [PATCH v2] MdeModulePkg/RegularExpressionDxe: Make oniguruma a submodule in edk2.

Reviewed-by: Liming Gao <liming.gao@intel.com>

-----Original Message-----
From: Zhang, Shenglei <shenglei.zhang@intel.com>
Sent: 2020年3月9日 15:28
To: devel@edk2.groups.io
Cc: Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: [PATCH v2] MdeModulePkg/RegularExpressionDxe: Make oniguruma a submodule in edk2.

Use submodule way to access oniguruma. And upgrade oniguruma version from v6.9.3 to v6.9.4_mark1.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2073

Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---

v2: Include wrapper files in RegularExpressionDxe.inf.
Patch link: https://github.com/shenglei10/edk2/commits/oniguruma

 .../Oniguruma/OnigurumaUefiPort.c             |    26 -
 .../RegularExpressionDxe/Oniguruma/ascii.c    |   118 -
 .../Oniguruma/onig_init.c                     |    45 -
 .../RegularExpressionDxe/Oniguruma/regcomp.c  |  6972 ----
 .../RegularExpressionDxe/Oniguruma/regenc.c   |  1029 -
 .../RegularExpressionDxe/Oniguruma/regerror.c |   402 -
 .../RegularExpressionDxe/Oniguruma/regexec.c  |  5874 ---
 .../RegularExpressionDxe/Oniguruma/reggnu.c   |   131 -
 .../RegularExpressionDxe/Oniguruma/regparse.c |  8461 -----
 .../Oniguruma/regposerr.c                     |   108 -
 .../RegularExpressionDxe/Oniguruma/regposix.c |   304 -
 .../Oniguruma/regsyntax.c                     |   336 -
 .../RegularExpressionDxe/Oniguruma/regtrav.c  |    76 -
 .../Oniguruma/regversion.c                    |    57 -
 .../RegularExpressionDxe/Oniguruma/st.c       |   588 -
 .../RegularExpressionDxe/Oniguruma/unicode.c  |  1152 -
 .../Oniguruma/unicode_egcb_data.c             |  1374 -
 .../Oniguruma/unicode_fold1_key.c             |  2995 --
 .../Oniguruma/unicode_fold2_key.c             |   222 -
 .../Oniguruma/unicode_fold3_key.c             |   133 -
 .../Oniguruma/unicode_fold_data.c             |  1522 -
 .../Oniguruma/unicode_property_data.c         | 30388 ----------------
 .../Oniguruma/unicode_property_data_posix.c   |  5347 ---
 .../Oniguruma/unicode_unfold_key.c            |  3299 --
 .../Oniguruma/unicode_wb_data.c               |  1023 -
 .../RegularExpressionDxe/Oniguruma/utf16_le.c |   309 -
 .../{Oniguruma => }/OnigurumaIntrinsics.c     |     1 +
 .../RegularExpressionDxe/OnigurumaUefiPort.c  |    90 +
 .gitmodules                                   |     3 +
 .../RegularExpressionDxe/Oniguruma/AUTHORS    |     1 -
 .../RegularExpressionDxe/Oniguruma/COPYING    |    26 -
 .../RegularExpressionDxe/Oniguruma/README     |   195 -
 .../RegularExpressionDxe/Oniguruma/oniggnu.h  |    87 -
 .../Oniguruma/onigposix.h                     |   172 -
 .../Oniguruma/oniguruma.h                     |  1014 -
 .../RegularExpressionDxe/Oniguruma/regenc.h   |   279 -
 .../RegularExpressionDxe/Oniguruma/regint.h   |  1117 -
 .../RegularExpressionDxe/Oniguruma/regparse.h |   455 -
 .../RegularExpressionDxe/Oniguruma/st.h       |    69 -
 .../{Oniguruma => }/OnigurumaUefiPort.h       |    44 +-
 .../RegularExpressionDxe.h                    |     3 +-
 .../RegularExpressionDxe.inf                  |    73 +-
 .../Universal/RegularExpressionDxe/config.h   |     9 +
 .../Universal/RegularExpressionDxe/oniguruma  |     1 +
 .../Universal/RegularExpressionDxe/stdarg.h   |     9 +
 .../Universal/RegularExpressionDxe/stddef.h   |     9 +
 .../Universal/RegularExpressionDxe/stdio.h    |     9 +
 .../Universal/RegularExpressionDxe/stdlib.h   |     9 +
 .../Universal/RegularExpressionDxe/string.h   |     9 +
 49 files changed, 230 insertions(+), 75745 deletions(-)  delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/OnigurumaUefiPort.c
 delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/ascii.c
 delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/onig_init.c
 delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regcomp.c
 delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regenc.c
 delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regerror.c
 delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regexec.c
 delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/reggnu.c
 delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regparse.c
 delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regposerr.c
 delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regposix.c
 delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regsyntax.c
 delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regtrav.c
 delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regversion.c
 delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/st.c
 delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/unicode.c
 delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/unicode_egcb_data.c
 delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/unicode_fold1_key.c
 delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/unicode_fold2_key.c
 delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/unicode_fold3_key.c
 delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/unicode_fold_data.c
 delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/unicode_property_data.c
 delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/unicode_property_data_posix.c
 delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/unicode_unfold_key.c
 delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/unicode_wb_data.c
 delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/utf16_le.c
 rename MdeModulePkg/Universal/RegularExpressionDxe/{Oniguruma => }/OnigurumaIntrinsics.c (91%)  create mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/OnigurumaUefiPort.c
 delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/AUTHORS
 delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/COPYING
 delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/README
 delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/oniggnu.h
 delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/onigposix.h
 delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/oniguruma.h
 delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regenc.h
 delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regint.h
 delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regparse.h
 delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/st.h
 rename MdeModulePkg/Universal/RegularExpressionDxe/{Oniguruma => }/OnigurumaUefiPort.h (62%)  create mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/config.h
 create mode 160000 MdeModulePkg/Universal/RegularExpressionDxe/oniguruma
 create mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/stdarg.h
 create mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/stddef.h
 create mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/stdio.h
 create mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/stdlib.h
 create mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/string.h




^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v2] MdeModulePkg/RegularExpressionDxe: Make oniguruma a submodule in edk2.
@ 2020-04-02  7:17 Zhang, Shenglei
  2020-04-03  4:38 ` [edk2-devel] " Liming Gao
  0 siblings, 1 reply; 3+ messages in thread
From: Zhang, Shenglei @ 2020-04-02  7:17 UTC (permalink / raw)
  To: devel; +Cc: Jian J Wang, Hao A Wu, Liming Gao

Use submodule way to access oniguruma. And upgrade oniguruma
version from v6.9.3 to v6.9.4_mark1.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2073

Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---

v2:1.Update the inf file to make VS2019 build pass.
   2.Add ignore files in MdeModulePkg.ci.yaml.

The patch is too big, so I put the change on my forked tree.
https://github.com/shenglei10/edk2/tree/oniguruma

-- 
2.18.0.windows.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [edk2-devel] [PATCH v2] MdeModulePkg/RegularExpressionDxe: Make oniguruma a submodule in edk2.
  2020-04-02  7:17 [PATCH v2] MdeModulePkg/RegularExpressionDxe: Make oniguruma a submodule in edk2 Zhang, Shenglei
@ 2020-04-03  4:38 ` Liming Gao
  0 siblings, 0 replies; 3+ messages in thread
From: Liming Gao @ 2020-04-03  4:38 UTC (permalink / raw)
  To: devel@edk2.groups.io, Zhang, Shenglei; +Cc: Wang, Jian J, Wu, Hao A

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Zhang, Shenglei
> Sent: Thursday, April 2, 2020 3:17 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [edk2-devel] [PATCH v2] MdeModulePkg/RegularExpressionDxe: Make oniguruma a submodule in edk2.
> 
> Use submodule way to access oniguruma. And upgrade oniguruma
> version from v6.9.3 to v6.9.4_mark1.
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2073
> 
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> 
> v2:1.Update the inf file to make VS2019 build pass.
>    2.Add ignore files in MdeModulePkg.ci.yaml.
> 
> The patch is too big, so I put the change on my forked tree.
> https://github.com/shenglei10/edk2/tree/oniguruma
> 
> --
> 2.18.0.windows.1
> 
> 
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-04-03  4:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-02  7:17 [PATCH v2] MdeModulePkg/RegularExpressionDxe: Make oniguruma a submodule in edk2 Zhang, Shenglei
2020-04-03  4:38 ` [edk2-devel] " Liming Gao
  -- strict thread matches above, loose matches on Subject: below --
2020-03-09  7:27 Zhang, Shenglei
     [not found] ` <15FB6FDEE28768B7.25226@groups.io>
2020-03-17  0:27   ` [edk2-devel] " Liming Gao

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox