From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4E94B7803D2 for ; Thu, 2 May 2024 07:21:14 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=1pNWNeKfXILvk8wQRXdL703ImaZYdmQqZejNVTCZq9o=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:User-Agent:Subject:To:References:From:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1714634472; v=1; b=Ag3903JYmZrHAuk44KP6fG0o8baRWSy2W/z88e9aBqgHybPZ92AMscYKxfgIjWw6fpie5Pup 85fAF9eW9pCGqzgtROwu2vMz1EPe+7kRiTsadmJVYBRoG1/o3XKQwz+AU1W8Fm3//Rd+nTFGiIa WABkCeVrq7N3SiNSiISIgrGsy/hyaGgiB0xsxcILXRo9JPKeNYe98A3WKRDRmt55TGjcacrg4r/ iehduUQJpID3SzKvzX7vl8p2V/YnEYQoUfCZwyp0NSQkEioJxYbyN0X6/b7twJi7bx7i8s6dWq5 D9/1vY5Rs9Kpsxf1CUsuV9IvlS8VLXb2MHX4YYfXrnzqg== X-Received: by 127.0.0.2 with SMTP id LUuvYY7687511xEV1jMecWo2; Thu, 02 May 2024 00:21:12 -0700 X-Received: from NAM04-MW2-obe.outbound.protection.outlook.com (NAM04-MW2-obe.outbound.protection.outlook.com [40.107.101.70]) by mx.groups.io with SMTP id smtpd.web11.7953.1714634471780426852 for ; Thu, 02 May 2024 00:21:12 -0700 X-Received: from IA1PR12MB6458.namprd12.prod.outlook.com (2603:10b6:208:3aa::22) by CYYPR12MB8921.namprd12.prod.outlook.com (2603:10b6:930:c7::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.25; Thu, 2 May 2024 07:21:09 +0000 X-Received: from IA1PR12MB6458.namprd12.prod.outlook.com ([fe80::1a52:ef3a:cf04:e56d]) by IA1PR12MB6458.namprd12.prod.outlook.com ([fe80::1a52:ef3a:cf04:e56d%3]) with mapi id 15.20.7519.031; Thu, 2 May 2024 07:21:09 +0000 Message-ID: <7d09fbe1-b801-4d50-a0c6-131aa611a369@amd.com> Date: Thu, 2 May 2024 12:51:03 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [RESEND PATCH v4 0/5] DynamicTablesPkg: Adds FADT, HPET, WSMT and MADT Table generators To: devel@edk2.groups.io, Sami Mujawar , Pierre Gondois References: From: "Abdul Lateef Attar via groups.io" In-Reply-To: X-ClientProxiedBy: PN2PR01CA0178.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:26::33) To IA1PR12MB6458.namprd12.prod.outlook.com (2603:10b6:208:3aa::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA1PR12MB6458:EE_|CYYPR12MB8921:EE_ X-MS-Office365-Filtering-Correlation-Id: c01f4a5c-3f45-4cf9-169a-08dc6a787016 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?m9P8BnI8HmkY+O4iIta2u2dtmmcW10H79HzJ5KQTO4x2Fuq8hpTShnEAaohx?= =?us-ascii?Q?AAeoE9wcUtdsn+xPsn2ftAEHdO5VuHmXwJy3nXcxie4VZeWvAQakGyjbqLwS?= =?us-ascii?Q?s+sSf44kaGUtBmuQh0rargiUvoEAF2ACsMRqBGWyF3rvYynMZQA1K3sUZi7k?= =?us-ascii?Q?ZnTqXe9ngG6YM/GJemo++tkBOz8jEwWgoAroyOppt4xVNO2aUIdpoYHxJ8ju?= =?us-ascii?Q?NpSYJ1BqgCppE6E5M5mtMcZ8/t835tS3L8Bgabz4rC0sSwkEu3dKWZozcZjP?= =?us-ascii?Q?QiStuPo+g2jGA2XAthibZiyXdX6dJeuOpCMnPbU8nVFNPOvmYFnbMm1NqqiM?= =?us-ascii?Q?xeO+njj8E+IdB/5fdm49BOlJRBcSzCtsJFbG4l5zd0xuWXMqkSiK48rTDmYa?= =?us-ascii?Q?qs4XNSiVPr4hjtEnDRfvlYGPVjrRU6jKAGpY6rSeCBXQ7N+4hapUydw9fU6s?= =?us-ascii?Q?mono5mp76CP9/2qC2NVLoCxxgpiwUETcdzZ3bQFocD5t/mpMilSJWn/kdUdC?= =?us-ascii?Q?/2CPT92LUmoQmaUMToZpr4fE1UDq9ydNFuFTf4xQ7lcrOSW03sMDHt1LbwL8?= =?us-ascii?Q?IX5ggyklkFOz5h5QR2HoueFxUplq16eMTZuYGFdS7Rep7EZMMUNxT9BvVBCe?= =?us-ascii?Q?Xz393bsBs3e/2HnEYgxqoc9uzOJrQ0f00iF+s0mWKrhEZ+AmYRBGLVCkOpfx?= =?us-ascii?Q?yjdsQ17cqgKUgTx1WZJZJ6VSsKn0nnH42N5g4E+PpHy2UV3I6pFgK1TXezGi?= =?us-ascii?Q?9ScsNO79ZwFjYrOSr+TAXSkEqj5W+tRlFTuSs4h4zkXV3D75p/Bsqvkzx4K/?= =?us-ascii?Q?0Hbi8bsaLXEmkP6OPwEvEFllKld5JJ8XUfubhdhGYFGErePlPwVsKrVgAf5l?= =?us-ascii?Q?2hXnfoMbXJ5mcyThobgLFbQ7DHMib9EJim7qVVNWlOFma1pCo7vf8dEcMV3D?= =?us-ascii?Q?FDNNsMfNwIkJ8Lyj2dO7qeIZSs96BBBlhWRs9oAknP3e1uEM/e6v58e219S+?= =?us-ascii?Q?fOFEjPjK10WXOuJtd2KHdPT+kjKccTaCxu3xLtgxYauwNNjwHtfpHwk5/jov?= =?us-ascii?Q?6W7j5K2L93rppxlkA/N7/OSPXBl3PUoO5zvaGWyCZY/kAwXwpS+Zyr5mJL/U?= =?us-ascii?Q?BPgjLcBYG2sYk/7uQWnA08V6SiPDCQmg9usCiAKw8PfagJf7Lc07SU59DIK7?= =?us-ascii?Q?LZtDogO4LZJZx6Q7rkXvi2UdTAi5jnqL1/dqbbiUOB6X/T25K7E54eZ1IYV9?= =?us-ascii?Q?fhH70g/BBfev/wI5b88a7j4sdk9Ca/vw8BoVU4Igyg=3D=3D?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?g35DLNOH0bzbqimd0BjPPg1RozMeo10QcvKE3H9TmAboU4spovnf88ANUNiZ?= =?us-ascii?Q?5EVtrrCL8qe4DvhVtkWOMaj4a7getBdDOgf2WKY9C7uNDXXaJHybvwSTgSsG?= =?us-ascii?Q?RS5dLPbDo/kNg8a4cpTf7sjRqSq/V4aQlCa3ZU8uNpgYljV81Grf02u07i8p?= =?us-ascii?Q?kWvhstJ9pDD58bKaRaW5BB/lf3YuBan30k9Bm7AMdrqa1IYwErJq+qoDKqJv?= =?us-ascii?Q?fQU+pTCdRZ6zqgvZcjgGGFmkKu6pIzG7fxQGceVCERjEHwp0XFLkn/wqqk7g?= =?us-ascii?Q?X1FgcymtIL2E3K0StqR0LXiUIKSBM7kyT2AGA2acBxN2Ywwhez2lmybvR8fr?= =?us-ascii?Q?S0Ejc2TrLLJ7mfsSg9RnVZE29ERt7giSY9UvtJBO6EpDYd9r2rd7TfU0b2EX?= =?us-ascii?Q?nmGrjoVftYBqOZQVirdAevpjTmyrOT7nl/vz7lQRPCcCUAc8uG6u4L+9fQz4?= =?us-ascii?Q?YdQABYwqua03BwlBDUlN2yBnycNKttJMTnJiHf3PfoLnLtNtDO7zZHevPruK?= =?us-ascii?Q?DXtenU1gY8IEFDK8QSyV655hNMhe6nKire2nVTWqJ8upA+l0e7rnsmK3HKPI?= =?us-ascii?Q?V+gbZg1SDAjyqw9V5d3CH2Hk+bzOx6g48ePs8QZ0ZsK6wuryExPDL/0Q8lJw?= =?us-ascii?Q?5S6Llm1WiwiTl8BRPQf6xdbFPjZpoG5rlKwKnTFTeVbbavSpuv5EhMP4HW96?= =?us-ascii?Q?DDoN3+i+Dgnv3aWd+anyO6jAu0RG2SzaVRo511U66Pw+3YH7+S39NkZ1zfqj?= =?us-ascii?Q?vrrdT9J3R6pOAo61fUVZhxGfneiBPvl+rQ8QfCp9Ztm2RPKLONdbEbaEMJAQ?= =?us-ascii?Q?bwmhQHnLezvZGKY7EJWW4h+UhjkNKLku91lPSRCnEyQMNmEjwrejGqDJ6PZ6?= =?us-ascii?Q?Nh/JG6yl8FB265TBYg/z+RZ6x+W654Q6Pk5+J4KaaC4jt8/74ABqq7Vhvt48?= =?us-ascii?Q?A4G5awVC2bKau7Ia+P3jiFByYF7zudk+muu/yNFA6VqTnu2yu5qogRNZUdxJ?= =?us-ascii?Q?mwar78VXcBL77btEixqHAB3mDhxgVlLlXZ7SZY2VE8z4C6s/7GJEerIsYXPP?= =?us-ascii?Q?mQHa1gldrt+54+q7K3KjR0uRWbDW7ipGjzqYONSCmyMZaOAdB96wqpVm9lsY?= =?us-ascii?Q?6B2iuM96keFe4enL9Zz/D5k3vC9x9GsCy91w44qMfugzaMRD1hJ6Rc+HyaXf?= =?us-ascii?Q?eOrkd9FUUxSw9IZFFjs+zfNmLEK5dkphTGJ3B3DUobdzQDrc3TDdAt8s6YJc?= =?us-ascii?Q?8MDuNwzJzO2Cat/fNb66Z7BtbgngQHVKe5Qn8phYcu3FRYyMby76eJJU+PUl?= =?us-ascii?Q?obqoaEX3Nk7JaVSJA9HjwbzY9CCnMKcwKp3cprww/PRcYoLmPNa2Hj4LvhEb?= =?us-ascii?Q?jcW98CcRM6+ihMOOILoYHOKxZBPQjHwltFElpxIeEmMyd9oqRAKqWn4cH5nG?= =?us-ascii?Q?jWD9djyu3GmjR1aBzTSjUiHKkGsNelv0W2FgpdoYvq4alH7l+IQMaHRl5Q+G?= =?us-ascii?Q?T/MQWM8F8mFhDduUJE1a2qsXTemEeKFnyvWDcaTuBDqxYk9KhQZxZ2/WI2Ie?= =?us-ascii?Q?B4YFnXXzseu8w5wWK2WyW6HnL/mi6YNATMbFCgmm?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: c01f4a5c-3f45-4cf9-169a-08dc6a787016 X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6458.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2024 07:21:09.1883 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iFHCONp4U4h+SJ8IJ/9SNhqIwKJVQ8Fv4w9jYtyaXBy0sVBhlidgMexTKngIUPexiuolRBSOoRlA+1tkhT+NaQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB8921 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 02 May 2024 00:21:12 -0700 Resent-From: AbdulLateef.Attar@amd.com Reply-To: devel@edk2.groups.io,AbdulLateef.Attar@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: i6qnMCdQoe3QdXzufrzK9UgIx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=Ag3903JY; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Pierre Gondois and Sami Mujawar, =C2=A0=C2=A0=C2=A0 Could you please review below patch set and consider fo= r upcoming=20 stable release ? There are non-disruptive patches and won't impact existing ARM platform. Thanks AbduL On 29-04-2024 11:33, Abdul Lateef Attar wrote: > PR: https://github.com/tianocore/edk2/pull/5500/ > V4: delta changes > Added X64 arch specific MADT table generator. > V3: delta changes > Restructure the code as the review comments. > Added sanity check for WSMT flags. > Added CM object for HPET base address. > V2: delta changes > Addressed review comments > Adds ACPI HPET table to add HPET to ACPI namespace > V1: > Adds new space for ArchNameSpaceObjects. > Adds generic FADT table generator. > Adds generic HPET table generator. > Adds generic WSMT table generator. > > Cc: Sami Mujawar > Cc: Pierre Gondois > Cc: Abdul Lateef Attar > > Abdul Lateef Attar (5): > DynamicTablesPkg: Adds ACPI FADT Table generator > DynamicTablesPkg: Adds ACPI HPET Table generator > DynamicTablesPkg: Adds ACPI WSMT Table generator > DynamicTablesPkg: Adds ACPI SSDT HPET Table generator > DynamicTablesPkg: Adds X64 arch MADT Table generator > > DynamicTablesPkg/DynamicTables.dsc.inc | 22 +- > DynamicTablesPkg/DynamicTablesPkg.ci.yaml | 4 +- > DynamicTablesPkg/Include/AcpiTableGenerator.h | 4 + > .../Include/ArchNameSpaceObjects.h | 237 ++++++ > .../Include/ConfigurationManagerObject.h | 7 + > .../Include/X64NameSpaceObjects.h | 48 ++ > .../Library/Acpi/AcpiFadtLib/AcpiFadtLib.inf | 36 + > .../Library/Acpi/AcpiFadtLib/Arm/FadtUpdate.c | 39 + > .../Library/Acpi/AcpiFadtLib/FadtGenerator.c | 745 ++++++++++++++++++ > .../Library/Acpi/AcpiFadtLib/FadtUpdate.h | 26 + > .../Library/Acpi/AcpiFadtLib/X64/FadtUpdate.c | 32 + > .../Library/Acpi/AcpiHpetLib/AcpiHpetLib.inf | 31 + > .../Library/Acpi/AcpiHpetLib/HpetGenerator.c | 246 ++++++ > .../Acpi/AcpiSsdtHpetLib/AcpiSsdtHpetLib.inf | 32 + > .../Acpi/AcpiSsdtHpetLib/SsdtHpetGenerator.c | 295 +++++++ > .../Library/Acpi/AcpiWsmtLib/AcpiWsmtLib.inf | 30 + > .../Library/Acpi/AcpiWsmtLib/WsmtGenerator.c | 243 ++++++ > .../X64/AcpiMadtLibX64/AcpiMadtLibX64.inf | 27 + > .../Acpi/X64/AcpiMadtLibX64/MadtGenerator.c | 375 +++++++++ > 19 files changed, 2477 insertions(+), 2 deletions(-) > create mode 100644 DynamicTablesPkg/Include/ArchNameSpaceObjects.h > create mode 100644 DynamicTablesPkg/Include/X64NameSpaceObjects.h > create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiFadtLib/AcpiFadtLi= b.inf > create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiFadtLib/Arm/FadtUp= date.c > create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiFadtLib/FadtGenera= tor.c > create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiFadtLib/FadtUpdate= .h > create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiFadtLib/X64/FadtUp= date.c > create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiHpetLib/AcpiHpetLi= b.inf > create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiHpetLib/HpetGenera= tor.c > create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiSsdtHpetLib/AcpiSs= dtHpetLib.inf > create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiSsdtHpetLib/SsdtHp= etGenerator.c > create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiWsmtLib/AcpiWsmtLi= b.inf > create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiWsmtLib/WsmtGenera= tor.c > create mode 100644 DynamicTablesPkg/Library/Acpi/X64/AcpiMadtLibX64/Acp= iMadtLibX64.inf > create mode 100644 DynamicTablesPkg/Library/Acpi/X64/AcpiMadtLibX64/Mad= tGenerator.c > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118500): https://edk2.groups.io/g/devel/message/118500 Mute This Topic: https://groups.io/mt/105796049/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-