[PATCH v1 1/1] StandaloneMmPkg: Fix 'missing header' warning

[PATCH v1 1/1] StandaloneMmPkg: Fix 'missing header' warning

[Sami Mujawar]

The Basetools scripts have been updated to report
warnings if header files are not listed in the
[Sources] section of the inf files.

Update StandaloneMmCpu.inf to include the header
file StandaloneMmCpu.h to fix the warning.

CC: Achin Gupta <achin.gupta@arm.com>
CC: Jiewen Yao <jiewen.yao@intel.com>
CC: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---

The changes can be seen at:
https://github.com/samimujawar/edk2/tree/696_stmm_fix_include_warning_v1

Notes:
    v1:
      - Fix missing header warnings                                 [SAMI]

 StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf
index 5cc4915806db72e36da6cec85d5f690c0c958f16..e8f0c97f4513dec261800f49571e02c9e1e427ce 100644
--- a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf
+++ b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf
@@ -4,7 +4,7 @@
 #
 #  Copyright (c) 2009, Apple Inc. All rights reserved.<BR>
 #  Copyright (c) 2016 HP Development Company, L.P.
-#  Copyright (c) 2017 - 2018, ARM Limited. All rights reserved.
+#  Copyright (c) 2017 - 2019, ARM Limited. All rights reserved.
 #
 #  SPDX-License-Identifier: BSD-2-Clause-Patent
 #
@@ -21,6 +21,7 @@ [Defines]
 
 [Sources]
   StandaloneMmCpu.c
+  StandaloneMmCpu.h
   EventHandle.c
 
 [Packages]
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: Fix 'missing header' warning

[Philippe Mathieu-Daudé]

On 11/21/19 4:38 PM, Sami Mujawar wrote:
> The Basetools scripts have been updated to report
> warnings if header files are not listed in the
> [Sources] section of the inf files.
> 
> Update StandaloneMmCpu.inf to include the header
> file StandaloneMmCpu.h to fix the warning.
> 
> CC: Achin Gupta <achin.gupta@arm.com>
> CC: Jiewen Yao <jiewen.yao@intel.com>
> CC: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
> ---
> 
> The changes can be seen at:
> https://github.com/samimujawar/edk2/tree/696_stmm_fix_include_warning_v1
> 
> Notes:
>      v1:
>        - Fix missing header warnings                                 [SAMI]
> 
>   StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf
> index 5cc4915806db72e36da6cec85d5f690c0c958f16..e8f0c97f4513dec261800f49571e02c9e1e427ce 100644
> --- a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf
> +++ b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf
> @@ -4,7 +4,7 @@
>   #
>   #  Copyright (c) 2009, Apple Inc. All rights reserved.<BR>
>   #  Copyright (c) 2016 HP Development Company, L.P.
> -#  Copyright (c) 2017 - 2018, ARM Limited. All rights reserved.
> +#  Copyright (c) 2017 - 2019, ARM Limited. All rights reserved.
>   #
>   #  SPDX-License-Identifier: BSD-2-Clause-Patent
>   #
> @@ -21,6 +21,7 @@ [Defines]
>   
>   [Sources]
>     StandaloneMmCpu.c
> +  StandaloneMmCpu.h
>     EventHandle.c
>   
>   [Packages]
> 

Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>

Re: [PATCH v1 1/1] StandaloneMmPkg: Fix 'missing header' warning

[Yao, Jiewen]

Reviewed-by: Jiewen.yao@intel.com

> -----Original Message-----
> From: Sami Mujawar <sami.mujawar@arm.com>
> Sent: Thursday, November 21, 2019 11:38 PM
> To: devel@edk2.groups.io
> Cc: Sami Mujawar <sami.mujawar@arm.com>; achin.gupta@arm.com; Yao,
> Jiewen <jiewen.yao@intel.com>; supreeth.venkatesh@arm.com;
> Matteo.Carlini@arm.com; Laura.Moretta@arm.com; nd@arm.com
> Subject: [PATCH v1 1/1] StandaloneMmPkg: Fix 'missing header' warning
> 
> The Basetools scripts have been updated to report
> warnings if header files are not listed in the
> [Sources] section of the inf files.
> 
> Update StandaloneMmCpu.inf to include the header
> file StandaloneMmCpu.h to fix the warning.
> 
> CC: Achin Gupta <achin.gupta@arm.com>
> CC: Jiewen Yao <jiewen.yao@intel.com>
> CC: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
> ---
> 
> The changes can be seen at:
> https://github.com/samimujawar/edk2/tree/696_stmm_fix_include_warning_v
> 1
> 
> Notes:
>     v1:
>       - Fix missing header warnings                                 [SAMI]
> 
>  StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf
> | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git
> a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.i
> nf
> b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.i
> nf
> index
> 5cc4915806db72e36da6cec85d5f690c0c958f16..e8f0c97f4513dec261800f4957
> 1e02c9e1e427ce 100644
> ---
> a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.i
> nf
> +++
> b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.i
> nf
> @@ -4,7 +4,7 @@
>  #
>  #  Copyright (c) 2009, Apple Inc. All rights reserved.<BR>
>  #  Copyright (c) 2016 HP Development Company, L.P.
> -#  Copyright (c) 2017 - 2018, ARM Limited. All rights reserved.
> +#  Copyright (c) 2017 - 2019, ARM Limited. All rights reserved.
>  #
>  #  SPDX-License-Identifier: BSD-2-Clause-Patent
>  #
> @@ -21,6 +21,7 @@ [Defines]
> 
>  [Sources]
>    StandaloneMmCpu.c
> +  StandaloneMmCpu.h
>    EventHandle.c
> 
>  [Packages]
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
>