From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web11.25682.1574351645696296340 for ; Thu, 21 Nov 2019 07:54:05 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=BHUwwm0t; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574351644; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oYzJJdu1CtlDLE3CnLWjvmsv1ro/C1iWBFBSBSuT7Mo=; b=BHUwwm0tVvysIENDLxlLdTAsNsBNvYzT6/XTJChHcfg6/VILUllXAbfN8cNZy2g/Y2B1yK ILTmAYRQy5z6WZpMe4ZzQj7r8/U+XjUZ+b4PD1BatPlmZ8GcRqpMDCXAa1bjK9SFavQzJz W/2cZhUCupoNeIIHlil1NaM4XdVEvBU= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-311-BOdzzF0gPBaPFt9wsd_TJA-1; Thu, 21 Nov 2019 10:54:02 -0500 Received: by mail-wr1-f72.google.com with SMTP id y3so2283691wrm.12 for ; Thu, 21 Nov 2019 07:54:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7JvyfSGF1zqoKExz3L4j9gyA2k/A2DLSUWQGtLKLUQ4=; b=aPIBH/tP49Tsl0WY8gsDlNzbacVHskobLBb+Tq4e0OKH/KIrlKOnOI41M5l2Bm5HxD zy4+QdAC9idWDLH8NXq22MRDT3ICtgM+YNWnrC1ridbu4y3SNIbN1XKLlb9h3sKPOKtF GSnp6g6HsAIO1wdVRc/OcDFLlZ4JEk7si4CYWx6JpMmaGKi4jFRw/snyjRIkuB1Bhj77 WPq+1MC4ylIs9kx83Ys6tM0KIn6LvmGa2tuyt3aYu4rSZ+FmEJBtFBqF3m0MKdZ09PSB Lq8zYF9Zwsu/WUjs1rwVkrvXbFpNkcVHnr1Dzkr23qZlPORkc4KlLtGHZv69FFX1hprL Nqiw== X-Gm-Message-State: APjAAAWh+kPUD1EzXpOXq3CUpnKmgn7KRrytraCYYOn5VRKLBYpMSyLp JDGvH6UMna6mjrhFm/15/QQWC5koo4O7Y6/zJJoLRyziQkhYdOC93Mp+4rdbhkNuOlXQYUDfxhz rxdH6YFYDIrYIjA== X-Received: by 2002:adf:e545:: with SMTP id z5mr11403179wrm.321.1574351641344; Thu, 21 Nov 2019 07:54:01 -0800 (PST) X-Google-Smtp-Source: APXvYqxUZ9Rh86DHEt4KSVtiEWtu4PLqSVWV/NfMUxkMu3ri8Q6FmxPaX+Li8YTfBU6PU/8u1XF0CA== X-Received: by 2002:adf:e545:: with SMTP id z5mr11403153wrm.321.1574351641099; Thu, 21 Nov 2019 07:54:01 -0800 (PST) Return-Path: Received: from [192.168.1.35] (131.red-88-21-102.staticip.rima-tde.net. [88.21.102.131]) by smtp.gmail.com with ESMTPSA id y16sm3885461wro.25.2019.11.21.07.53.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Nov 2019 07:54:00 -0800 (PST) Subject: Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: Fix 'missing header' warning To: devel@edk2.groups.io, sami.mujawar@arm.com Cc: achin.gupta@arm.com, jiewen.yao@intel.com, supreeth.venkatesh@arm.com, Matteo.Carlini@arm.com, Laura.Moretta@arm.com, nd@arm.com References: <20191121153828.11096-1-sami.mujawar@arm.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <7d2beda4-d631-e9f1-ba04-f663813e52e0@redhat.com> Date: Thu, 21 Nov 2019 16:53:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191121153828.11096-1-sami.mujawar@arm.com> X-MC-Unique: BOdzzF0gPBaPFt9wsd_TJA-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: quoted-printable On 11/21/19 4:38 PM, Sami Mujawar wrote: > The Basetools scripts have been updated to report > warnings if header files are not listed in the > [Sources] section of the inf files. >=20 > Update StandaloneMmCpu.inf to include the header > file StandaloneMmCpu.h to fix the warning. >=20 > CC: Achin Gupta > CC: Jiewen Yao > CC: Supreeth Venkatesh > Signed-off-by: Sami Mujawar > --- >=20 > The changes can be seen at: > https://github.com/samimujawar/edk2/tree/696_stmm_fix_include_warning_v1 >=20 > Notes: > v1: > - Fix missing header warnings [SAM= I] >=20 > StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf | 3= ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMm= Cpu.inf b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.i= nf > index 5cc4915806db72e36da6cec85d5f690c0c958f16..e8f0c97f4513dec261800f495= 71e02c9e1e427ce 100644 > --- a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf > +++ b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf > @@ -4,7 +4,7 @@ > # > # Copyright (c) 2009, Apple Inc. All rights reserved.
> # Copyright (c) 2016 HP Development Company, L.P. > -# Copyright (c) 2017 - 2018, ARM Limited. All rights reserved. > +# Copyright (c) 2017 - 2019, ARM Limited. All rights reserved. > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -21,6 +21,7 @@ [Defines] > =20 > [Sources] > StandaloneMmCpu.c > + StandaloneMmCpu.h > EventHandle.c > =20 > [Packages] >=20 Reviewed-by: Philippe Mathieu-Daude