From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Mon, 12 Aug 2019 07:01:40 -0700 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AFC15316E531; Mon, 12 Aug 2019 14:01:39 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-247.ams2.redhat.com [10.36.116.247]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8DC8B29340; Mon, 12 Aug 2019 14:01:38 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v4 15/15] MdePkg/UefiRuntimeLib: Change the comment To: devel@edk2.groups.io, zhichao.gao@intel.com Cc: Michael D Kinney , Liming Gao References: <20190812030758.10324-1-zhichao.gao@intel.com> <20190812030758.10324-16-zhichao.gao@intel.com> From: "Laszlo Ersek" Message-ID: <7d3e6732-0b39-3c61-ed8e-f6953cc3445f@redhat.com> Date: Mon, 12 Aug 2019 16:01:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190812030758.10324-16-zhichao.gao@intel.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Mon, 12 Aug 2019 14:01:39 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi, On 08/12/19 05:07, Gao, Zhichao wrote: > Change the comment of EfiResetSystem base on the > UEFI spec 2.8 > > Cc: Michael D Kinney > Cc: Liming Gao > Signed-off-by: Zhichao Gao > --- > MdePkg/Library/UefiRuntimeLib/RuntimeLib.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/MdePkg/Library/UefiRuntimeLib/RuntimeLib.c b/MdePkg/Library/UefiRuntimeLib/RuntimeLib.c > index 933e0099ceed..28cbf493b665 100644 > --- a/MdePkg/Library/UefiRuntimeLib/RuntimeLib.c > +++ b/MdePkg/Library/UefiRuntimeLib/RuntimeLib.c > @@ -218,10 +218,10 @@ EfiGoneVirtual ( > @param DataSizeThe size, in bytes, of ResetData. > @param ResetData For a ResetType of EfiResetCold, EfiResetWarm, or EfiResetShutdown the data buffer starts with a > Null-terminated Unicode string, optionally followed by additional binary data. The string is a > - description that the caller may use to further indicate the reason for the system reset. ResetData > - is only valid if ResetStatus is something other then EFI_SUCCESS. This pointer must be a physical > - address. For a ResetType of EfiRestUpdate the data buffer also starts with a Null-terminated string > - that is followed by a physical VOID * to an EFI_CAPSULE_HEADER. > + description that the caller may use to further indicate the reason for the system reset. This > + pointer must be a physical address. For a ResetType of EfiResetPlatformSpecific the data buffer > + also starts with a Null-terminated string that is followed by an EFI_GUID that describes the > + specific type of reset to perform. > > **/ > VOID > given that UefiRuntimeLib is a single-instance library class -- that is, my understanding is that we never plan to introduce a different instance for this class --, I would suggest fusing the following two patches into one: - [PATCH v4 14/15] MdePkg/UefiRuntimeLib.h: Change the comment - [PATCH v4 15/15] MdePkg/UefiRuntimeLib: Change the comment Also, can we please use a better (more specific) subject line? Obviously I'm not an MdePkg maintainer (or even reviewer), so I defer to Liming and Mike. Thanks Laszlo