From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web11.88385.1673620843755884674 for ; Fri, 13 Jan 2023 06:40:43 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=fS9BDUfV; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: quicinc.com, ip: 205.220.180.131, mailfrom: quic_rcran@quicinc.com) Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30DDxGrN027149; Fri, 13 Jan 2023 14:40:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=lchbaDU8KGUStmzvXKQCoGhwMaxrJcIJkPBE2SK7HWM=; b=fS9BDUfV5FKJFOR6boaMWpo9e4yFby/rnCxKLNTFwIBx3h+tFleeIZyRBrPRdE+QQcAk OXARoxZdR9JjHDY4OHDc/aeTTBsbnoCLhHBrubmqdRQ6IzjaBwxXh52UQrLnbTcza4AB 5L4Md7la5IX6v6TpbbP//vDrTApOZKeTWAQyyGwKBTpRu+aInih70x0t7033Fd4E1umg tB1KyKhwjNInljG48nk+ACdXiB/kre6RWIWx9O3iqZu877l+t1pNnMajwthGz88ancLU 6q3+bo1ovIi6nNrFcFhxrxuFxuHoOyBYZ5dogjqIb43ENJSikb2pOr0w9cOEeIsaU+JL QQ== Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3n2fwpuc95-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 13 Jan 2023 14:40:41 +0000 Received: from nasanex01b.na.qualcomm.com (nasanex01b.na.qualcomm.com [10.46.141.250]) by NASANPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 30DEeeA3032342 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 13 Jan 2023 14:40:40 GMT Received: from [10.110.125.126] (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Fri, 13 Jan 2023 06:40:39 -0800 Message-ID: <7d401f29-56d9-d754-88a6-684ce329a727@quicinc.com> Date: Fri, 13 Jan 2023 07:40:38 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] AmpereAltraPkg: Update ArmPlatformLib to work with changed ARM_CORE_INFO To: , CC: , , , Tinh Nguyen References: <20230113042126.3107135-1-nhi@os.amperecomputing.com> From: "Rebecca Cran" In-Reply-To: <20230113042126.3107135-1-nhi@os.amperecomputing.com> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: 4OEjmGwwZ0Dk1twL9X1G7Q9yu0q4KWuo X-Proofpoint-ORIG-GUID: 4OEjmGwwZ0Dk1twL9X1G7Q9yu0q4KWuo X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.923,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-13_06,2023-01-13_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 clxscore=1011 spamscore=0 impostorscore=0 malwarescore=0 mlxlogscore=931 phishscore=0 bulkscore=0 suspectscore=0 adultscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301130096 Content-Language: en-US Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit On 1/12/23 21:21, Nhi Pham via groups.io wrote: > +// > +// MPIDR manipulation > +// > +#define AC01_GET_MPIDR(SocketId, ClusterId, CoreId) \ > + (((SocketId) << 32) | ((ClusterId) << 16) | ((CoreId) << 8)) > +#define AC01_GET_SOCKET_ID(Mpidr) (((Mpidr) & ARM_CORE_AFF3) >> 32) > +#define AC01_GET_CLUSTER_ID(Mpidr) (((Mpidr) & ARM_CORE_AFF2) >> 16) > +#define AC01_GET_CORE_ID(Mpidr) (((Mpidr) & ARM_CORE_AFF1) >> 8) > + Ideally, this should go in ArmPkg/Include/Library/ArmLib.h, but I'm not sure how we should handle the older format where the the core was in the first 8 bits. -- Rebecca Cran