From: "Nhi Pham via groups.io" <nhi=os.amperecomputing.com@groups.io>
To: Ard Biesheuvel <ardb+git@google.com>, devel@edk2.groups.io
Cc: Ard Biesheuvel <ardb@kernel.org>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Chuong Tran <chuong@os.amperecomputing.com>,
Rebecca Cran <rebecca@os.amperecomputing.com>
Subject: Re: [edk2-devel] [PATCH edk2-platforms 07/11] Silicon/Ampere: Switch to generic ArmPsciResetSystemLib
Date: Fri, 26 Jul 2024 16:06:44 +0700 [thread overview]
Message-ID: <7d5ba2be-ce63-4238-88e3-6d542cfba3c5@os.amperecomputing.com> (raw)
In-Reply-To: <20240725082502.1566409-8-ardb+git@google.com>
Thanks Ard for the patch.
Reviewed-by: Nhi Pham <nhi@os.amperecomputing.com>
Regards,
Nhi
On 7/25/2024 3:24 PM, Ard Biesheuvel wrote:
> From: Ard Biesheuvel <ardb@kernel.org>
>
> The PSCI reset libraries in ArmPkg are being consolidated into a single
> one to reduce the maintenance burden of having multiple libraries doing
> the same thing in a slightly different way.
>
> Move this platform to the generic ArmPsciResetSystemLib, and drop the
> dependency on ArmSmcPsciResetSystemLib, which is deprecated and will be
> removed.
>
> Cc: Nhi Pham <nhi@os.amperecomputing.com>
> Cc: Chuong Tran <chuong@os.amperecomputing.com>
> Cc: Rebecca Cran <rebecca@os.amperecomputing.com>
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> ---
> Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
> index fb170d436d00..977e4c4c238d 100644
> --- a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
> +++ b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
> @@ -73,7 +73,8 @@ [LibraryClasses.common]
> ArmPlatformStackLib|ArmPlatformPkg/Library/ArmPlatformStackLib/ArmPlatformStackLib.inf
> ArmSmcLib|ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf
> ArmGenericTimerCounterLib|ArmPkg/Library/ArmGenericTimerPhyCounterLib/ArmGenericTimerPhyCounterLib.inf
> - ResetSystemLib|ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf
> + ResetSystemLib|ArmPkg/Library/ArmPsciResetSystemLib/ArmPsciResetSystemLib.inf
> + ArmMonitorLib|ArmPkg/Library/ArmMonitorLib/ArmMonitorLib.inf
>
> #
> # Ampere Altra specific Libraries
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120045): https://edk2.groups.io/g/devel/message/120045
Mute This Topic: https://groups.io/mt/107558451/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-07-26 9:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-25 8:24 [edk2-devel] [PATCH edk2-platforms 00/11] Phase out ArmSmcPsciResetSystemLib Ard Biesheuvel via groups.io
2024-07-25 8:24 ` [edk2-devel] [PATCH edk2-platforms 01/11] Platform,Silicon: Fix line endings Ard Biesheuvel via groups.io
2024-07-25 8:24 ` [edk2-devel] [PATCH edk2-platforms 02/11] Silicon/SynQuacer: Fix CLANGDWARF build Ard Biesheuvel via groups.io
2024-07-25 8:24 ` [edk2-devel] [PATCH edk2-platforms 03/11] Platform/AMD/Styx: Switch to generic ArmPsciResetSystemLib Ard Biesheuvel via groups.io
2024-07-25 8:24 ` [edk2-devel] [PATCH edk2-platforms 04/11] Platform/ARM: " Ard Biesheuvel via groups.io
2024-07-25 10:12 ` Sami Mujawar
2024-07-25 8:24 ` [edk2-devel] [PATCH edk2-platforms 05/11] Platform/SbsaQemu: " Ard Biesheuvel via groups.io
2024-07-25 8:24 ` [edk2-devel] [PATCH edk2-platforms 06/11] Platform/SynQuacer: " Ard Biesheuvel via groups.io
2024-07-25 8:24 ` [edk2-devel] [PATCH edk2-platforms 07/11] Silicon/Ampere: " Ard Biesheuvel via groups.io
2024-07-26 9:06 ` Nhi Pham via groups.io [this message]
2024-07-25 8:24 ` [edk2-devel] [PATCH edk2-platforms 08/11] Silicon/HiSilicon: " Ard Biesheuvel via groups.io
2024-07-25 8:25 ` [edk2-devel] [PATCH edk2-platforms 09/11] Silicon/Armada7k8k: " Ard Biesheuvel via groups.io
2024-07-25 8:25 ` [edk2-devel] [PATCH edk2-platforms 10/11] Silicon/NxpQoriqLs: " Ard Biesheuvel via groups.io
2024-07-25 8:25 ` [edk2-devel] [PATCH edk2-platforms 11/11] Silicon/Phytium: " Ard Biesheuvel via groups.io
2024-07-25 9:49 ` [edk2-devel] [PATCH edk2-platforms 00/11] Phase out ArmSmcPsciResetSystemLib Leif Lindholm
2024-07-25 10:53 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d5ba2be-ce63-4238-88e3-6d542cfba3c5@os.amperecomputing.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox