From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by mx.groups.io with SMTP id smtpd.web10.12910.1624992251206894557
 for <devel@edk2.groups.io>;
 Tue, 29 Jun 2021 11:44:11 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=none, err=permanent DNS error (domain: linux.intel.com, ip: 192.55.52.120, mailfrom: maciej.rabeda@linux.intel.com)
X-IronPort-AV: E=McAfee;i="6200,9189,10030"; a="206389709"
X-IronPort-AV: E=Sophos;i="5.83,309,1616482800"; 
   d="scan'208";a="206389709"
Received: from orsmga007.jf.intel.com ([10.7.209.58])
  by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2021 11:44:09 -0700
X-IronPort-AV: E=Sophos;i="5.83,309,1616482800"; 
   d="scan'208";a="447149956"
Received: from mrabeda-mobl.ger.corp.intel.com (HELO [10.214.220.209]) ([10.214.220.209])
  by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2021 11:44:07 -0700
Subject: Re: [edk2-devel] [PATCH v2 0/6] NetworkPkg/IScsiDxe: support SHA256 in CHAP
To: devel@edk2.groups.io, lersek@redhat.com
Cc: Jiaxin Wu <jiaxin.wu@intel.com>,
 =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= <philmd@redhat.com>,
 Siyuan Fu <siyuan.fu@intel.com>
References: <20210629163337.14120-1-lersek@redhat.com>
From: "Maciej Rabeda" <maciej.rabeda@linux.intel.com>
Message-ID: <7d90e66a-8fb7-3772-3aa2-013c8d4a38fb@linux.intel.com>
Date: Tue, 29 Jun 2021 20:44:03 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210629163337.14120-1-lersek@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: pl

Thanks, Laszlo. I really like moving the condition out of 'if' clause in 
IScsiCHAPAuthTarget :)

For the patchset:
Reviewed-by: Maciej Rabeda <maciej.rabeda@linux.intel.com>

On 29-Jun-21 18:33, Laszlo Ersek wrote:
> Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=3355
> Repo:     https://pagure.io/lersek/edk2.git
> Branch:   iscsi_sha256_bz3355_v2 (at commit 73b92e85b4de)
> CI:       https://github.com/tianocore/edk2/pull/1772
>
> v1 was posted at:
>
> * [edk2-devel] [PATCH 0/6] NetworkPkg/IScsiDxe: support SHA256 in CHAP
>
>    Message-Id: <20210608130652.2434-1-lersek@redhat.com>
>    https://listman.redhat.com/archives/edk2-devel-archive/2021-June/msg00331.html
>    https://edk2.groups.io/g/devel/message/76213
>    https://bugzilla.tianocore.org/show_bug.cgi?id=3355#c3
>
> v2 addresses the v1 review feedback. Please see the Notes section on
> every patch.
>
> v2 has been retested, with results identical to those of v1. (Please see
> the v1 blurb for details.)
>
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
>
> Thanks,
> Laszlo
>
> Laszlo Ersek (6):
>    NetworkPkg/IScsiDxe: re-set session-level authentication state before
>      login
>    NetworkPkg/IScsiDxe: add horizontal whitespace to IScsiCHAP files
>    NetworkPkg/IScsiDxe: distinguish "maximum" and "selected" CHAP digest
>      sizes
>    NetworkPkg/IScsiDxe: support multiple hash algorithms for CHAP
>    NetworkPkg/IScsiDxe: support SHA256 in CHAP
>    NetworkPkg: introduce the NETWORK_ISCSI_MD5_ENABLE feature test macro
>
>   NetworkPkg/IScsiDxe/IScsiCHAP.c        | 204 ++++++++++++++++----
>   NetworkPkg/IScsiDxe/IScsiCHAP.h        |  95 +++++++--
>   NetworkPkg/IScsiDxe/IScsiDriver.c      |   2 +
>   NetworkPkg/IScsiDxe/IScsiProto.c       |  21 ++
>   NetworkPkg/NetworkBuildOptions.dsc.inc |   2 +-
>   NetworkPkg/NetworkDefines.dsc.inc      |  20 ++
>   6 files changed, 293 insertions(+), 51 deletions(-)
>
>
> base-commit: b37cfdd2807181aed2fee1e17bd7ec1190db266a