From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (NAM02-SN1-obe.outbound.protection.outlook.com [40.107.96.87]) by mx.groups.io with SMTP id smtpd.web12.22259.1631487351011522398 for ; Sun, 12 Sep 2021 15:55:51 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=n1+XmnS1; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.96.87, mailfrom: brijesh.singh@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CqIZfeiFP93XLFGb1GW10/hExjiN4v/K/cQTB4OEGx6i1l/BnnLMDo5XKGLgLAT+MOeeTvHyQJa147+U7KDUlrputb2kb7KfjASqmlTVXia255mB7ROc9fMQkVgaU6UpoDv0simhMDcTf3M65IDicd22m6+vEGeqzW1iprnTA1cs/Q7cQ+llzAQsVpSNrF6ZNPNn3NhY+yEtys9hd2N8IonMpSs8sbn/k73iROCCyu+Jl2faVLyDCbS6I47CTyzhqyugdTeaaYK0f2uDf7rNT7+DHcP79y8TlHFdKfo6qrPeKDDoo5k8V7B4ItQlHx2IH7tM88u3UF46tp23pcHTAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=VYSle71f0h8QvxKNDns3AzZziRbm3S+N6D1qsisuKU0=; b=YSQVS9cNwM/pJWBkxuvoF3wmkDffLZXazKt4FFY/P1t0ub/8JL/n1yD+NUGrehKRG3a22ZiTKmyn6IXq42dVppFM4MDuh++hEGMUVs5Q6cL2Vm7YvNbf9Yd462biCgz8C7mjzkNTXA0KYRoDh2UO6ABiFdreYL9teuJzsHEEuI5IV/DA+BXdHOb9qo5QWI7ogxw/rU1F6akQmvLU6ilKGcpaH4QTN5YhSMVnGr7dlY/1Is6U74IatXczQTBeVvvlb9aZFzF/txzjIgAWy+YQ44KJoZDiRm71Wlx7l8oKOR+w1lGrwpz60IkeRAkCz7Opl7CdgD3VHolE0gu6HnCC8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VYSle71f0h8QvxKNDns3AzZziRbm3S+N6D1qsisuKU0=; b=n1+XmnS1ZHgbVZy8oGadm6hQyCdpfEaDG1ScvXJV75I382YjYPd1zW+Lo3I9rxPWLzC0YSnHIU7JxCQtvI/glDPACLhZi7U+S9RI1dhEnCYSH3WWjQcqHim+W+13TYZ9i3nrFS3gG2qX5dSbtcaRsCxJq1jBukHxyZ84cCAswCI= Authentication-Results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=amd.com; Received: from SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) by SN1PR12MB2416.namprd12.prod.outlook.com (2603:10b6:802:2f::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.17; Sun, 12 Sep 2021 22:55:48 +0000 Received: from SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::78b7:7336:d363:9be3]) by SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::78b7:7336:d363:9be3%6]) with mapi id 15.20.4500.018; Sun, 12 Sep 2021 22:55:47 +0000 Subject: Re: [PATCH v6 00/29] Add AMD Secure Nested Paging (SEV-SNP) support To: "Yao, Jiewen" , "devel@edk2.groups.io" Cc: James Bottomley , "Xu, Min M" , Tom Lendacky , "Justen, Jordan L" , Ard Biesheuvel , Erdem Aktas , Michael Roth , Gerd Hoffmann References: <20210901161646.24763-1-brijesh.singh@amd.com> From: "Brijesh Singh" Message-ID: <7d9bdf95-48d0-2952-72bf-aff42a0ef76c@amd.com> Date: Sun, 12 Sep 2021 17:55:46 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: X-ClientProxiedBy: SN2PR01CA0006.prod.exchangelabs.com (2603:10b6:804:2::16) To SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) Return-Path: brijesh.singh@amd.com MIME-Version: 1.0 Received: from Brijeshs-MacBook-Pro.local (70.112.153.56) by SN2PR01CA0006.prod.exchangelabs.com (2603:10b6:804:2::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Sun, 12 Sep 2021 22:55:47 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cee901e3-2f96-4451-b53d-08d9764075de X-MS-TrafficTypeDiagnostic: SN1PR12MB2416: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cfJ9G9KSBAX2yBTb+zQWVZdPfv2y5KLh4TX9VB+HycuFcVFGy8lh6N6eSVzzzU+FXmkqNRMft50jmkc2CT3ojVS1PcGG+zTKoDQ5ZFMN7PQPmDeTlXthRbip59SuNWTaJQb3Q4DdDRfBLFDlnzSeFrC460cY1sCLbNEXbNEbhxRmfww5e7VIqPnjJQFVwREdkhxd26Jwk0nOFba0EHCnBBXozzyGJ6gOFy6Gfv8X2ds7PeHnX64vm7cjVQhbBsvhp8c5TA9fsyWCXiWrIRx1WO/1lEEaySEepHe0nA49e5qPRPQ9awcx97EDkmlbGJDjLzxrK8B2USxvFi9/IEtUoiK9K5riem/FDnNI0YiU/fhE4EAZxgB92JzJHNCincNrO9KV4fJGuuEdi6ImXiUJJjO1DLHdueR7WgjrrcNfTucxNGc7nWzRwPizVSjjgPPM0pOZQsE5QlQQ6AvvxQ0l7pbU84Y7+bpCLIU1uvdACJhfJgugJvfqOKjxmUWaMzdSKYxaTvSY1rpOuS2V/QTnytr59Lo+UzQ2v7DR67u1B1VrEzfYp51hhIyWe39b2zdWwqcv+n7e9s8MTMSDvNa78Di2pdpjX96Qs79+uAl/4NGtrBnMRtkmjgtY2GpSRWc+89fHnmWLz/44Biy5f5qWP353b7zLoizadzt6w5kjuOQyY5koS15+EB/cKqKxOHhMqL6y/ebLggC1K4HuwisNd8TAcClI6UxYahA8UgB3v24= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2718.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(54906003)(110136005)(31696002)(52116002)(8676002)(8936002)(6486002)(44832011)(36756003)(956004)(2616005)(5660300002)(53546011)(6506007)(4326008)(186003)(66476007)(66946007)(316002)(508600001)(31686004)(2906002)(66556008)(86362001)(26005)(38100700002)(38350700002)(6512007)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eTkySDYxcm9OVlJJMVUwSTYxdGg5cWdNRUl2aW5lR08wRU81eUgvNVZTd0Fo?= =?utf-8?B?cnJHRHFiYzFCbTIweHBnTDY4VWRmV242VTI1R2lOL2QwUlJPR0hTZlFVVkMv?= =?utf-8?B?M2tFTE1UL2g3SVBRc2gzVmlmNFR0UTlrY0pQYXk5eFBLMkloQWQvV0huRGxY?= =?utf-8?B?RWVLTjVpVHdFRVNDZ0N1OHRPdzM5R3NHSitybktwRFljeXk1SFdBUzNXNjNB?= =?utf-8?B?b2p3aDVEMWM3aGdwNXJSMWpPaW1MbG9QTDdib3ZxU0gxN05CdnZPbzNncGdB?= =?utf-8?B?STB6ZEdXVnFSZTFpQUNJMUlMV2E1UGdiUk40blNhanMrVERmM2x2TFQycmh5?= =?utf-8?B?TWNSZ3JuM2QrRG5aaWVaenZFSDFwazI4UytYVWp1T2E1K2c2ck1zczRGV1Aw?= =?utf-8?B?VmUwUVJlZGNkYlkreERVYlBaaml5Tm0xMFJteGxYU09LWXByNmVUYnJ1cHFo?= =?utf-8?B?S0hobEZIc1hMTTVCOEtWSmVJTC9IdUMzK3RJR29jMFZkczhDdHBQRHcrbDc1?= =?utf-8?B?VlFXVUc2RUlVYVA1UzRoNW5QclNjeEt5bnRCa2t1TzkxTzBUS3E2eGtZZjlm?= =?utf-8?B?SXZEelpTd3FrT2hXSHN0VXdZOTU0aWhMbnpMcXR4SVNkWXlLRW8yRVpXelJt?= =?utf-8?B?Y0wxNnNmbE5NTHVEeklpdnc1ejBFdDFKeDRCSnUzdklsbjlzNzRsUkd0alZp?= =?utf-8?B?VGJ1cDRpT21HekUzR1VhcFdlemwrMTBrR2Z4aDBEbS9UYnFueU9SQUkrL0R0?= =?utf-8?B?bVBLNVV5UUpzbDFLU0tkakNPRkRUN1luNVdiTC9KemoxNWowNGc4U1U0ZjhB?= =?utf-8?B?K1JSSGthZVBJUFordE1HaFZXUStrdURRNzZDVjA4TEhadklxamhscXM2clNZ?= =?utf-8?B?RVZXNjlIV0tybFJZL3NOL2M4K2dzdERkRnBUUlVQcHVraXMwSGJJUTFWRmdW?= =?utf-8?B?MmFMYmdiMkQ1K25aeis5K29ianNzQXRQZjdTUkdjYmd0WmlWQU90cmVEeGJy?= =?utf-8?B?QzZ4WEthMjJwU1BZVkluVkRxQkFDZTFaYXA3SFRhRlpBYXRqZHlSSlR0UUQ3?= =?utf-8?B?YjQralk3TW1sRHZhMys1ZzdaOGNHSmRtM3NzU3BWMHNUV2w4b3piYXpqM0Fo?= =?utf-8?B?ZWhWWmZlcHNNZUNNM1hsSWpYaXNpLzJjZGxIakhKTFVhMG5kSjJDTnVoVnFq?= =?utf-8?B?Mnd5L28yQTRvcDZZTm81Z3ZTY1B3Q0dScDBoVnkwVHRHaStyMFRZTWNBQ0RO?= =?utf-8?B?blRNTDJCdFdDSCtOazVLbzZnektidEZmWjUrcERpVkNlZmgrcTA3amx6TUJy?= =?utf-8?B?dlpydSt5UXJZME5xTDJEbVFMNVpKeEZpUlppSlVRaU80bDhlK3d2dzZFajEy?= =?utf-8?B?cWJOM1NWeDNDeTBRTktYRk9ic08rL3BrMnh6M3I2U0ExTlp0ZzYrVzg0ZGx2?= =?utf-8?B?VHE0cGdBZ0JYNjRwanVXbXMyUWp0SXFrVU93SkRFY2JrQ1hDUmRuNXVqNTdp?= =?utf-8?B?dUM4LzdiWFFHNnVOajFUd2dIUlI5dkNRM0V4eWpYRm1ia3RCNUFrcHM5S0tw?= =?utf-8?B?UG56Uk90MlJuWXZ1Tmk5S0NmenBXT3dRenV5TkRnSktUZVhqRktmOGNoN3o5?= =?utf-8?B?ZTJacEoyOVNFTkllem9NVzNzZmpZV2NidWI4Qk4xUmVkenl2SEhxdFdZMlJE?= =?utf-8?B?OEZldEloK1hGWVU4NXZrc3ZONmU0SmI5aHRqN0xia2ltdm8vcTJQSGUyOHhE?= =?utf-8?Q?9k3ljgcM+U0aM5L7qM8uLYXe9xjYfz0pLPLk6Wl?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: cee901e3-2f96-4451-b53d-08d9764075de X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2021 22:55:47.8539 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: c3JCisJdb7/skUAn3D+gb4u+HRAz9e1MNIQVub0/VFZMl3lWEmpK3VCJ1Cv6IzFCHjXzOO3/hmIibJr9PtQPUw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB2416 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Hi Yao, I am going through implementing your feedback. I have covered most of it. But your comment on moving some of the changes from MpFunc.nasm to Sev.nasm may make code harder to read. It is mainly because the GPA registration and Topo check are not self-contained routines. They depend on some previous register states and need to jump to different paths based on the condition. All those jump are in generic AP init routines. As you can see, the changes in MpFunc.nasm are more petite, and if it's a big issue, we can revisit it later and devise a proposal to move the big chunk of generic code in a separate file then have TDX and SEV call into it. At that time, we can add OneTimeCall or OneTimeReturn macros etc., to jump between different files to make it more readable. Would you please let me know if that is acceptable? -Brijesh On 9/6/21 9:36 PM, Yao, Jiewen wrote: > > 0023-UefiCpuPkg-MpLib-add-support-to-register-GHCB-GPA-when-SEV-SNP-is-enabled > 1) See 0008. > 2) For MpFuncs.nasm, I recommend to move AmdSev specific initialization to a standalone file, such as Sev.nasm > > 0024-UefiCpuPkg-MpInitLib-use-BSP-to-do-extended-topology-check > See 0023 >