From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-x243.google.com (mail-pf0-x243.google.com [IPv6:2607:f8b0:400e:c00::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D0D3B21E3EA79 for ; Mon, 4 Sep 2017 08:09:10 -0700 (PDT) Received: by mail-pf0-x243.google.com with SMTP id k3so295715pfc.3 for ; Mon, 04 Sep 2017 08:11:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=r1FaeLH5DnwKwfauB4GrO5vV6LxqQctSOYXw0s+ZPgQ=; b=bptUR0Lih9Qyq1n/8xLlSYyKiJSFoIjvKg2V8AsndRddM2iYYBBbR4Ycy030LqfwGE pydOIPkY5lGS9DFILl0xiwuIsxSDoQMo/cukOmhd3AxCh/I1rPXyskARzKHnRc8i/5iY wJYmmUkvb9nANHcjFV8YXRcSITct89hpINthIB7LydBTaWj9NOVVA6qIV9UQ/allIXME z0kr1V/k3EY2VS/yW3tv8Mpf+jFwXvuHcASgOprzbnYLcjGgZq7cBkoDmAP6fDfxlQgv yfS1asuy4x0Xg4lFiwHbIOViU/SsrCouH1Sr7aOqnkCmwjgxQFs4QJg5RXv+mXqFBy7u RUgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=r1FaeLH5DnwKwfauB4GrO5vV6LxqQctSOYXw0s+ZPgQ=; b=tvNXQKR+5B8EObL4p7ataLB/t095ONZ0cszcIFSkYdRaFFpo/RaMOHoqXk0jIRADlZ BWLUqDRPPaw09RkhgMvCnnPeR0HeGMFhwzLHEHQJV0S5qC1y7aBk1mmuJ8h1Qr0xn1Pd bj/5RUEGr8VNYrYTDMzAvM8yz99PkwWxMk0pJm6B0OOkCpZIyBZjbDfEYlbgDFy3nvgX iCvvQqobnSyWSDCjckjyw2rFjKA0Ygt6KDxS9mttFwP9k7RfaJyyVbd6mdrXPm4IsEis SEbBtOMpnrzuSTfDDdQskZlnfHEC8zqN/Clgx9j0xB67APJTbZqSR4jY2mzvUsM3TIGx yLrw== X-Gm-Message-State: AHPjjUgH4cyRh9+bfaSBqlVTK3upmoi0WXCJAMUpaSsqnOhWdKLKCpMb HDfvpHvlt/IXEfGNvU4= X-Google-Smtp-Source: ADKCNb6ohaizjoYG5oI4EveOFieodFBMCtEA83nEPh4QWuURCT7zHInp3MoDhAkHO7Mv6n1Ln9KnHQ== X-Received: by 10.84.128.78 with SMTP id 72mr1050877pla.376.1504537918583; Mon, 04 Sep 2017 08:11:58 -0700 (PDT) Received: from [10.102.137.73] ([139.227.181.98]) by smtp.gmail.com with ESMTPSA id k17sm11694179pgf.0.2017.09.04.08.11.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Sep 2017 08:11:57 -0700 (PDT) To: Jordan Justen , Laszlo Ersek , edk2-devel@lists.01.org Cc: Ard Biesheuvel References: <20170903021214.11516-1-ge.song@hxt-semitech.com> <20170903021214.11516-2-ge.song@hxt-semitech.com> <150453207055.10722.7097788282280420028@jljusten-skl> From: Ge Song Message-ID: <7db5728c-a901-012e-0584-99c4b10d988e@gmail.com> Date: Mon, 4 Sep 2017 23:11:53 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <150453207055.10722.7097788282280420028@jljusten-skl> Subject: Re: [PATCH v1 1/1] OvmfPkg/SecMain: Fix stack switching to permanent memory fail X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Sep 2017 15:09:11 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US On 09/04/2017 09:34 PM, Jordan Justen wrote: > On 2017-09-03 16:55:36, Laszlo Ersek wrote: >> On 09/03/17 04:12, Ge Song wrote: >>> In earlier PEI stage, temporary memory(Cache As Ram) is employed as stack >>> and heap. We move them to the new room and do some relocation fixup when >>> permanent memory becomes available. TemporaryRamMigration() >>> is responsible for switching the stack. >> [...] >> >>> Cc: Jordan Justen >>> Cc: Laszlo Ersek >>> Cc: Ard Biesheuvel >>> Contributed-under: TianoCore Contribution Agreement 1.1 >>> Signed-off-by: Ge Song >>> --- >>> OvmfPkg/Sec/SecMain.c | 2 ++ >>> 1 file changed, 2 insertions(+) >> (No more separate emails, I promise.) >> >> Before you send v2, can you please amend the patch like this: >> >> git commit --amend --author='Ge Song ' >> >> It's OK if you mail it out from another email address, but IMO the git >> authorship should match the first Signed-off-by. > I disagree with this. Unless the individual is well known to the EDK > II community as the owner of both email addresses, I think the author > needs to send it from their author email. > > I suppose they can send it from another email, and then reply from > their other email saying they contributed it under the Tianocore > Contribution Agreement, but that sounds like a stretch... > > -Jordan OK, I'll try to send it from the same email address next time, the reason that using two different mail addresses is because the author email is an exchange account and it's hard to find the mail server preferences for git-send-email... > >> The commit message body currently does not start with "From: Ge Song >> ", which means that the git authorship and the >> first S-o-b disagree at the moment. >> >> ... If I'm wrong about this, I can be convinced, of course. >> >> Thanks >> Laszlo