From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0081.outbound.protection.outlook.com [104.47.41.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A02A221E0C313 for ; Wed, 9 Aug 2017 10:33:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=PG/lzhP6macmEuQrnyBwG0SBZ9Zdjy7hxhOk08vztvs=; b=qzEJ9JF3RT0AA8Oyezj/wwTjHsiphCEMNoW9VXzt0pvCjUV+ygnVh5ROYCyPNp9VEJI+MTo9tq9iFYKEu5huiz9r32zFlvqap7A2g2XQEosl9vof4SBbZ1Ds/GzgOu/HwII7gIozisn+cK5F6sI3264UnCF2EzeQOdGnlhHoLoU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Received: from [10.236.136.62] (165.204.77.1) by DM2PR12MB0156.namprd12.prod.outlook.com (2a01:111:e400:50ce::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1320.16; Wed, 9 Aug 2017 17:35:53 +0000 Cc: brijesh.singh@amd.com, Jordan Justen , Tom Lendacky , Ard Biesheuvel To: Laszlo Ersek , edk2-devel@lists.01.org References: <1502107139-412-1-git-send-email-brijesh.singh@amd.com> From: Brijesh Singh Message-ID: <7dc9df48-98c4-4df4-9b8b-7732ad3f4f2d@amd.com> Date: Wed, 9 Aug 2017 12:35:50 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: DM5PR20CA0041.namprd20.prod.outlook.com (2603:10b6:3:13d::27) To DM2PR12MB0156.namprd12.prod.outlook.com (2a01:111:e400:50ce::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bce49a1f-bc0f-486e-70bd-08d4df4d15e7 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:DM2PR12MB0156; X-Microsoft-Exchange-Diagnostics: 1; DM2PR12MB0156; 3:ojo6coggWTfdYZuT4pMeLZKMjnXvi4aMJ/MVGBAVVUnLpVxlkIU8dfKWxXwYqhfZ+AMBIE3wkuAAlwn/JBaMyKzp1YSm4XhNimmU0bvCqHW1Uk8cGJ7gFKqHCaBlyOtWVYaVqpwcQ3MNPpla9NplyI5Dv1aYSb4W2QbJXqhgzqh2cKXK5FsJuELafz76vQM/XVhhNz68dE876pYIXx9BJX0RdV+3ZpYiGFMWtByHzVcR2BhHeKPa5qj7hgvo3HOI; 25:mxCXRyb6nj1gZ8YUpYfQK/Gr+Cb2EsaEh/249hd10s+zLO13f7uU49cIZNWlQKaLWKEudbmpQh7pIkPa4DODnQ5kfgwwrF4xIfZAGDL3k9vImUV2WmNhTefc3cNYD/i2jxWMSToTimKrHkVkClJRjQTne/+M2LfJ95UsTMunTSvMCWnUdHlcfIbS3+zTTGmPVzVCUliXEv5gTOJbAq0PfQBbmy6Yf4KmS+3TknzOpjLWQ/pmVZjSQbVfGO9+JtXHV88mqXtLpaZiAfTHgSrfCrFmsJsey+fG1mIjXXSO8834OmAG7Tkx2+IeP2N20I0ulSkO9UoEz9cR7xccjFKzeg==; 31:Cqs9qaLrNEpVUkQ8vp22rZNHoYD4subfXv8BNE5jAKrUn2ztl4LY5E6FvP6mu56uL1I3VhXktAcP+8SinbQC67Y7d3H0Gng1o1Qm+Es3B8RzvzUWhYLtTgkTopwZ4B7T4/DnK6TlUo8MvrI+11sTngM/a5tRwmtn3VAiCQKzu2TjLHLIJ3i6CzvLTZUWLsa068C0w2rW8Ie4W3ZGVR1K2qjup/D/yE5tc8C0bxPAU7c= X-MS-TrafficTypeDiagnostic: DM2PR12MB0156: X-Microsoft-Exchange-Diagnostics: 1; DM2PR12MB0156; 20:EOJJF3iQkjOq3n6WA4Ucx1lOKc+0p1qOoEW7lqUPMhv00EIpeC2uE6cmxWj4lULTeHCLM8Vai0kwWHQNnmqIjhavuvKmXpoLhpft1ohJmIu+Qc2uisNB+TSo04MlftNhys7w0ldSAfzDCy/ZNSJ7BYvcS7lE3XvZrJHapNRISLPk3PONRCILyA5NKjk1blAkOcVstmxjgC/xmFJ8B2MXQfAF/IdcS2E7ahUDA4nhTC4y0IFRQHUBYlrvzseregjUQ/1k9mRbXu0qpIzOAXy0BVop0U7OJcf8C4KXOtPpZsN2NsgL6DrJZMi1FfvmRTHMz0PNdDjB0UC+iud3jluiPQi7nL+ZbQWuvLzZAaImYfysuIsGdEkG+5qHMlXEWH1PDgi7wuMfUMUjyfUDDm3iq309YtAvdLjUB8YMuP7pSgjgWKfYF5XffD1xlf28xTuHp6FHIFzxCsswY/hDHas6WDfjVT0TOPJj7IqrGvpKCRfX74I0NJdIe24sXS3k4PYb; 4:gRAyOzHFUGTmjj8ATVMZ/EJzQc9G6nDMSIWG9qL5MSR9V5kf+SKd/p2tUHdd9Ef9JScJt33J4+/BoNvT5BXCuZLQ/UjoxCm8K0yykRJNq3LlkasBiROB6efPTVsQUQ0zctxFZG8AOXWw9ZkXFMbnIDaZArjG/lFAFw7/mm7eXSPrWN81DkUkVDpHr2tEyRxMLRd4yAfn0+uROoi3e701DCsXKI9M3FCjajJspD209PJ7hYt4c6UFOXXwMYyO07oY X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(6055026)(6041248)(20161123555025)(20161123564025)(20161123560025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DM2PR12MB0156; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DM2PR12MB0156; X-Forefront-PRVS: 0394259C80 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(7370300001)(4630300001)(6049001)(6009001)(39450400003)(39860400002)(39840400002)(39410400002)(39850400002)(39400400002)(199003)(189002)(377454003)(24454002)(68736007)(8676002)(50986999)(50466002)(105586002)(76176999)(47776003)(54356999)(66066001)(65956001)(65806001)(6246003)(81166006)(305945005)(6116002)(3846002)(4326008)(2950100002)(31686004)(53546010)(110136004)(97736004)(83506001)(38730400002)(101416001)(4001350100001)(966005)(478600001)(7736002)(81156014)(36756003)(54906002)(31696002)(65826007)(2906002)(230700001)(86362001)(189998001)(64126003)(33646002)(229853002)(53936002)(6306002)(77096006)(106356001)(5660300001)(25786009)(42186005)(23676002)(7350300001)(6486002); DIR:OUT; SFP:1101; SCL:1; SRVR:DM2PR12MB0156; H:[10.236.136.62]; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTJQUjEyTUIwMTU2OzIzOk9zVUlHcExBM3hwck1mRHhzQjdtSUtnUGZN?= =?utf-8?B?SWpaczB1SkZVdkJpQStKa0VqTGx6aVcwRGRCVzZzdjlGcndWQkw1RkZLZjAz?= =?utf-8?B?bkVXU0gxaFpVT09oRFJxMk0yNUVQaHI4bzVqZFJVeDAxcjZubi9lV0VabThN?= =?utf-8?B?NU9tODRrVGNpVGdZTEZYU2c5NGROekRUajJOblpla21nZDdMbnREZ1pGR1pI?= =?utf-8?B?NFVqdlBwM2l1N29QMDB0ai9CNkYrUjJBd2NSNSt5bnUvM29FNS8rRlhJUUw0?= =?utf-8?B?d1BFYkFwMFdtcnVVR1IrZ25VSUozd05ZTDJUemx2YkN0Y0txQ3c0cEhrT2sz?= =?utf-8?B?Z0NyV3hLREVWODZCd0Y2NnFVSWNkSmRkWWFWRmhBTHlFNVpGQVI1MFdHc28y?= =?utf-8?B?NXUxS3VOaUVxZUIvTFE5NW5VUyt4Y0w4V282SGdleHcybzVRa1NSeGxBckdY?= =?utf-8?B?eG1MUzNhMDN3L0dsMjJyeUVPOGVDOFlKWnVNS1NLR2lNR3pyOS93NS9rSE4r?= =?utf-8?B?dGt3SW1oWkFCNVNlK1ZRd1lNemx1emk3eUxWbWlFV2owVFdkZncwMzVaZGU5?= =?utf-8?B?L1BlR1Q3eE1tM0VieHptcGFmVjJiZTR6aW1jYzV4NEVEdTZ0cWUyN0FpdHJK?= =?utf-8?B?bUFQVVJwdDVYZ0tJMjB4Ujg4dzFoN0RJbW5IaW1iQ1NPZE5zUlZoSTI5b2t0?= =?utf-8?B?OXFVcWl6Y3RjYW54Y0R4TlFrVUhjNTBNcEVCVUZFY0lMZHB5ME1mOGYvS0Uw?= =?utf-8?B?ZEJFRy9GZXJ2WCt1QzFJMXZWdXRyMW5DaE1RL1dJMmkwcnZJVWphQ2dyc1c0?= =?utf-8?B?ZzlIelBFcGJveGVudVlJTWt0YmVjMFFmeWxQVmlNaExteHpqM0pIRWROYXdJ?= =?utf-8?B?RXZVSm5NQTdTeXhGNk1jbEx6alg0YUdWbWJYWE0wUXBud0hIMEZDOE9ObjM0?= =?utf-8?B?bmd4RmVNdUlUeTBkdE5TZEQwVnRLMHlkczRiM29CMm40c0Y3QjdyT0ZrRm55?= =?utf-8?B?L3IwQjQ1RDVoTUhJVmVFVE1BOUkzZmxOOThRVXoxd0dJU2hPK0FxVGtoWmhI?= =?utf-8?B?c1pvZHNRTUw4T29ILzFWY3BtbDQ1dTdGbjhqa0dpSC9Gb3dMZ1dzanF6bXFw?= =?utf-8?B?YlBnMlFHVnFOWmplMnNsSXJqeVZMWCt2eUdyZXdITUxmVzZWVnBsdjIrS0xN?= =?utf-8?B?cnZxMEJJQ3h1Vkt0cG5PRkxxbFRiRmQwa2xHdXY5MENTNGRPbGI2VURSV250?= =?utf-8?B?eXJPVVJWVGhzb2RFdWpKV3ZBWFA4TjV3cEpxYzFadldFb3A2Q2ZtWkJDZFU4?= =?utf-8?B?dGN4QzQ2eVFaek5wY1QzSlZqV3c3Q0QzZlovMkVzc3JsUENLUTJVRis3cGc0?= =?utf-8?B?VUtsZUpXRXNJaWF6R016RmFaemhqeHdsc1BpcndvV1Zpc2Q4QzduTFA1MW91?= =?utf-8?B?YzNBRVpvQzNKblUvVmQ2Z3M5V0NaeXhTb1d5Z3dCVmszREp5VGJSYnhaaUNq?= =?utf-8?B?WUZkWmF4bGNBYnhUd2ZCOUlONnlBWmRra1A0WFZZYmxhczhGVnhkQk9LWVM4?= =?utf-8?B?cTRtNTNuYXlUcnBtcXF4UmdXMHNkV3NNTnFzbDFBekd6bFhXZ1ZQZG83QU9T?= =?utf-8?B?NkU0Ym1SYnpyMVJIcEhzQ0xFeG5ENmpiN0wvdUxqUGdSNEZSMWJISkZOV3ly?= =?utf-8?B?ZlB6UjVSUVVyYk91cnhON1VLMWx0N01PWUJteXBrL0pIVXYzNGs4bUdxV2RG?= =?utf-8?B?VXBvdi9KdlA4cVFJRHl6UGlBLzdubGxnV2VablIvNHpVd3VQdlh4UmQzc0Y5?= =?utf-8?B?NlRFQW5SeHhkblZrazRuSVQ2Wk15NGxFQm9GclM2cE93a1IwbEtINUJ1NkZF?= =?utf-8?B?a1k4VGtKeUd0TzZlQ1E5UU9oMjdCNmd2L2h6bTlQUk1TaTl6Uk5JbTRNN3pt?= =?utf-8?B?TjRsZkRFTmhIT0Fjb1NSdW5Mb3VEV0p0UnFnVjZCL0FpUjVmcnVvVUN5ZUNS?= =?utf-8?B?WTRsMWUxZ3hBSFgwUnA1SEcxTGFqVzUveGlEWkU4YWh2ZC9tTzBaT1ZGMzB4?= =?utf-8?B?eXBvV0tldFRNYng3VElSSWU5bXd2aVI1WkNtVW9LeWh4U0hFNUhHSUtRbzl1?= =?utf-8?Q?sqlNEVH7zhRxYZis2YM6tl8=3D?= X-Microsoft-Exchange-Diagnostics: 1; DM2PR12MB0156; 6:amybUssxb2QpxsDRUTyUwy95IeoMvXjOZsyOb4auzwj1zFUd3PF4byYJ6hYc2HJRHTQ2mu4tCNu9/XnaPV9FJyz/XJwKs7sQdqDbAfk77QOdEmWU0R66v+I638x6iTyb4zgyDZ+Msxv0MQZyvGS7zxtFQCqI468NuYFiC5NcAxq7pIchf1MwR5mpyq32YFyEB6PlizUUQxzSjEN+wcGMtSXtLSTxAVTibAlXZ7UCo2vVOr0SYkB+hclJtaYd25c3l7sBvxlg7wiET6reTUvw5Jt2tbzAFY9j14NKtBN/Lz2D5hvo/u2YgkNh8HlL3KyOZU4ha16P2nAfWZxz4HYMUw==; 5:77Bu8Sxxk1yrwQ8w7mZZS4OGIjyFZRz1K0znEP/I313Tu//AYDi46E8d4lRT2bsThXQSNNlJYrVTZe4H8+3J2JaXqJ/NCdLrIQnu16Yqgv7wkMDlUSjNEU/dhaC7lQVVwMZdgworMcLv3ocPtGYJBw==; 24:WPGTN64gtvRpMehpNtfEAr23YC2KKFDsINN2PxDPcZZqg0HDCYJ6frqY//Ex68nDMRJiqmrmf6DFqEgzpQpgCxABqzq1o5lNk0WYMjojUSc=; 7:7LZVf0hwl/4UWopdVVfhwvFgnouahHAMeuVSsagTO4ME3dKHi5bbhDRT6kMRIT/+rSGtX3ZqdrUslw61uc6WbAOnlxuComGQiHoSdoHv0wFv7bbI95lzs+xcyMfrNHiy5nuT+PXUdcyRLJg2RiLU/UAgAVv2mCqMYt8eay2YbB6DBZqn8VKP5JWPuE2n4MSEtY+XJWWMwKManBvv4MPZVNX4razrGDjRn2mOo5ZWPDU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM2PR12MB0156; 20:CenfAaXYsh+FxCMO3OeoQb6gfKEloUICXL0kexRqfDq/2xc3yCxVziGmJa6h9Hy5OW8E+jiKA45Hg9DJ4sp4fHejGWYhQkTUsa36ycPTY9Kt2VFFCHQvEeTY/ZqOZwxdRi02Ipx2t7ZnijO+pmkxEwB3mtFojwXDpb6IWm2D4w924D+spMRW6rPGoVpxeW3WsfpG7e2tDAtRuU4Xo0MKx8MvKU6//KpC5AQLJ/zC+JI2v28mXVdMsMujliNN/s2E X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2017 17:35:53.7172 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR12MB0156 Subject: Re: [PATCH v1 00/14] OvmfPkg/Virtio: Add APIs to map system physical to device address X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Aug 2017 17:33:37 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 08/09/2017 09:39 AM, Laszlo Ersek wrote: > On 08/07/17 13:58, Brijesh Singh wrote: >> Currently, virtio drivers provides the system physical address to the device. >> However, some systems may feature an IOMMU that requires the drivers to pass >> the device addresses to the device - which are then translated by the IOMMU >> into physical addresses in memory. The patch series introduces new member >> functions in VIRTIO_DEVICE_PROTOCOL which can be used for mapping a system >> physical address to device address. >> >> The approach that this patch series takes is to maps the system physical >> address to device address for buffers (including rings, device specifc >> request and response pointed by vring descriptor, and any further memory >> reference by those request and response). >> >> Patch 1 - 3: >> Defines and implements new member functions to map a system physical address >> to device address. The patch implements Laszlo's suggestion [1]. > > (1) I guess under [1] you meant the following message: > > http://mid.mail-archive.com/841bec5f-6f6e-8b1f-25ba-0fd37a915b72@redhat.com > Yes, thank you :) I did not realized that I forgot adding the link. > If you want, you can add that link to the commit message of patch #1. > > (2) But, that's not my main point here. Before I forget, I'd like to > point out that you missed one of the three virtio protocol > implementations -- see my point (5.4) in the above-referenced message > --, namely: > >> - "ArmVirtPkg/VirtioFdtDxe" (via >> "OvmfPkg/Library/VirtioMmioDeviceLib") binds virtio-mmio devices, >> and offers virtio 0.9.5 semantics. > > So please replicate patch v1 03/14 to > "OvmfPkg/Library/VirtioMmioDeviceLib". Otherwise, the modified virtio > device drivers will crash when they are built for ArmVirtPkg and used > over virtio-mmio transports. > Sure, I will make the necessary changes in VirtioMmioDeviceLib and try do the build test but I don't have aarch64 platform to verify at the runtime. > (3) Starting with your v2, please add a reminder to your blurb -- for > Ard and myself -- that before merging this, we should regression-test it > on aarch64. > Will do