From: "Thomas Abraham" <thomas.abraham@arm.com>
To: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>,
sami.mujawar@arm.com, ardb+tianocore@kernel.org
Cc: quic_llindhol@quicinc.com, devel@edk2.groups.io
Subject: Re: [edk2-platforms][PATCH] Platform/Sgi: Remove inaccurate comment in dsc file
Date: Tue, 6 Sep 2022 13:36:43 +0100 [thread overview]
Message-ID: <7e1b7a04-a414-5634-e082-026e3fe0377b@arm.com> (raw)
In-Reply-To: <20220905142929.33238-1-vijayenthiran.subramaniam@arm.com>
On 05/09/2022 15:29, Vijayenthiran Subramaniam wrote:
> The base address of NV storage are different on reference design
> platforms after the introduction of the RD-N2 platform. So the comment
> for the NV storage sizes for variables is corrected as it is now
> inaccurate. The base address of NV storage is correctly listed in the
> SgiMemoryMap.dsc.inc and SgiMemoryMap2.dsc.inc files.
>
> Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
> ---
> Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> index b3627c7f0f01..2f5dadfaefc6 100644
> --- a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> +++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> @@ -123,7 +123,7 @@ [PcdsFixedAtBuild.common]
> gArmSgiTokenSpaceGuid.PcdOscCppcEnable|1
> !endif
>
> - # NV Storage PCDs. Use base of 0x08000000 for NOR0, 0xC0000000 for NOR 1
> + # NV Storage PCDs.
> gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize|0x01400000
> gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingSize|0x01400000
> gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareSize|0x01400000
Reviewed-by: Thomas Abraham <thomas.abraham@arm.com>
next prev parent reply other threads:[~2022-09-06 12:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-05 14:29 [edk2-platforms][PATCH] Platform/Sgi: Remove inaccurate comment in dsc file Vijayenthiran Subramaniam
2022-09-06 12:36 ` Thomas Abraham [this message]
2022-09-06 16:52 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e1b7a04-a414-5634-e082-026e3fe0377b@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox