From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 41587AC1146 for ; Tue, 31 Oct 2023 10:42:28 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=oRUEN5AZSltryO60IfLwbxs54avsqRBLi8nMqYsH6YA=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698748947; v=1; b=BkTeN+ADguqptjc8xN1Betka7XSQYwVMdGFuBl7UQZmkogUWAvK/aa5xoOMMtrFODQXwZRQp gkTGIfw04CcOKRUsGGsfHzSZfNu03Mccum/sZxY74Rj4saO2Pf2pgPVN8BKpjjwhWzGPZiTlEF6 NNFZZ6PYTDnYI3DqxTpQ+Bw4= X-Received: by 127.0.0.2 with SMTP id WHbEYY7687511xvNG1AWFm1M; Tue, 31 Oct 2023 03:42:27 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.182966.1698748946399623277 for ; Tue, 31 Oct 2023 03:42:26 -0700 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-202-XmDE4MgkMpiPfD7zyqsPrA-1; Tue, 31 Oct 2023 06:42:21 -0400 X-MC-Unique: XmDE4MgkMpiPfD7zyqsPrA-1 X-Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0631589CA01; Tue, 31 Oct 2023 10:42:21 +0000 (UTC) X-Received: from [10.39.195.34] (unknown [10.39.195.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CD91C1121307; Tue, 31 Oct 2023 10:42:19 +0000 (UTC) Message-ID: <7e2c9017-16b9-bb15-f867-e6aba0c2f6a0@redhat.com> Date: Tue, 31 Oct 2023 11:42:18 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v7 4/5] MdePkg: Utilize Cache Management Operations Implementation For RISC-V To: Sunil V L , devel@edk2.groups.io, dhaval@rivosinc.com Cc: Michael D Kinney , Liming Gao , Zhiguang Liu References: <20231029144613.150580-1-dhaval@rivosinc.com> <20231029144613.150580-5-dhaval@rivosinc.com> From: "Laszlo Ersek" In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 7DrIvybTLKnNg76nvPlwHBQcx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=BkTeN+AD; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 10/30/23 12:22, Sunil V L wrote: > On Mon, Oct 30, 2023 at 04:48:18PM +0530, Sunil V L wrote: >> On Sun, Oct 29, 2023 at 08:16:12PM +0530, Dhaval Sharma wrote: >>> Use newly defined cache management operations for RISC-V where possible >>> It builds up on the support added for RISC-V cache management >>> instructions in BaseLib. >>> Cc: Michael D Kinney >>> Cc: Liming Gao >>> Cc: Zhiguang Liu >>> Cc: Laszlo Ersek >>> >>> Signed-off-by: Dhaval Sharma >>> Acked-by: Laszlo Ersek >>> --- >>> >>> Notes: >>> V7: >>> - Added PcdLib >>> - Restructure DEBUG message based on feedback on V6 >>> - Make naming consistent to CMO, remove all CBO references >>> - Add ASSERT for not supported functions instead of plain debug mes= sage >>> - Added RB tag >>> V6: >>> - Utilize cache management instructions if HW supports it >>> This patch is part of restructuring on top of v5 >>> >>> MdePkg/MdePkg.dec | = 8 + >>> MdePkg/Library/BaseCacheMaintenanceLib/BaseCacheMaintenanceLib.inf | = 5 + >>> MdePkg/Library/BaseCacheMaintenanceLib/RiscVCache.c | 1= 68 +++++++++++++++++--- >>> MdePkg/MdePkg.uni | = 4 + >>> 4 files changed, 165 insertions(+), 20 deletions(-) >>> >>> diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec >>> index ac54338089e8..fa92673ff633 100644 >>> --- a/MdePkg/MdePkg.dec >>> +++ b/MdePkg/MdePkg.dec >>> @@ -2399,6 +2399,14 @@ [PcdsFixedAtBuild.AARCH64, PcdsPatchableInModule= .AARCH64] >>> # @Prompt CPU Rng algorithm's GUID. >>> gEfiMdePkgTokenSpaceGuid.PcdCpuRngSupportedAlgorithm|{0x00,0x00,0x00= ,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00}|VOID*|0x= 00000037 >>> =20 >>> +[PcdsFixedAtBuild.RISCV64, PcdsPatchableInModule.RISCV64] >>> + # >>> + # Configurability to override RISC-V CPU Features >>> + # BIT 0 =3D Cache Management Operations. This bit is relevant only i= f >>> + # previous stage has feature enabled and user wants to disable it. >> NIT: I am wondering whether PcdRiscVCpuFeatureDisable is better so that >> it is explicit. >> >>> + # >>> + gEfiMdePkgTokenSpaceGuid.PcdRiscVFeatureOverride|0xFFFFFFFFFFFFFFFF|= UINT64|0x69 >>> + >> Instead of this, can default value match only those features which are >> enabled by default for qemu virt machine? That way, I think we can avoid >> having this PCD defined again in RiscVVirt. >> > Sorry, I take back. This is common for all platforms. So, we can't take > qemu as reference. yes, and sorry that I'm only seeing your addition now! Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110398): https://edk2.groups.io/g/devel/message/110398 Mute This Topic: https://groups.io/mt/102256468/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-