public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Rebecca Cran" <rebecca@bsdio.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	Leif Lindholm <quic_llindhol@quicinc.com>,
	"Kubacki, Michael" <michael.kubacki@microsoft.com>
Subject: Re: [edk2-devel] [PATCH edk2-platforms v3 0/1] Move to the GitHub Pull Request workflow
Date: Mon, 19 Aug 2024 16:14:47 -0600	[thread overview]
Message-ID: <7e5041db-8d35-4369-9bf9-863eb85601c6@bsdio.com> (raw)
In-Reply-To: <CO1PR11MB4929D74CAB7B74ACA16816E4D2BF2@CO1PR11MB4929.namprd11.prod.outlook.com>

Could you explain what you entered into the New GitHub App page when 
setting up tianocore to use 
https://github.com/marketplace/actions/create-github-app-token please?


-- 

Rebecca


On 8/6/24 1:14 PM, Kinney, Michael D wrote:
> I suspect you will run into the same permissions issues that required
> the use of a GitHub App credentials to run the AssignReviewers.yml.
>
> See this change for reference:
>
> 	https://github.com/tianocore/edk2/pull/6050
>
>
> Mike
>
>> -----Original Message-----
>> From: Rebecca Cran <rebecca@bsdio.com>
>> Sent: Tuesday, August 6, 2024 10:36 AM
>> To: devel@edk2.groups.io; Leif Lindholm <quic_llindhol@quicinc.com>; Kinney,
>> Michael D <michael.d.kinney@intel.com>
>> Subject: Re: [edk2-devel] [PATCH edk2-platforms v3 0/1] Move to the GitHub
>> Pull Request workflow
>>
>> Could I get some reviews on this please?
>>
>>
>> --
>>
>> Rebecca
>>
>>
>> On 8/1/24 3:43 PM, Rebecca Cran wrote:
>>> Changes from v2 to v3:
>>>
>>> Added note to AssignReviewers.yml to say where it was copied from.
>>>
>>> Sorted platforms in CODEOWNERS and REVIEWERS alphabetically.
>>> Sorted entries in CONTRIBUTORS.md by first name.
>>>
>>> Updated CONTRIBUTORS.md with some more GitHub usernames.
>>> Updated Readme.md to clarify that people own _areas_ of the repo, not
>>> specifically packages.
>>>
>>> Rebecca Cran (1):
>>>     Move to the GitHub Pull Request workflow
>>>
>>>    .github/workflows/AssignReviewers.yml |  31 ++
>>>    CODEOWNERS                            | 146 +++++++
>>>    CONTRIBUTORS.md                       |  68 +++
>>>    Maintainers.txt                       | 445 --------------------
>>>    REVIEWERS                             |  92 ++++
>>>    Readme.md                             |  33 +-
>>>    6 files changed, 365 insertions(+), 450 deletions(-)
>>>    create mode 100644 .github/workflows/AssignReviewers.yml
>>>    create mode 100644 CODEOWNERS
>>>    create mode 100644 CONTRIBUTORS.md
>>>    delete mode 100644 Maintainers.txt
>>>    create mode 100644 REVIEWERS
>>>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120367): https://edk2.groups.io/g/devel/message/120367
Mute This Topic: https://groups.io/mt/107675097/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  parent reply	other threads:[~2024-08-19 22:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <17E7B8D5FB5780B0.20637@groups.io>
2024-08-06 17:35 ` [edk2-devel] [PATCH edk2-platforms v3 0/1] Move to the GitHub Pull Request workflow Rebecca Cran
2024-08-06 19:14   ` Michael D Kinney
2024-08-06 20:56     ` Rebecca Cran
2024-08-06 22:59       ` Michael D Kinney
2024-08-19 22:14     ` Rebecca Cran [this message]
2024-08-19 23:01       ` Michael D Kinney
2024-08-19 23:30         ` Rebecca Cran
2024-08-20  1:58           ` Michael D Kinney
2024-08-20  2:04             ` Michael Kubacki
2024-08-01 21:43 Rebecca Cran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7e5041db-8d35-4369-9bf9-863eb85601c6@bsdio.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox