From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.23560.1688377355985483131 for ; Mon, 03 Jul 2023 02:42:36 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: pierre.gondois@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 075571FB; Mon, 3 Jul 2023 02:43:18 -0700 (PDT) Received: from [10.34.100.101] (e126645.nice.arm.com [10.34.100.101]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 727BD3F762; Mon, 3 Jul 2023 02:42:34 -0700 (PDT) Message-ID: <7e552d3e-7eb3-9d31-d3dd-97ec509402c4@arm.com> Date: Mon, 3 Jul 2023 11:42:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 From: "PierreGondois" Subject: Re: [PATCH 1/4] DynamicTablesPkg: Add ThermalZone CodeGen function To: Jeff Brasen , devel@edk2.groups.io Cc: Sami.Mujawar@arm.com, Alexei.Fedorov@arm.com, Swatisri Kantamsetti , Ashish Singhal References: <5a12f37462d227f2e55175eb47fa4a955c587dac.1688079404.git.jbrasen@nvidia.com> In-Reply-To: <5a12f37462d227f2e55175eb47fa4a955c587dac.1688079404.git.jbrasen@nvidia.com> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hello Jeff, Reviewed-by: Pierre Gondois On 6/30/23 01:01, Jeff Brasen wrote: > Add API to generate a ThermalZone object to AmlLib. > > Signed-off-by: Jeff Brasen > Reviewed-by: Swatisri Kantamsetti > Reviewed-by: Ashish Singhal > --- > .../Include/Library/AmlLib/AmlLib.h | 28 +++++ > .../Common/AmlLib/CodeGen/AmlCodeGen.c | 116 ++++++++++++++++++ > 2 files changed, 144 insertions(+) > > diff --git a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h b/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h > index 9210c50915..d201ae9499 100644 > --- a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h > +++ b/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h > @@ -1038,6 +1038,34 @@ AmlCodeGenDevice ( > OUT AML_OBJECT_NODE_HANDLE *NewObjectNode OPTIONAL > ); > > +/** AML code generation for a ThermalZone object node. > + > + AmlCodeGenThermalZone ("TZ00", ParentNode, NewObjectNode) is > + equivalent of the following ASL code: > + ThermalZone(TZ00) {} > + > + @ingroup CodeGenApis > + > + @param [in] NameString The new ThermalZone's name. > + Must be a NULL-terminated ASL NameString > + e.g.: "DEV0", "DV15.DEV0", etc. > + The input string is copied. > + @param [in] ParentNode If provided, set ParentNode as the parent > + of the node created. > + @param [out] NewObjectNode If success, contains the created node. > + > + @retval EFI_SUCCESS Success. > + @retval EFI_INVALID_PARAMETER Invalid parameter. > + @retval EFI_OUT_OF_RESOURCES Failed to allocate memory. > +**/ > +EFI_STATUS > +EFIAPI > +AmlCodeGenThermalZone ( > + IN CONST CHAR8 *NameString, > + IN AML_NODE_HANDLE ParentNode OPTIONAL, > + OUT AML_OBJECT_NODE_HANDLE *NewObjectNode OPTIONAL > + ); > + > /** AML code generation for a Scope object node. > > AmlCodeGenScope ("_SB", ParentNode, NewObjectNode) is > diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c > index 0b223379fa..88537b7e2d 100644 > --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c > +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c > @@ -1218,6 +1218,122 @@ error_handler1: > return Status; > } > > +/** AML code generation for a ThermalZone object node. > + > + AmlCodeGenThermalZone ("TZ00", ParentNode, NewObjectNode) is > + equivalent of the following ASL code: > + ThermalZone(TZ00) {} > + > + @ingroup CodeGenApis > + > + @param [in] NameString The new ThermalZone's name. > + Must be a NULL-terminated ASL NameString > + e.g.: "DEV0", "DV15.DEV0", etc. > + The input string is copied. > + @param [in] ParentNode If provided, set ParentNode as the parent > + of the node created. > + @param [out] NewObjectNode If success, contains the created node. > + > + @retval EFI_SUCCESS Success. > + @retval EFI_INVALID_PARAMETER Invalid parameter. > + @retval EFI_OUT_OF_RESOURCES Failed to allocate memory. > +**/ > +EFI_STATUS > +EFIAPI > +AmlCodeGenThermalZone ( > + IN CONST CHAR8 *NameString, > + IN AML_NODE_HANDLE ParentNode OPTIONAL, > + OUT AML_OBJECT_NODE_HANDLE *NewObjectNode OPTIONAL > + ) > +{ > + EFI_STATUS Status; > + AML_OBJECT_NODE *ObjectNode; > + AML_DATA_NODE *DataNode; > + CHAR8 *AmlNameString; > + UINT32 AmlNameStringSize; > + > + if ((NameString == NULL) || > + ((ParentNode == NULL) && (NewObjectNode == NULL))) > + { > + ASSERT (0); > + return EFI_INVALID_PARAMETER; > + } > + > + ObjectNode = NULL; > + DataNode = NULL; > + AmlNameString = NULL; > + > + Status = ConvertAslNameToAmlName (NameString, &AmlNameString); > + if (EFI_ERROR (Status)) { > + ASSERT (0); > + return Status; > + } > + > + Status = AmlGetNameStringSize (AmlNameString, &AmlNameStringSize); > + if (EFI_ERROR (Status)) { > + ASSERT (0); > + goto error_handler1; > + } > + > + Status = AmlCreateObjectNode ( > + AmlGetByteEncodingByOpCode (AML_EXT_OP, AML_EXT_THERMAL_ZONE_OP), > + AmlNameStringSize + AmlComputePkgLengthWidth (AmlNameStringSize), > + &ObjectNode > + ); > + if (EFI_ERROR (Status)) { > + ASSERT (0); > + goto error_handler1; > + } > + > + Status = AmlCreateDataNode ( > + EAmlNodeDataTypeNameString, > + (UINT8 *)AmlNameString, > + AmlNameStringSize, > + &DataNode > + ); > + if (EFI_ERROR (Status)) { > + ASSERT (0); > + goto error_handler2; > + } > + > + Status = AmlSetFixedArgument ( > + ObjectNode, > + EAmlParseIndexTerm0, > + (AML_NODE_HEADER *)DataNode > + ); > + if (EFI_ERROR (Status)) { > + ASSERT (0); > + AmlDeleteTree ((AML_NODE_HEADER *)DataNode); > + goto error_handler2; > + } > + > + Status = LinkNode ( > + ObjectNode, > + ParentNode, > + NewObjectNode > + ); > + if (EFI_ERROR (Status)) { > + ASSERT (0); > + goto error_handler2; > + } > + > + // Free AmlNameString before returning as it is copied > + // in the call to AmlCreateDataNode(). > + goto error_handler1; > + > +error_handler2: > + if (ObjectNode != NULL) { > + AmlDeleteTree ((AML_NODE_HEADER *)ObjectNode); > + } > + > +error_handler1: > + if (AmlNameString != NULL) { > + FreePool (AmlNameString); > + } > + > + return Status; > +} > + > /** AML code generation for a Scope object node. > > AmlCodeGenScope ("_SB", ParentNode, NewObjectNode) is